)]}'
{"id":"openocd~master~Iace2f881dd65fc763e81b33e6a7113961a7008af","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001667":{"account":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"last_update":"2025-03-25 16:56:59.000000000","reason":"\u003cGERRIT_ACCOUNT_1001667\u003e replied on the change","reason_account":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"}},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2025-05-01 15:26:42.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"Iace2f881dd65fc763e81b33e6a7113961a7008af","subject":"transport: validate the transport id\u0027s from the driver","status":"MERGED","created":"2024-12-26 16:59:22.000000000","updated":"2025-05-01 15:26:45.000000000","submitted":"2025-05-01 15:26:45.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8676","meta_rev_id":"50aa2280553b262281417c505249635d88402a26","_number":8676,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-05-01 15:26:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-05-01 15:26:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-05-01 15:26:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-05-01 15:26:45.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-12-26 18:48:49.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-01-14 17:19:41.000000000","updated_by":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"reviewer":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"state":"CC"},{"updated":"2025-03-25 16:56:59.000000000","updated_by":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"reviewer":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"state":"REVIEWER"},{"updated":"2025-04-20 08:15:14.000000000","updated_by":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"reviewer":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"state":"REVIEWER"}],"messages":[{"id":"584b3e0d64c81157ef47003aeeef2cfc101c2807","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-12-26 16:59:22.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"cfd628858b6ae89704fd7e2f2cea21246b8d829e","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-12-26 18:48:49.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20442/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19594/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"0b0f2cb5515ab91eaafafda48bb8cb7a24ff32dd","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-01-05 15:19:54.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"d26b2d9d45a52246dfdf90c14625110baa66798e","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-01-05 16:29:09.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20483/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19636/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"5930716f82516fe7b106908f9d03c87edbc77798","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2025-01-14 17:19:41.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"32b212fd7c7b1f2a8d6256321ec5eec7ca4869ac","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-02-12 15:51:11.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"0f203a7820b2014fa69e553fb9d37dc1377c1121","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-03-16 14:49:15.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"11e77bf7b01ea39a94d801d411603f6410de9f0b","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-03-16 16:27:33.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20078/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/20938/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"5e3d654b742760c1016e3d6d463c3820da718295","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2025-03-25 16:56:59.000000000","message":"Patch Set 3: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"ea2152b12e274ec27940e27ae925d851d57f7f13","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2025-04-20 08:15:14.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"d246c8c48ef0c39e8fab3b82c7f3ae9e44b864cf","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-05-01 15:26:42.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"50aa2280553b262281417c505249635d88402a26","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-05-01 15:26:45.000000000","message":"Change has been successfully cherry-picked as 8485eb141554851d6cfcf6faf47c5934d13bf040","accounts_in_message":[],"_revision_number":4}],"current_revision":"8485eb141554851d6cfcf6faf47c5934d13bf040","revisions":{"8485eb141554851d6cfcf6faf47c5934d13bf040":{"kind":"REWORK","_number":4,"created":"2025-05-01 15:26:45.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/76/8676/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/76/8676/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/76/8676/4 \u0026\u0026 git checkout -b change-8676 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/76/8676/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/76/8676/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/76/8676/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/76/8676/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/76/8676/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a500b2ce67eb80870dfbd5d73118e822ac99ef88","subject":"adapter: use bitmask for driver\u0027s transports"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-12-22 22:59:19.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-05-01 15:26:45.000000000","tz":0},"subject":"transport: validate the transport id\u0027s from the driver","message":"transport: validate the transport id\u0027s from the driver\n\nVerify that it contains only valid transports.\n\nWhile JTAG and SWD are the more permissive transports, the\nrespective \u0027dapdirect\u0027 versions are slightly limited, and the\nrespective \u0027hla\u0027 versions are even more limited.\nA driver should not provide two version of the same transport.\nVerify that only one JTAG and only one SWD transport is present.\nVerify that the preferred transport is valid too.\n\nChange-Id: Iace2f881dd65fc763e81b33e6a7113961a7008af\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8676\nTested-by: jenkins\nReviewed-by: zapb \u003cdev@zapb.de\u003e\nReviewed-by: Jan Matyas \u003cjan.matyas@codasip.com\u003e\n"}},"8037b5388742ee97ac42de59550aa1fc36ebc4d6":{"kind":"REWORK","_number":1,"created":"2024-12-26 16:59:22.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/76/8676/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/76/8676/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/76/8676/1 \u0026\u0026 git checkout -b change-8676 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/76/8676/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/76/8676/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/76/8676/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/76/8676/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/76/8676/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5b6980fd16904397c362ce7a5b9b8792a27cd4e1","subject":"adapter: use enum for driver\u0027s transports"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-12-22 22:59:19.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-12-26 15:37:53.000000000","tz":60},"subject":"transport: validate the list of transport from the driver","message":"transport: validate the list of transport from the driver\n\nVerify that the list contains only valid transports.\n\nWhile JTAG and SWD are the more permissive transports, the\nrespective \u0027dapdirect\u0027 versions are slightly limited, and the\nrespective \u0027hla\u0027 versions are even more limited.\nA driver should not provide two version of the same transport.\nVerify that only one JTAG and only one SWD transport is present.\n\nChange-Id: Iace2f881dd65fc763e81b33e6a7113961a7008af\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"167d01e7c4cc83c556631827439d43ec83e0b980":{"kind":"REWORK","_number":3,"created":"2025-03-16 14:49:15.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/76/8676/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/76/8676/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/76/8676/3 \u0026\u0026 git checkout -b change-8676 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/76/8676/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/76/8676/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/76/8676/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/76/8676/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/76/8676/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a9d1f75991bee908f8d313624a210d4b8efab9b6","subject":"adapter: use bitmask for driver\u0027s transports"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-12-22 22:59:19.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-03-16 14:40:24.000000000","tz":60},"subject":"transport: validate the transport id\u0027s from the driver","message":"transport: validate the transport id\u0027s from the driver\n\nVerify that it contains only valid transports.\n\nWhile JTAG and SWD are the more permissive transports, the\nrespective \u0027dapdirect\u0027 versions are slightly limited, and the\nrespective \u0027hla\u0027 versions are even more limited.\nA driver should not provide two version of the same transport.\nVerify that only one JTAG and only one SWD transport is present.\nVerify that the preferred transport is valid too.\n\nChange-Id: Iace2f881dd65fc763e81b33e6a7113961a7008af\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"565ad186e70a3ba29361bbf98db20793232adc6d":{"kind":"REWORK","_number":2,"created":"2025-01-05 15:19:54.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/76/8676/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/76/8676/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/76/8676/2 \u0026\u0026 git checkout -b change-8676 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/76/8676/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/76/8676/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/76/8676/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/76/8676/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/76/8676/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8bdbae909dbc7c540467d0e8b8ee8f1a0e594d87","subject":"adapter: use bitmask for driver\u0027s transports"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-12-22 22:59:19.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-01-05 15:07:38.000000000","tz":60},"subject":"transport: validate the transport id\u0027s from the driver","message":"transport: validate the transport id\u0027s from the driver\n\nVerify that it contains only valid transports.\n\nWhile JTAG and SWD are the more permissive transports, the\nrespective \u0027dapdirect\u0027 versions are slightly limited, and the\nrespective \u0027hla\u0027 versions are even more limited.\nA driver should not provide two version of the same transport.\nVerify that only one JTAG and only one SWD transport is present.\nVerify that the preferred transport is valid too.\n\nChange-Id: Iace2f881dd65fc763e81b33e6a7113961a7008af\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}