)]}'
{"id":"openocd~master~I626b50e7a94c141c042eab388cd1ffe77eb864c2","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2025-01-02 16:17:32.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2025-05-01 15:28:18.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I626b50e7a94c141c042eab388cd1ffe77eb864c2","subject":"transport: allow transport name jtag/swd for hla and dapdirect","status":"MERGED","created":"2024-12-26 16:59:22.000000000","updated":"2025-05-01 15:28:18.000000000","submitted":"2025-05-01 15:28:18.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":10,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"8677","meta_rev_id":"88f7b635f30cd891d5df3e28ca2c0d480710abd5","_number":8677,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-05-01 15:28:18.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-05-01 15:28:18.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}],"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-12-26 19:00:15.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-12-30 20:56:22.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"CC"}],"messages":[{"id":"bb75a305ede7d30b9c96486ba9e0d5e56baadf40","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-12-26 16:59:22.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6f1b9d1b71f6a7d238c57834597c4875ca217b6e","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-12-26 19:00:15.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20443/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19595/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"045de07d2516b379320942240505cc04aa2ed178","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-12-30 20:56:22.000000000","message":"Patch Set 1:\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"41b7343f08795604da789b2de9432a038b133eb8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-12-31 16:26:45.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"7ca2d744f2d7315f091bcbb3d2bdb3cf84726284","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-12-31 16:38:10.000000000","message":"Patch Set 2:\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"ec47f362eb06b57ad9fa1e3ff5e414fc4c49773d","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-12-31 17:27:38.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20460/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19613/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"783ff77f011ed54e152a56b48bfdd8c902b74fdf","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-01-02 12:08:37.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"e87f610f79a6144100c321ff00f8d46624cb32d6","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-01-02 15:11:44.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"b8a8aedb334e3a9e88c7fe999034488ebc480779","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-01-02 16:01:29.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"ae753974f2a3ff144f315b4c1d049556380c9377","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-01-02 16:17:32.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"5683d709858153d13d83bd2c10a4beaa1890e066","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-01-05 15:19:54.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"3c69c8fe244c928031c49595c5573075305bfd24","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-01-05 17:30:07.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20488/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19640/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"4336b7cba565342d95b5f4df27d92994482918a6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-03-16 14:49:15.000000000","message":"Uploaded patch set 4.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":4},{"id":"0ef1866131525690ab80ff5e69d29917e7e932c4","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-03-16 17:23:00.000000000","message":"Patch Set 4: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20081/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/20941/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"c605e878704ecc8aaab6788158fb4f9e8a1697d7","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-05-01 15:28:13.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"88f7b635f30cd891d5df3e28ca2c0d480710abd5","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-05-01 15:28:18.000000000","message":"Change has been successfully cherry-picked as c1c4d489df4bbbc2902c0e4ef744157994f1b22a","accounts_in_message":[],"_revision_number":5}],"current_revision":"c1c4d489df4bbbc2902c0e4ef744157994f1b22a","revisions":{"c1c4d489df4bbbc2902c0e4ef744157994f1b22a":{"kind":"REWORK","_number":5,"created":"2025-05-01 15:28:18.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/77/8677/5","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/77/8677/5","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/77/8677/5 \u0026\u0026 git checkout -b change-8677 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/77/8677/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/77/8677/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/77/8677/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/77/8677/5","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/77/8677/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"98c09dc257739440f25f5cd23ca9bbd495e5742a","subject":"transport: store the transports sorted by alphabetic name order"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-02-12 15:30:46.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-05-01 15:28:18.000000000","tz":0},"subject":"transport: allow transport name jtag/swd for hla and dapdirect","message":"transport: allow transport name jtag/swd for hla and dapdirect\n\nThe transport used on adapter\u0027s wires is either \u0027jtag\u0027 or \u0027swd\u0027\nbut, depending on the adapter, in the command \u0027transport select\u0027\nwe have to use either \u0027jtag\u0027 or \u0027swd\u0027 or the similar \u0027hla_jtag\u0027,\n\u0027hla_swd\u0027, \u0027dapdirect_jtag\u0027 or \u0027dapdirect_swd\u0027.\nThis becomes cumbersome when we just want to change adapter and we\nget forced to modify the \u0027transport select\u0027 command too.\n\nThere is no reason for an adapter driver to support two of the\nsimilar transports. In fact \u0027dapdirect\u0027 one is a superset of the\n\u0027hla\u0027, and the native \u0027jtag\u0027 or \u0027swd\u0027 is a superset of the\n\u0027dapdirect\u0027 one.\nWhile the adapter could support more than one similar transports,\nits adapter driver should only support the most complete of these\nsimilar transports.\n\nModify the \u0027transport select\u0027 code to accept \u0027jtag\u0027 or \u0027swd\u0027 for\nthe \u0027dapdirect\u0027 and the \u0027hla\u0027 adapters too.\nIssue a deprecated message for the old \u0027dapdirect\u0027 and \u0027hla\u0027\ntransport names.\nIn command \u0027transport list\u0027, print only the transport names that\ncan be selected through \u0027transport select\u0027 skipping information\nabout \u0027dapdirect\u0027 and \u0027hla\u0027 versions and avoid duplicated entries.\n\nThis improvement was listed in the TODO file. Update it!\n\nChange-Id: I626b50e7a94c141c042eab388cd1ffe77eb864c2\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8677\nTested-by: jenkins\n"}},"d8b9778ddcd68d0d4b5c7620fa4709ed052551fc":{"kind":"REWORK","_number":4,"created":"2025-03-16 14:49:15.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/77/8677/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/77/8677/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/77/8677/4 \u0026\u0026 git checkout -b change-8677 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/77/8677/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/77/8677/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/77/8677/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/77/8677/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/77/8677/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"324340bbc6fb0c913395fdfc453a834d6e407f08","subject":"transport: store the transports sorted by alphabetic name order"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-02-12 15:30:46.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-03-16 14:43:21.000000000","tz":60},"subject":"transport: allow transport name jtag/swd for hla and dapdirect","message":"transport: allow transport name jtag/swd for hla and dapdirect\n\nThe transport used on adapter\u0027s wires is either \u0027jtag\u0027 or \u0027swd\u0027\nbut, depending on the adapter, in the command \u0027transport select\u0027\nwe have to use either \u0027jtag\u0027 or \u0027swd\u0027 or the similar \u0027hla_jtag\u0027,\n\u0027hla_swd\u0027, \u0027dapdirect_jtag\u0027 or \u0027dapdirect_swd\u0027.\nThis becomes cumbersome when we just want to change adapter and we\nget forced to modify the \u0027transport select\u0027 command too.\n\nThere is no reason for an adapter driver to support two of the\nsimilar transports. In fact \u0027dapdirect\u0027 one is a superset of the\n\u0027hla\u0027, and the native \u0027jtag\u0027 or \u0027swd\u0027 is a superset of the\n\u0027dapdirect\u0027 one.\nWhile the adapter could support more than one similar transports,\nits adapter driver should only support the most complete of these\nsimilar transports.\n\nModify the \u0027transport select\u0027 code to accept \u0027jtag\u0027 or \u0027swd\u0027 for\nthe \u0027dapdirect\u0027 and the \u0027hla\u0027 adapters too.\nIssue a deprecated message for the old \u0027dapdirect\u0027 and \u0027hla\u0027\ntransport names.\nIn command \u0027transport list\u0027, print only the transport names that\ncan be selected through \u0027transport select\u0027 skipping information\nabout \u0027dapdirect\u0027 and \u0027hla\u0027 versions and avoid duplicated entries.\n\nThis improvement was listed in the TODO file. Update it!\n\nChange-Id: I626b50e7a94c141c042eab388cd1ffe77eb864c2\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"8096ba40a6d390bdcd234795e30032cb8a107939":{"kind":"REWORK","_number":3,"created":"2025-01-05 15:19:54.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/77/8677/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/77/8677/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/77/8677/3 \u0026\u0026 git checkout -b change-8677 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/77/8677/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/77/8677/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/77/8677/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/77/8677/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/77/8677/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2756d3f7ca45d56e6d7c8f86e502b6f277251b00","subject":"transport: store the transports sorted by alphabetic name order"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-12-23 16:44:47.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-01-05 15:07:38.000000000","tz":60},"subject":"transport: allow transport name jtag/swd for hla and dapdirect","message":"transport: allow transport name jtag/swd for hla and dapdirect\n\nThe transport used on adapter\u0027s wires is either \u0027jtag\u0027 or \u0027swd\u0027\nbut, depending on the adapter, in the command \u0027transport select\u0027\nwe have to use either \u0027jtag\u0027 or \u0027swd\u0027 or the similar \u0027hla_jtag\u0027,\n\u0027hla_swd\u0027, \u0027dapdirect_jtag\u0027 or \u0027dapdirect_swd\u0027.\nThis becomes cumbersome when we just want to change adapter and we\nget forced to modify the \u0027transport select\u0027 command too.\n\nThere is no reason for an adapter driver to support two of the\nsimilar transports. In fact \u0027dapdirect\u0027 one is a superset of the\n\u0027hla\u0027, and the native \u0027jtag\u0027 or \u0027swd\u0027 is a superset of the\n\u0027dapdirect\u0027 one.\nWhile the adapter could support more than one similar transports,\nits adapter driver should only support the most complete of these\nsimilar transports.\n\nModify the \u0027transport select\u0027 code to accept \u0027jtag\u0027 or \u0027swd\u0027 for\nthe \u0027dapdirect\u0027 and the \u0027hla\u0027 adapters too.\nIssue a deprecated message for the old \u0027dapdirect\u0027 and \u0027hla\u0027\ntransport names.\nIn command \u0027transport list\u0027, print only the transport names that\ncan be selected through \u0027transport select\u0027 skipping information\nabout \u0027dapdirect\u0027 and \u0027hla\u0027 versions and avoid duplicated entries.\n\nThis improvement was listed in the TODO file. Update it!\n\nChange-Id: I626b50e7a94c141c042eab388cd1ffe77eb864c2\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"5dfcc878fbc5bb7424acf8d22b95ac70b064b029":{"kind":"REWORK","_number":2,"created":"2024-12-31 16:26:45.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/77/8677/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/77/8677/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/77/8677/2 \u0026\u0026 git checkout -b change-8677 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/77/8677/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/77/8677/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/77/8677/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/77/8677/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/77/8677/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"98fed3e3483a4e6b74c0af36e6b7de5f117d6385","subject":"transport: store the transports sorted by alphabetic name order"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-12-23 16:44:47.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-12-31 16:24:38.000000000","tz":60},"subject":"transport: allow transport name jtag/swd for hla and dapdirect","message":"transport: allow transport name jtag/swd for hla and dapdirect\n\nThe transport used on adapter\u0027s wires is either \u0027jtag\u0027 or \u0027swd\u0027\nbut, depending on the adapter, in the command \u0027transport select\u0027\nwe have to use either \u0027jtag\u0027 or \u0027swd\u0027 or the similar \u0027hla_jtag\u0027,\n\u0027hla_swd\u0027, \u0027dapdirect_jtag\u0027 or \u0027dapdirect_swd\u0027.\nThis becomes cumbersome when we just want to change adapter and we\nget forced to modify the \u0027transport select\u0027 command too.\n\nThere is no reason for an adapter driver to support two of the\nsimilar transports. In fact \u0027dapdirect\u0027 one is a superset of the\n\u0027hla\u0027, and the native \u0027jtag\u0027 or \u0027swd\u0027 is a superset of the\n\u0027dapdirect\u0027 one.\nWhile the adapter could support more than one similar transports,\nits adapter driver should only support the most complete of these\nsimilar transports.\n\nModify the \u0027transport select\u0027 code to accept \u0027jtag\u0027 or \u0027swd\u0027 for\nthe \u0027dapdirect\u0027 and the \u0027hla\u0027 adapters too.\nIssue a deprecated message for the old \u0027dapdirect\u0027 and \u0027hla\u0027\ntransport names.\nIn command \u0027transport list\u0027, print only the transport names that\ncan be selected through \u0027transport select\u0027 skipping information\nabout \u0027dapdirect\u0027 and \u0027hla\u0027 versions and avoid duplicated entries.\n\nThis improvement was listed in the TODO file. Update it!\n\nChange-Id: I626b50e7a94c141c042eab388cd1ffe77eb864c2\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"a512086784a18e060a09333468c00aea6beb0e2d":{"kind":"REWORK","_number":1,"created":"2024-12-26 16:59:22.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/77/8677/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/77/8677/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/77/8677/1 \u0026\u0026 git checkout -b change-8677 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/77/8677/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/77/8677/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/77/8677/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/77/8677/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/77/8677/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8037b5388742ee97ac42de59550aa1fc36ebc4d6","subject":"transport: validate the list of transport from the driver"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-12-23 16:44:47.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-12-26 16:39:39.000000000","tz":60},"subject":"transport: allow transport name jtag/swd for hla and dapdirect","message":"transport: allow transport name jtag/swd for hla and dapdirect\n\nThe transport used on adapter\u0027s wires is either \u0027jtag\u0027 or \u0027swd\u0027\nbut, depending on the adapter, in the command \u0027transport select\u0027\nwe have to use either \u0027jtag\u0027 or \u0027swd\u0027 or the similar \u0027hla_jtag\u0027,\n\u0027hla_swd\u0027, \u0027dapdirect_jtag\u0027 or \u0027dapdirect_swd\u0027.\nThis becomes cumbersome when we just want to change adapter and we\nget forced to modify the \u0027transport select\u0027 command too.\n\nThere is no reason for an adapter driver to support two of the\nsimilar transports. In fact \u0027dapdirect\u0027 one is a superset of the\n\u0027hla\u0027, and the native \u0027jtag\u0027 or \u0027swd\u0027 is a superset of the\n\u0027dapdirect\u0027 one.\nWhile the adapter could support more than one similar transports,\nits adapter diver should only support the most complete transport.\n\nModify the \u0027transport select\u0027 code to accept \u0027jtag\u0027 or \u0027swd\u0027 for\nthe \u0027dapdirect\u0027 and the \u0027hla\u0027 adapters too.\nIssue a deprecated message for the old \u0027dapdirect\u0027 and \u0027hla\u0027\ntransport names.\nIn command \u0027transport list\u0027, add a side information to inform user\nabout \u0027dapdirect\u0027 and \u0027hla\u0027 versions.\n\nThis improvement was listed in the TODO file. Update it!\n\nChange-Id: I626b50e7a94c141c042eab388cd1ffe77eb864c2\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}