)]}'
{"id":"openocd~master~Ic653edec77425a58251d64f56c9f5f6c645ba0cd","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2025-01-12 11:09:31.000000000","reason":"Change was submitted"},"1002357":{"account":{"_account_id":1002357,"name":"Andy","display_name":"Digimap2000","email":"andrewjohnshelley@gmail.com","username":"digimap2000"},"last_update":"2025-01-05 20:49:09.000000000","reason":"\u003cGERRIT_ACCOUNT_1002357\u003e replied on the change","reason_account":{"_account_id":1002357,"name":"Andy","display_name":"Digimap2000","email":"andrewjohnshelley@gmail.com","username":"digimap2000"}}},"hashtags":[],"change_id":"Ic653edec77425a58251d64f56c9f5f6c645ba0cd","subject":"helper: list: rename macro clashing with sys/queue.h","status":"MERGED","created":"2024-12-31 13:54:39.000000000","updated":"2025-01-12 11:09:31.000000000","submitted":"2025-01-12 11:09:31.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8683","meta_rev_id":"095996a3e23b3eba99aa4ad674a7ddc59eb0343c","_number":8683,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1002357,"name":"Andy","display_name":"Digimap2000","email":"andrewjohnshelley@gmail.com","username":"digimap2000"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-01-12 11:09:31.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-01-12 11:09:31.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-01-12 11:09:31.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1002357,"name":"Andy","display_name":"Digimap2000","email":"andrewjohnshelley@gmail.com","username":"digimap2000"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-01-12 11:09:31.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1002357,"name":"Andy","display_name":"Digimap2000","email":"andrewjohnshelley@gmail.com","username":"digimap2000"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-12-31 13:55:45.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-12-31 20:50:20.000000000","updated_by":{"_account_id":1002357,"name":"Andy","display_name":"Digimap2000","email":"andrewjohnshelley@gmail.com","username":"digimap2000"},"reviewer":{"_account_id":1002357,"name":"Andy","display_name":"Digimap2000","email":"andrewjohnshelley@gmail.com","username":"digimap2000"},"state":"REVIEWER"},{"updated":"2025-01-07 04:13:01.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"a060d7fbd46399b5768a36694d80f9789e88be1a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-12-31 13:54:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fee74a835ab6387727112fdf704eb57e8b71e684","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-12-31 13:55:45.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/20457/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19609/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"6d4402a0e817a35856dccde4170e19306f5d642e","author":{"_account_id":1002357,"name":"Andy","display_name":"Digimap2000","email":"andrewjohnshelley@gmail.com","username":"digimap2000"},"real_author":{"_account_id":1002357,"name":"Andy","display_name":"Digimap2000","email":"andrewjohnshelley@gmail.com","username":"digimap2000"},"date":"2024-12-31 20:50:20.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"9c71d7a7e2ba06c7a1fd10c377c998e4a8c4ce30","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-01-05 15:54:29.000000000","message":"Patch Set 2: Commit message was updated.\n\nOutdated Votes:\n* Code-Review+1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"9ddc4d9511cff6ad89892df9a8b3861611262f0b","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-01-05 18:32:13.000000000","message":"Patch Set 2: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/20494/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19646/ : FAILURE","accounts_in_message":[],"_revision_number":2},{"id":"550847542459972cdd42aa3ee6fe864bcc99cf9b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-01-05 19:33:18.000000000","message":"Patch Set 3: Commit message was updated.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"5a793330b2e9451aa7a44d5a0ba01b6ff4d98cec","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-01-05 19:55:45.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20496/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19648/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"3c44093678ad11fbcea4ffb987474da756a8b9ea","author":{"_account_id":1002357,"name":"Andy","display_name":"Digimap2000","email":"andrewjohnshelley@gmail.com","username":"digimap2000"},"real_author":{"_account_id":1002357,"name":"Andy","display_name":"Digimap2000","email":"andrewjohnshelley@gmail.com","username":"digimap2000"},"date":"2025-01-05 20:49:09.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"c43fc6f4f8edb933a2b63ffc9be9c9e665c09826","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-01-05 21:07:14.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"89144f79f65f19754b91cb783ff015118324c612","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-01-07 04:13:01.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"095996a3e23b3eba99aa4ad674a7ddc59eb0343c","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-01-12 11:09:31.000000000","message":"Change has been successfully cherry-picked as 26f2df80c3f9ac54fc488ed26f6320904881c0d4","accounts_in_message":[],"_revision_number":4}],"current_revision":"26f2df80c3f9ac54fc488ed26f6320904881c0d4","revisions":{"26f2df80c3f9ac54fc488ed26f6320904881c0d4":{"kind":"REWORK","_number":4,"created":"2025-01-12 11:09:31.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/83/8683/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/83/8683/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/83/8683/4 \u0026\u0026 git checkout -b change-8683 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/83/8683/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/83/8683/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/83/8683/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/83/8683/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/83/8683/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0ed03df6e95bc336bbece000ffbe4028f70369d8","subject":"amend angie build definitions to fix make dist"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-12-31 13:47:02.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-01-12 11:09:31.000000000","tz":0},"subject":"helper: list: rename macro clashing with sys/queue.h","message":"helper: list: rename macro clashing with sys/queue.h\n\nThe macro named LIST_HEAD() clashed with a macro of same name in\nthe GNU libc file sys/queue.h.\nThis causes a warning in MacOS build due to some other system file\nincluding sys/queue.h.\n\nRename LIST_HEAD() as OOCD_LIST_HEAD().\n\nCheckpatch-ignore: MACRO_ARG_REUSE\nChange-Id: Ic653edec77425a58251d64f56c9f5f6c645ba0cd\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReported-by: Andrew Shelley \u003cashelley@btinternet.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8683\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-by: Andy \u003candrewjohnshelley@gmail.com\u003e\n"}},"efcdef2397ed1788de0366796938b9952476c7bf":{"kind":"REWORK","_number":1,"created":"2024-12-31 13:54:39.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/83/8683/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/83/8683/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/83/8683/1 \u0026\u0026 git checkout -b change-8683 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/83/8683/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/83/8683/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/83/8683/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/83/8683/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/83/8683/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4f2744d0fede64504ae4e9f9913eebc55c915d9a","subject":"target/arc: Use LOG_TARGET_xxx()"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-12-31 13:47:02.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-12-31 13:54:00.000000000","tz":60},"subject":"helper: list: rename macro clashing with sys/queue.h","message":"helper: list: rename macro clashing with sys/queue.h\n\nThe macro named LIST_HEAD() clashed with a macro of same name in\nthe GNU libc file sys/queue.h.\nThis causes a warning in MacOS build due to some other system file\nincluding sys/queue.h.\n\nRename LIST_HEAD() as OOCD_LIST_HEAD().\n\nChange-Id: Ic653edec77425a58251d64f56c9f5f6c645ba0cd\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReported-by: Andrew Shelley \u003cashelley@btinternet.com\u003e\n"}},"1edb128adf4453dd31205caf3f2072a4750db4f8":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2025-01-05 19:33:18.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/83/8683/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/83/8683/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/83/8683/3 \u0026\u0026 git checkout -b change-8683 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/83/8683/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/83/8683/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/83/8683/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/83/8683/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/83/8683/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4f2744d0fede64504ae4e9f9913eebc55c915d9a","subject":"target/arc: Use LOG_TARGET_xxx()"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-12-31 13:47:02.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-01-05 19:32:47.000000000","tz":0},"subject":"helper: list: rename macro clashing with sys/queue.h","message":"helper: list: rename macro clashing with sys/queue.h\n\nThe macro named LIST_HEAD() clashed with a macro of same name in\nthe GNU libc file sys/queue.h.\nThis causes a warning in MacOS build due to some other system file\nincluding sys/queue.h.\n\nRename LIST_HEAD() as OOCD_LIST_HEAD().\n\nCheckpatch-ignore: MACRO_ARG_REUSE\nChange-Id: Ic653edec77425a58251d64f56c9f5f6c645ba0cd\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReported-by: Andrew Shelley \u003cashelley@btinternet.com\u003e\n"},"description":"Edit commit message"},"0a9708721dc7badd6e2e1093b29dbbfa9db95f7c":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2025-01-05 15:54:29.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/83/8683/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/83/8683/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/83/8683/2 \u0026\u0026 git checkout -b change-8683 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/83/8683/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/83/8683/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/83/8683/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/83/8683/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/83/8683/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4f2744d0fede64504ae4e9f9913eebc55c915d9a","subject":"target/arc: Use LOG_TARGET_xxx()"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-12-31 13:47:02.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-01-05 15:54:29.000000000","tz":0},"subject":"helper: list: rename macro clashing with sys/queue.h","message":"helper: list: rename macro clashing with sys/queue.h\n\nThe macro named LIST_HEAD() clashed with a macro of same name in\nthe GNU libc file sys/queue.h.\nThis causes a warning in MacOS build due to some other system file\nincluding sys/queue.h.\n\nRename LIST_HEAD() as OOCD_LIST_HEAD().\n\nChange-Id: Ic653edec77425a58251d64f56c9f5f6c645ba0cd\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReported-by: Andrew Shelley \u003cashelley@btinternet.com\u003e\nCheckpatch-ignore: MACRO_ARG_REUSE\n"},"description":"Edit commit message"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}