)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"993ffb3efbfd76d0deaac128129c23ef6d0ccf1b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"50b18629_718d6c2c","updated":"2025-01-14 16:56:01.000000000","message":"I have checked the changes visually and it looks all right. \n\nI would only recommend to slightly reword the messages for improved clarity.","commit_id":"0b1dacab007ee1732cf2182d2cb15730736b8ba4"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"de248a829a63da8d9efb76ef316409cc6ee434ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"16d944c6_9320a8ff","in_reply_to":"50b18629_718d6c2c","updated":"2025-02-12 15:43:30.000000000","message":"Thanks for the review.\nAgree, the messages are not very informative. I will change both with:\n`DEPRECATED: auto-selecting transport \"%s\". Use \u0027transport select %s\u0027 to suppress this message.`","commit_id":"0b1dacab007ee1732cf2182d2cb15730736b8ba4"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"c0fa350f47557a54470e08aa0f1216be9e541754","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1b029092_a1447b73","updated":"2025-03-25 16:37:14.000000000","message":"I have checked this change only visually and it looks all right. Thanks.","commit_id":"65e35ab407eca6d419640e918cbcb6537f35f00a"}],"src/transport/transport.c":[{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"993ffb3efbfd76d0deaac128129c23ef6d0ccf1b","unresolved":true,"context_lines":[{"line_number":189,"context_line":"\t}"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"\tif (transport_single_is_autoselected)"},{"line_number":192,"context_line":"\t\tLOG_WARNING(\"DEPRECATED: auto-selecting adapter preferred session transport \\\"%s\\\". \""},{"line_number":193,"context_line":"\t\t\t\"Use \u0027transport select \u003ctransport\u003e\u0027.\","},{"line_number":194,"context_line":"\t\t\tsession-\u003ename);"},{"line_number":195,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"3253b10d_067064e3","line":192,"updated":"2025-01-14 16:56:01.000000000","message":"If you like, the message could be adjusted for improved clarity:\n\n```\nDEPRECATED: auto-selecting \"%s\" because it is the only supported transport of adapter \"%s\". Use \u0027transport select \u003ctransport\u003e\u0027 to suppress this warning.\n```\n\n- Say it is the only supported transport (not \"preferred\").\n- Perhaps no need to say \"session transport\". Saying just \"transport\" sounds enough.\n- It can be helpful for the user to mention what the adapter is.","commit_id":"0b1dacab007ee1732cf2182d2cb15730736b8ba4"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"de248a829a63da8d9efb76ef316409cc6ee434ee","unresolved":false,"context_lines":[{"line_number":189,"context_line":"\t}"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"\tif (transport_single_is_autoselected)"},{"line_number":192,"context_line":"\t\tLOG_WARNING(\"DEPRECATED: auto-selecting adapter preferred session transport \\\"%s\\\". \""},{"line_number":193,"context_line":"\t\t\t\"Use \u0027transport select \u003ctransport\u003e\u0027.\","},{"line_number":194,"context_line":"\t\t\tsession-\u003ename);"},{"line_number":195,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"e9c42870_14601330","line":192,"in_reply_to":"3253b10d_067064e3","updated":"2025-02-12 15:43:30.000000000","message":"Ack","commit_id":"0b1dacab007ee1732cf2182d2cb15730736b8ba4"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"993ffb3efbfd76d0deaac128129c23ef6d0ccf1b","unresolved":true,"context_lines":[{"line_number":228,"context_line":"\t\t\t\treturn ERROR_FAIL;"},{"line_number":229,"context_line":"\t\t\t}"},{"line_number":230,"context_line":"\t\t\tLOG_WARNING(\"DEPRECATED: auto-selecting first available session transport \\\"%s\\\". \""},{"line_number":231,"context_line":"\t\t\t\t\"Use \u0027transport select \u003ctransport\u003e\u0027.\", allowed_transports[0]);"},{"line_number":232,"context_line":"\t\t\tint retval \u003d transport_select(CMD_CTX, allowed_transports[0]);"},{"line_number":233,"context_line":"\t\t\tif (retval !\u003d ERROR_OK)"},{"line_number":234,"context_line":"\t\t\t\treturn retval;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"a21db561_9859a018","line":231,"updated":"2025-01-14 16:56:01.000000000","message":"This message could also be adjusted:\n\n```\nDEPRECATED: auto-selecting \\\"%s\\\" transport for \\\"%s\\\" adapter that supports multiple transports. Use \u0027transport select \u003ctransport\u003e\u0027 to suppress this warning. \n```\n\n- I am not sure it makes sense to say \"first\" transport. Which transport is first or subsequent is not very visible to an ordinary user.\n- Minor reword.","commit_id":"0b1dacab007ee1732cf2182d2cb15730736b8ba4"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"de248a829a63da8d9efb76ef316409cc6ee434ee","unresolved":false,"context_lines":[{"line_number":228,"context_line":"\t\t\t\treturn ERROR_FAIL;"},{"line_number":229,"context_line":"\t\t\t}"},{"line_number":230,"context_line":"\t\t\tLOG_WARNING(\"DEPRECATED: auto-selecting first available session transport \\\"%s\\\". \""},{"line_number":231,"context_line":"\t\t\t\t\"Use \u0027transport select \u003ctransport\u003e\u0027.\", allowed_transports[0]);"},{"line_number":232,"context_line":"\t\t\tint retval \u003d transport_select(CMD_CTX, allowed_transports[0]);"},{"line_number":233,"context_line":"\t\t\tif (retval !\u003d ERROR_OK)"},{"line_number":234,"context_line":"\t\t\t\treturn retval;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"05c7db2a_8df4382b","line":231,"in_reply_to":"a21db561_9859a018","updated":"2025-02-12 15:43:30.000000000","message":"Ack","commit_id":"0b1dacab007ee1732cf2182d2cb15730736b8ba4"}]}