)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"673e247dd16b796ccd5b730750eb0de66fc617de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"03d6d60c_2c4ef642","updated":"2025-02-12 12:00:02.000000000","message":"Antonio, can you elaborate a bit what kind of \"rework\" do you plan for the transport framework?","commit_id":"8de62d17b2aa3bc20d7fab55b8cb961a1384dd3d"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"8ccba0544ea52c881dac7744ec02e6bdbd7ae809","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c7af539e_583d3d70","in_reply_to":"03d6d60c_2c4ef642","updated":"2025-02-12 12:06:24.000000000","message":"(I\u0027m aware of your transport framework patches). To be more precise, what *else* do you plan and what is the benefit to introduce more C commands rather than outsource some logic to Tcl as it is at the moment?","commit_id":"8de62d17b2aa3bc20d7fab55b8cb961a1384dd3d"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"db974cb2ec5dfed3c420ea2b4a55329a8064c837","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"98c28a58_d2bb1926","in_reply_to":"1e2c14f0_acc307c1","updated":"2025-02-16 10:37:17.000000000","message":"I see, at the moment my (personal) agenda is to have a basic set of functionality in C and everything else in Tcl (if possible). Maybe we should align (project wide) where we draw the line between C and Tcl. Especially for a simple string comparison I would tend to do this in Tcl and have a basic command that return the current transport name in C. What do you think?","commit_id":"8de62d17b2aa3bc20d7fab55b8cb961a1384dd3d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9bff8ae1153843ab40a9b4e3c047e755c87e3efd","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"979837b2_7e455966","in_reply_to":"98c28a58_d2bb1926","updated":"2025-03-16 14:21:11.000000000","message":"I think the only general rules is that C is checked at compile time and we have few other static checkers for C. Complex stuff should be done in C.\nAlso, I often notice lack of deep knowledge of TCL syntax/commands by OpenOCD users. Simple scripts are fine, let\u0027s avoid complex ones.\n\nBack on this patch, I would like to reduce the delta between native/hla/dapdirect and \"hide\" it as an internal information. Drop completely the extra output from `transport select` will make the current helpers (based on string comparison).\nBut this patch could eventually delayed and be part of the future work.\n\nLet\u0027s move this patch as last in the series, so can easily be delayed/abandoned.","commit_id":"8de62d17b2aa3bc20d7fab55b8cb961a1384dd3d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"af8bd1a3eb9f8e9f83c80bbd9009210902a1a250","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1e2c14f0_acc307c1","in_reply_to":"c7af539e_583d3d70","updated":"2025-02-12 12:57:05.000000000","message":"I don\u0027t plan additional rework, so far.\nToday we have these TCL helpers `using_jtag`, `using_hla` and `using swd` that are based on the command `transport select`.\nThis series will partially hide the distinction between jtag, hla_jtag and dapdirect_jtag in the scripts and makes `transport select` return `jtag` followed eventually by `(hla)` or `(dapdirect)`.\nWhat I mean for `To simplify the rework in the transport framework` is to avoid parsing the output of `transport select` to use it in the TCL helpers; it\u0027s cleaner to have these helpers implemented directly in C.","commit_id":"8de62d17b2aa3bc20d7fab55b8cb961a1384dd3d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3030b6beda07ce3e5e7ee4ad9ea5a8ee87f352de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9c8a2306_5ed9248d","updated":"2025-03-16 14:50:41.000000000","message":"add -1, as per comments with Marc","commit_id":"7a599e3c1fa605fccbd10b9460a6e8fbaba60a37"}]}