)]}'
{"id":"openocd~master~I4a15a286f1e4198832606f86671ec7691f8c1abc","project":"openocd","branch":"master","hashtags":[],"change_id":"I4a15a286f1e4198832606f86671ec7691f8c1abc","subject":"ctype functions: pass int type in input","status":"NEW","created":"2025-01-06 16:47:01.000000000","updated":"2025-01-06 17:02:40.000000000","submit_type":"CHERRY_PICK","mergeable":false,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"1fa029b9c0dc9e69333d1df6f84a6c8411d76bfc","_number":8694,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:jenkins-gerrit-trigger","value":1,"date":"2025-01-06 17:02:40.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-01-06 17:02:40.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"2d11d56580df2456d2e623f38f523cc378fa3ec3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-01-06 16:47:01.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1fa029b9c0dc9e69333d1df6f84a6c8411d76bfc","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-01-06 17:02:40.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20498/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19650/ : SUCCESS","accounts_in_message":[],"_revision_number":1}],"current_revision":"4b0cff00043b1d07b3525633ace3be3cb45ddbc6","revisions":{"4b0cff00043b1d07b3525633ace3be3cb45ddbc6":{"kind":"REWORK","_number":1,"created":"2025-01-06 16:47:01.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/94/8694/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/94/8694/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/94/8694/1 \u0026\u0026 git checkout -b change-8694 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/94/8694/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/94/8694/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/94/8694/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/94/8694/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/94/8694/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"250ab1008b4d5f9520066df28170c42fc8b40af4","subject":"flash/stm32l4x: add STM32C071xx support"}],"author":{"name":"John Lupien","email":"jlupien@draper.com","date":"2025-01-06 16:35:06.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-01-06 16:44:50.000000000","tz":60},"subject":"ctype functions: pass int type in input","message":"ctype functions: pass int type in input\n\nAll the functions in ctype.h like tolower() or isalnum() require\ntheir input parameter of type \u0027int\u0027.\nThe OpenOCD code is not always compliant with this requirement,\ncausing build warnings.\n\nCast the input parameter to \u0027int\u0027, eventually passing through the\ntype \u0027unsigned char\u0027 when needed.\n\nChange-Id: I4a15a286f1e4198832606f86671ec7691f8c1abc\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nSigned-off-by: John Lupien \u003cjlupien@draper.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"NEED"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}}]}