)]}'
{"id":"openocd~master~I9eb2dc4f926671c5bb44e61453d92880e3036848","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2025-02-16 16:22:58.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I9eb2dc4f926671c5bb44e61453d92880e3036848","subject":"jtag: drop useless typedef tap_state_t","status":"MERGED","created":"2025-01-10 16:28:29.000000000","updated":"2025-02-16 16:23:03.000000000","submitted":"2025-02-16 16:23:03.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8709","meta_rev_id":"552959a732ac8446c3ff4612979e217435e3e60b","_number":8709,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-02-16 16:23:03.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-02-16 16:23:03.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-02-16 16:23:03.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-01-10 19:18:47.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-01-25 16:22:42.000000000","updated_by":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"reviewer":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"state":"REVIEWER"}],"messages":[{"id":"6c11ef478f304e2c8e99aede2d014190ac26dd73","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-01-10 16:28:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"463326ed316f1a8a7de87e837b775e7bc79063fa","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-01-10 19:18:47.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20535/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19686/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"97cdd4829673fb51290959d343820c70b4aa4e61","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-01-11 15:38:00.000000000","message":"Patch Set 1:\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20557/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19709/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"cc5ae2f6518f0a36c04f0f39d9550baec7205db2","author":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2025-01-25 16:22:42.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"c85f3d043f6c9b60fcff4a3d6c49cd7fa05904b6","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-02-16 16:22:58.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"552959a732ac8446c3ff4612979e217435e3e60b","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-02-16 16:23:03.000000000","message":"Change has been successfully cherry-picked as 4895a556fa6bafce14237b7e4c821d18fc55df02","accounts_in_message":[],"_revision_number":2}],"current_revision":"4895a556fa6bafce14237b7e4c821d18fc55df02","revisions":{"4895a556fa6bafce14237b7e4c821d18fc55df02":{"kind":"REWORK","_number":2,"created":"2025-02-16 16:23:03.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/09/8709/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/09/8709/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/09/8709/2 \u0026\u0026 git checkout -b change-8709 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/09/8709/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/09/8709/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/09/8709/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/09/8709/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/09/8709/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0d1932520b535270d1b454d1aad28819d359e6a5","subject":"jtag: openjtag: drop useless typedef openjtag_tap_state_t"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-01-10 16:05:29.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-02-16 16:23:03.000000000","tz":0},"subject":"jtag: drop useless typedef tap_state_t","message":"jtag: drop useless typedef tap_state_t\n\nNo need to use a typedef for an enum.\nDrop it.\n\nChange-Id: I9eb2dc4f926671c5bb44e61453d92880e3036848\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8709\nTested-by: jenkins\nReviewed-by: zapb \u003cdev@zapb.de\u003e\n"}},"cf882635497f7dab88bffefa9c92898d3ccb4b88":{"kind":"REWORK","_number":1,"created":"2025-01-10 16:28:29.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/09/8709/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/09/8709/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/09/8709/1 \u0026\u0026 git checkout -b change-8709 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/09/8709/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/09/8709/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/09/8709/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/09/8709/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/09/8709/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a87418662e6eeba9c2e395a3b261373ad658f787","subject":"jtag: openjtag: drop useless typedef openjtag_tap_state_t"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-01-10 16:05:29.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-01-10 16:19:35.000000000","tz":60},"subject":"jtag: drop useless typedef tap_state_t","message":"jtag: drop useless typedef tap_state_t\n\nNo need to use a typedef for an enum.\nDrop it.\n\nChange-Id: I9eb2dc4f926671c5bb44e61453d92880e3036848\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}
