)]}'
{"id":"openocd~master~I644a753e97de877d892af3a0219716f022fb1c59","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2025-02-16 16:23:18.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I644a753e97de877d892af3a0219716f022fb1c59","subject":"checkpatch: enable check for new typedefs","status":"MERGED","created":"2025-01-10 16:28:29.000000000","updated":"2025-02-16 16:23:22.000000000","submitted":"2025-02-16 16:23:22.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8710","meta_rev_id":"512d2bf079bc5c08f92d170ea7d791043f44f286","_number":8710,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-02-16 16:23:22.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-02-16 16:23:22.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-02-16 16:23:22.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-01-10 19:52:47.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-01-25 16:24:32.000000000","updated_by":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"reviewer":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"state":"REVIEWER"}],"messages":[{"id":"a2aade7cd9c6c164b39f27793e8d1362a0075f2f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-01-10 16:28:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"71ac331ef9254b3c3310045b5200f22ded6d23ad","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-01-10 19:52:47.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20536/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19689/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"236f2219c22bafec57ec3fa0b672b7f9c414e2be","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-01-11 15:03:17.000000000","message":"Patch Set 1:\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20558/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19707/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"8eac5e4a3c2f90073c679abf3827790834ccb76d","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2025-01-25 16:24:32.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"3e517aa875a63ab141dd0f13f766417bb8a5e6ff","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-02-16 16:23:18.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"512d2bf079bc5c08f92d170ea7d791043f44f286","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-02-16 16:23:22.000000000","message":"Change has been successfully cherry-picked as 9ccd6265dd56c75cc8d58359d33bf6d65a7524ab","accounts_in_message":[],"_revision_number":2}],"current_revision":"9ccd6265dd56c75cc8d58359d33bf6d65a7524ab","revisions":{"9ccd6265dd56c75cc8d58359d33bf6d65a7524ab":{"kind":"REWORK","_number":2,"created":"2025-02-16 16:23:22.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/10/8710/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/10/8710/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/10/8710/2 \u0026\u0026 git checkout -b change-8710 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/10/8710/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/10/8710/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/10/8710/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/10/8710/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/10/8710/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4895a556fa6bafce14237b7e4c821d18fc55df02","subject":"jtag: drop useless typedef tap_state_t"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-01-10 16:11:24.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-02-16 16:23:22.000000000","tz":0},"subject":"checkpatch: enable check for new typedefs","message":"checkpatch: enable check for new typedefs\n\nWe should strictly check for every new typedef.\nLet checkpatch detect them and let developer use\n\tCheckpatch-ignore: NEW_TYPEDEFS\nif it\u0027s really needed to add a new typedef.\nWith this change chackpatch will not complain for typedef on\nfunction\u0027s type but only on enum, struct, variable\u0027s type.\n\nChange-Id: I644a753e97de877d892af3a0219716f022fb1c59\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8710\nReviewed-by: zapb \u003cdev@zapb.de\u003e\nTested-by: jenkins\n"}},"154bb75c37ee4683dca04a12a32900ba67e50992":{"kind":"REWORK","_number":1,"created":"2025-01-10 16:28:29.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/10/8710/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/10/8710/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/10/8710/1 \u0026\u0026 git checkout -b change-8710 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/10/8710/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/10/8710/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/10/8710/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/10/8710/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/10/8710/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cf882635497f7dab88bffefa9c92898d3ccb4b88","subject":"jtag: drop useless typedef tap_state_t"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-01-10 16:11:24.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-01-10 16:19:35.000000000","tz":60},"subject":"checkpatch: enable check for new typedefs","message":"checkpatch: enable check for new typedefs\n\nWe should strictly check for every new typedef.\nLet checkpatch detect them and let developer use\n\tCheckpatch-ignore: NEW_TYPEDEFS\nif it\u0027s really needed to add a new typedef.\nWith this change chackpatch will not complain for typedef on\nfunction\u0027s type but only on enum, struct, variable\u0027s type.\n\nChange-Id: I644a753e97de877d892af3a0219716f022fb1c59\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}