)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"4e9860d65e8b0af4891d041edd004f7cc454ccf5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"f4bf0d3c_140c2e6e","updated":"2025-08-02 16:13:36.000000000","message":"Minor fix required about switch/case\nI think that by pushing this patch again, you will push again also\nhttps://review.openocd.org/c/openocd/+/8712\nwhere I just fixed again the typo in the commit message.\nPushing again, please take care of the typo","commit_id":"335c8f83308bbe654922133d60506d9d9b67f443"}],"contrib/firmware/angie/c/src/usb.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"dd27d2ba83c8b313c0a7ce508d5933f9fec26d01","unresolved":true,"context_lines":[{"line_number":594,"context_line":"}"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"/* Initialize GPIF interface transfer count */"},{"line_number":597,"context_line":"void set_gpif_cnt(uint32_t count)"},{"line_number":598,"context_line":"{"},{"line_number":599,"context_line":"\tGPIFTCB3 \u003d (uint8_t)(((uint32_t)(count) \u003e\u003e 24) \u0026 0x000000ff);"},{"line_number":600,"context_line":"\tsyncdelay(3);"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"ebeb882b_7e59498e","line":597,"updated":"2025-06-07 20:08:25.000000000","message":"this function plus the macros and the variables after it are not changes, just moved.\nIf you put them back in the previous position in this file, the review would be much easier.\nAlso the next function `usb_handle_vcommands()` should return in the place of former `usb_handle_send_bitstream()`. This function is changed, but again the delta can be minimized to simplify the review","commit_id":"291e3e37f7b6e3745e3a39af0370d5e33b771458"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"2f038872f8edf71375e4805739129895ddc0c0be","unresolved":true,"context_lines":[{"line_number":594,"context_line":"}"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"/* Initialize GPIF interface transfer count */"},{"line_number":597,"context_line":"void set_gpif_cnt(uint32_t count)"},{"line_number":598,"context_line":"{"},{"line_number":599,"context_line":"\tGPIFTCB3 \u003d (uint8_t)(((uint32_t)(count) \u003e\u003e 24) \u0026 0x000000ff);"},{"line_number":600,"context_line":"\tsyncdelay(3);"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"dd4f4f00_c1c0b6b7","line":597,"in_reply_to":"a064d5f8_a808e28f","updated":"2025-06-16 15:12:07.000000000","message":"Done","commit_id":"291e3e37f7b6e3745e3a39af0370d5e33b771458"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0849ed16266bb227ce3499538e4bdecee4454df7","unresolved":false,"context_lines":[{"line_number":594,"context_line":"}"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"/* Initialize GPIF interface transfer count */"},{"line_number":597,"context_line":"void set_gpif_cnt(uint32_t count)"},{"line_number":598,"context_line":"{"},{"line_number":599,"context_line":"\tGPIFTCB3 \u003d (uint8_t)(((uint32_t)(count) \u003e\u003e 24) \u0026 0x000000ff);"},{"line_number":600,"context_line":"\tsyncdelay(3);"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"6fa2b6d8_bcd14b49","line":597,"in_reply_to":"dd4f4f00_c1c0b6b7","updated":"2025-08-09 19:32:09.000000000","message":"Done","commit_id":"291e3e37f7b6e3745e3a39af0370d5e33b771458"},{"author":{"_account_id":1002344,"name":"Adrien Charruel","email":"acharruel@nanoxplore.com","username":"acharruel","status":"NanoXplore"},"change_message_id":"9a01c3ad1f1ff492341269046792351fd07e1cfc","unresolved":true,"context_lines":[{"line_number":594,"context_line":"}"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"/* Initialize GPIF interface transfer count */"},{"line_number":597,"context_line":"void set_gpif_cnt(uint32_t count)"},{"line_number":598,"context_line":"{"},{"line_number":599,"context_line":"\tGPIFTCB3 \u003d (uint8_t)(((uint32_t)(count) \u003e\u003e 24) \u0026 0x000000ff);"},{"line_number":600,"context_line":"\tsyncdelay(3);"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"a064d5f8_a808e28f","line":597,"in_reply_to":"ebeb882b_7e59498e","updated":"2025-06-11 10:02:22.000000000","message":"Agreed.\nI\u0027ll check with my coworker to properly fix this.","commit_id":"291e3e37f7b6e3745e3a39af0370d5e33b771458"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"dd27d2ba83c8b313c0a7ce508d5933f9fec26d01","unresolved":true,"context_lines":[{"line_number":804,"context_line":"/**"},{"line_number":805,"context_line":" * Handle the initialization of endpoints."},{"line_number":806,"context_line":" */"},{"line_number":807,"context_line":"void ep_init(void)"},{"line_number":808,"context_line":"{"},{"line_number":809,"context_line":"\tEP1INCFG \u003d 0x00;  /* non VALID */"},{"line_number":810,"context_line":"\tsyncdelay(3);"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"df3c5303_13fa0b93","line":807,"updated":"2025-06-07 20:08:25.000000000","message":"this function is not modified, it has only be moved in the file\nCan you please put it back in the original position to reduce the delata and the review time?","commit_id":"291e3e37f7b6e3745e3a39af0370d5e33b771458"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0849ed16266bb227ce3499538e4bdecee4454df7","unresolved":false,"context_lines":[{"line_number":804,"context_line":"/**"},{"line_number":805,"context_line":" * Handle the initialization of endpoints."},{"line_number":806,"context_line":" */"},{"line_number":807,"context_line":"void ep_init(void)"},{"line_number":808,"context_line":"{"},{"line_number":809,"context_line":"\tEP1INCFG \u003d 0x00;  /* non VALID */"},{"line_number":810,"context_line":"\tsyncdelay(3);"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"8727e41b_117285f7","line":807,"in_reply_to":"57b3fc84_2452ece1","updated":"2025-08-09 19:32:09.000000000","message":"Done","commit_id":"291e3e37f7b6e3745e3a39af0370d5e33b771458"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"2f038872f8edf71375e4805739129895ddc0c0be","unresolved":true,"context_lines":[{"line_number":804,"context_line":"/**"},{"line_number":805,"context_line":" * Handle the initialization of endpoints."},{"line_number":806,"context_line":" */"},{"line_number":807,"context_line":"void ep_init(void)"},{"line_number":808,"context_line":"{"},{"line_number":809,"context_line":"\tEP1INCFG \u003d 0x00;  /* non VALID */"},{"line_number":810,"context_line":"\tsyncdelay(3);"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"57b3fc84_2452ece1","line":807,"in_reply_to":"df3c5303_13fa0b93","updated":"2025-06-16 15:12:07.000000000","message":"Done","commit_id":"291e3e37f7b6e3745e3a39af0370d5e33b771458"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"4e9860d65e8b0af4891d041edd004f7cc454ccf5","unresolved":true,"context_lines":[{"line_number":564,"context_line":"\t}"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"\tswitch (setup_data.brequest) {"},{"line_number":567,"context_line":"\t\tcase VR_CFGOPEN:"},{"line_number":568,"context_line":"\t\t\t/* Clear bytecount / to allow new data in / to stops NAKing */"},{"line_number":569,"context_line":"\t\t\tEP0BCH \u003d 0;"},{"line_number":570,"context_line":"\t\t\tEP0BCL \u003d 0;"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"b1ec56fa_2918645f","line":567,"updated":"2025-08-02 16:13:36.000000000","message":"Please align switch and case","commit_id":"335c8f83308bbe654922133d60506d9d9b67f443"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0849ed16266bb227ce3499538e4bdecee4454df7","unresolved":false,"context_lines":[{"line_number":564,"context_line":"\t}"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"\tswitch (setup_data.brequest) {"},{"line_number":567,"context_line":"\t\tcase VR_CFGOPEN:"},{"line_number":568,"context_line":"\t\t\t/* Clear bytecount / to allow new data in / to stops NAKing */"},{"line_number":569,"context_line":"\t\t\tEP0BCH \u003d 0;"},{"line_number":570,"context_line":"\t\t\tEP0BCL \u003d 0;"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"66dabeef_1ee44824","line":567,"in_reply_to":"248e2199_386ac553","updated":"2025-08-09 19:32:09.000000000","message":"Done","commit_id":"335c8f83308bbe654922133d60506d9d9b67f443"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"a4405fe1949739383f9a2ff57e9152a6d55b89ba","unresolved":true,"context_lines":[{"line_number":564,"context_line":"\t}"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"\tswitch (setup_data.brequest) {"},{"line_number":567,"context_line":"\t\tcase VR_CFGOPEN:"},{"line_number":568,"context_line":"\t\t\t/* Clear bytecount / to allow new data in / to stops NAKing */"},{"line_number":569,"context_line":"\t\t\tEP0BCH \u003d 0;"},{"line_number":570,"context_line":"\t\t\tEP0BCL \u003d 0;"}],"source_content_type":"text/x-csrc","patch_set":9,"id":"248e2199_386ac553","line":567,"in_reply_to":"b1ec56fa_2918645f","updated":"2025-08-04 13:04:40.000000000","message":"Done","commit_id":"335c8f83308bbe654922133d60506d9d9b67f443"}]}