)]}'
{"id":"openocd~master~I7e05f83c6905cfaf66b68e8988c783e80cee4a48","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002143":{"account":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"last_update":"2025-01-25 10:33:23.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I7e05f83c6905cfaf66b68e8988c783e80cee4a48","subject":"vdebug: Fix socket comparison warning on Windows","status":"MERGED","created":"2025-01-13 09:46:52.000000000","updated":"2025-01-25 10:33:23.000000000","submitted":"2025-01-25 10:33:23.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8717","meta_rev_id":"bfd65f0b556058fa10822b4854bc2c0f40f6cd6e","_number":8717,"owner":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"value":0,"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},{"value":0,"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-01-25 10:33:23.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-01-25 10:33:23.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-01-25 10:33:23.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-01-25 10:33:23.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-01-25 10:33:23.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"}],"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-01-13 10:00:50.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-01-13 13:02:46.000000000","updated_by":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"reviewer":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"state":"REVIEWER"},{"updated":"2025-01-13 18:00:07.000000000","updated_by":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"reviewer":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"state":"CC"},{"updated":"2025-01-13 18:00:07.000000000","updated_by":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"reviewer":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"state":"CC"},{"updated":"2025-01-14 10:49:36.000000000","updated_by":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"reviewer":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"state":"REVIEWER"},{"updated":"2025-01-18 17:21:02.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2025-01-18 18:14:15.000000000","updated_by":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"reviewer":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"state":"REVIEWER"}],"messages":[{"id":"e7c9a54a27324c7be1f9d786d3d5d61efbcea31d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"real_author":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"date":"2025-01-13 09:46:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"20f2621c9baf2a776c6e2b5cd9d2ddbe445cb05c","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-01-13 10:00:50.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20571/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19722/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"fb4d31cd40140db382fbde696749b56f2ec43bdc","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2025-01-13 13:02:46.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"31f05dbb1596f4121347d260c1fa2120543bf209","author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"real_author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"date":"2025-01-13 18:00:07.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"82cce4426be4a3b40cb279da468a41df7282d677","author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"real_author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"date":"2025-01-14 10:49:36.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"331f5e9df91cdbecd4cf1aeeed90f3b23c9b265b","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-01-18 17:21:02.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"2f74e5f15d7a5a5d8ed7a8985433a2d1d2f281b2","author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"real_author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"date":"2025-01-18 18:14:15.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"cb1198bf3014ab441c9c4dcbac370c4bdca54ff9","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-01-25 10:33:18.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"bfd65f0b556058fa10822b4854bc2c0f40f6cd6e","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-01-25 10:33:23.000000000","message":"Change has been successfully cherry-picked as 0b97973bfbb980f987ec8e0e8d8ad32c85e9e5b0","accounts_in_message":[],"_revision_number":2}],"current_revision":"0b97973bfbb980f987ec8e0e8d8ad32c85e9e5b0","revisions":{"f0346a7f9f39b3d4e5a05291a5fa4d930c9604bb":{"kind":"REWORK","_number":1,"created":"2025-01-13 09:46:52.000000000","uploader":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"ref":"refs/changes/17/8717/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/17/8717/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/17/8717/1 \u0026\u0026 git checkout -b change-8717 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/17/8717/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/17/8717/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/17/8717/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/17/8717/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/17/8717/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"26f2df80c3f9ac54fc488ed26f6320904881c0d4","subject":"helper: list: rename macro clashing with sys/queue.h"}],"author":{"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","date":"2025-01-13 09:28:15.000000000","tz":60},"committer":{"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","date":"2025-01-13 09:29:25.000000000","tz":60},"subject":"vdebug: Fix socket comparison warning on Windows","message":"vdebug: Fix socket comparison warning on Windows\n\nOn GCC version 13.2,\nthe previous code emitted the following warning on Windows:\n\nopenocd/src/jtag/drivers/vdebug.c:254:19: warning: comparison of integer expressions of different signedness: \u0027int\u0027 and \u0027long long unsigned int\u0027 [-Wsign-compare]\n  254 |         if (hsock \u003d\u003d INVALID_SOCKET)\n\nThis patch fixes it and brings it in line with other socket handling code.\n\nChange-Id: I7e05f83c6905cfaf66b68e8988c783e80cee4a48\nSigned-off-by: Marek Vrbka \u003cmarek.vrbka@codasip.com\u003e\n"}},"0b97973bfbb980f987ec8e0e8d8ad32c85e9e5b0":{"kind":"REWORK","_number":2,"created":"2025-01-25 10:33:23.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/17/8717/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/17/8717/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/17/8717/2 \u0026\u0026 git checkout -b change-8717 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/17/8717/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/17/8717/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/17/8717/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/17/8717/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/17/8717/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"77f9da76264d4970faf22a40a31fc66fa7543b57","subject":"flash/nor/kinetis: fix assertion during flash write"}],"author":{"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","date":"2025-01-13 09:28:15.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-01-25 10:33:23.000000000","tz":0},"subject":"vdebug: Fix socket comparison warning on Windows","message":"vdebug: Fix socket comparison warning on Windows\n\nOn GCC version 13.2,\nthe previous code emitted the following warning on Windows:\n\nopenocd/src/jtag/drivers/vdebug.c:254:19: warning: comparison of integer expressions of different signedness: \u0027int\u0027 and \u0027long long unsigned int\u0027 [-Wsign-compare]\n  254 |         if (hsock \u003d\u003d INVALID_SOCKET)\n\nThis patch fixes it and brings it in line with other socket handling code.\n\nChange-Id: I7e05f83c6905cfaf66b68e8988c783e80cee4a48\nSigned-off-by: Marek Vrbka \u003cmarek.vrbka@codasip.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8717\nTested-by: jenkins\nReviewed-by: Jan Matyas \u003cjan.matyas@codasip.com\u003e\nReviewed-by: Jacek Wuwer \u003cjacekmw8@gmail.com\u003e\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-by: R. Diez \u003crdiez-2006@rd10.de\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}