)]}'
{"id":"openocd~master~I1ac176fdae449a34db0a0496b69a9ea65ccd6aec","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2025-01-20 13:04:11.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}},"1002047":{"account":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"last_update":"2025-01-25 10:33:56.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I1ac176fdae449a34db0a0496b69a9ea65ccd6aec","subject":"helper/options: drop redundant argument checks","status":"MERGED","created":"2025-01-17 15:48:48.000000000","updated":"2025-01-25 10:33:56.000000000","submitted":"2025-01-25 10:33:56.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8718","meta_rev_id":"85d6d5164512877d696fd28cb05b49af660c8679","_number":8718,"owner":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-01-25 10:33:56.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-01-25 10:33:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-01-17 15:51:43.000000000","updated_by":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2025-01-17 16:04:11.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"6846d6843f465af9e6f5dffb47d436d102045d4a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2025-01-17 15:48:48.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5aaec15affe8c8b571771bae20421e73f513ebff","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2025-01-17 15:51:43.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"82e79ab869db4e13600468be3192aec5bfd30b33","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-01-17 16:04:11.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/20583/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19734/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"3073f1338eddf0058e564604ee6f17b9684136b2","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-01-18 10:54:14.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"b381c68846ec66a78c1f4c8215c1117c287f9c5a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-01-18 10:54:33.000000000","message":"Patch Set 2: Commit message was updated.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"2c8c5169f2c356fdcb275af042afccb35789ed64","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-01-18 11:12:59.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20585/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19736/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"163a62ffc5d36ae454486fbb9d04fc62cc49364a","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-01-18 11:43:15.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"36eed288fbafedb97955b32e504a930670600f69","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2025-01-20 12:16:39.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"ddcc94cfe43bd6ede9044cdb3ebf75c0e04479f4","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2025-01-20 12:18:27.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"15fd63a41a53717b7db9032e81fcdeaa5d7ab735","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-01-20 12:31:34.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20589/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19740/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"2e827a0f7e306a9f9ef70c68dcd8de5023641c6d","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-01-20 13:04:11.000000000","message":"Patch Set 3: Code-Review+1\n\n(3 comments)","accounts_in_message":[],"_revision_number":3},{"id":"cbf8852cc21d937c8c36ab166d33771784c56055","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-01-25 10:33:51.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"85d6d5164512877d696fd28cb05b49af660c8679","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-01-25 10:33:56.000000000","message":"Change has been successfully cherry-picked as 778d2dc4bb982ffa00f5fbd343346555fcbf9113","accounts_in_message":[],"_revision_number":4}],"current_revision":"778d2dc4bb982ffa00f5fbd343346555fcbf9113","revisions":{"1ecb2df0de219e7b49d27af4c756a3f1132d6816":{"kind":"REWORK","_number":1,"created":"2025-01-17 15:48:48.000000000","uploader":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"ref":"refs/changes/18/8718/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/18/8718/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/18/8718/1 \u0026\u0026 git checkout -b change-8718 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/18/8718/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/18/8718/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/18/8718/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/18/8718/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/18/8718/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"133dd9d669e5b8beb7c7787b0be677621808e72d","subject":"target/xtensa: add maskisr command support for NX"}],"author":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2025-01-17 15:03:40.000000000","tz":180},"committer":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2025-01-17 15:46:51.000000000","tz":180},"subject":"helper/options: drop redundant argument checks","message":"helper/options: drop redundant argument checks\n\nIn case the option is passed with a single `:` in `optstring` argument,\nthe call to `getopt_long()` should return `?`.\n\nTherefore the check on `optarg` is redundand in case of `l` and `c`.\n\nChange-Id: I1ac176fdae449a34db0a0496b69a9ea65ccd6aec\nSigned-off-by: Evgeniy Naydanov \u003cevgeniy.naydanov@syntacore.com\u003e\nHelped-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"f47433fae0569d7e1d0229a4432ed5704ca94a9f":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2025-01-18 10:54:33.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/18/8718/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/18/8718/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/18/8718/2 \u0026\u0026 git checkout -b change-8718 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/18/8718/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/18/8718/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/18/8718/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/18/8718/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/18/8718/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"133dd9d669e5b8beb7c7787b0be677621808e72d","subject":"target/xtensa: add maskisr command support for NX"}],"author":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2025-01-17 15:03:40.000000000","tz":180},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-01-18 10:54:32.000000000","tz":0},"subject":"helper/options: drop redundant argument checks","message":"helper/options: drop redundant argument checks\n\nIn case the option is passed with a single `:` in `optstring` argument,\nthe call to `getopt_long()` should return `?`.\n\nTherefore the check on `optarg` is redundand in case of `l` and `c`.\n\nChange-Id: I1ac176fdae449a34db0a0496b69a9ea65ccd6aec\nSigned-off-by: Evgeniy Naydanov \u003cevgeniy.naydanov@syntacore.com\u003e\nReported-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"},"description":"Edit commit message"},"876e1beeec8d09be9aa568c9dfb58a56f7cc72cc":{"kind":"REWORK","_number":3,"created":"2025-01-20 12:16:39.000000000","uploader":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"ref":"refs/changes/18/8718/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/18/8718/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/18/8718/3 \u0026\u0026 git checkout -b change-8718 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/18/8718/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/18/8718/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/18/8718/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/18/8718/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/18/8718/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"133dd9d669e5b8beb7c7787b0be677621808e72d","subject":"target/xtensa: add maskisr command support for NX"}],"author":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2025-01-17 15:03:40.000000000","tz":180},"committer":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2025-01-20 12:15:55.000000000","tz":180},"subject":"helper/options: drop redundant argument checks","message":"helper/options: drop redundant argument checks\n\nIn case the option is passed with a single `:` in `optstring` argument,\nthe call to `getopt_long()` should return `?`.\n\nTherefore the check on `optarg` is redundand in case of `l` and `c`.\n\nChange-Id: I1ac176fdae449a34db0a0496b69a9ea65ccd6aec\nSigned-off-by: Evgeniy Naydanov \u003cevgeniy.naydanov@syntacore.com\u003e\nReported-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"778d2dc4bb982ffa00f5fbd343346555fcbf9113":{"kind":"REWORK","_number":4,"created":"2025-01-25 10:33:56.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/18/8718/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/18/8718/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/18/8718/4 \u0026\u0026 git checkout -b change-8718 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/18/8718/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/18/8718/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/18/8718/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/18/8718/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/18/8718/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0b97973bfbb980f987ec8e0e8d8ad32c85e9e5b0","subject":"vdebug: Fix socket comparison warning on Windows"}],"author":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2025-01-17 15:03:40.000000000","tz":180},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-01-25 10:33:56.000000000","tz":0},"subject":"helper/options: drop redundant argument checks","message":"helper/options: drop redundant argument checks\n\nIn case the option is passed with a single `:` in `optstring` argument,\nthe call to `getopt_long()` should return `?`.\n\nTherefore the check on `optarg` is redundand in case of `l` and `c`.\n\nChange-Id: I1ac176fdae449a34db0a0496b69a9ea65ccd6aec\nSigned-off-by: Evgeniy Naydanov \u003cevgeniy.naydanov@syntacore.com\u003e\nReported-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8718\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}