)]}'
{"id":"openocd~master~Ibe7e7ec6d0db4453b8a53c8256987621b809c99d","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2025-01-25 10:32:45.000000000","reason":"Change was submitted"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2025-01-22 13:52:31.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"Ibe7e7ec6d0db4453b8a53c8256987621b809c99d","subject":"flash/nor/kinetis: fix assertion during flash write","status":"MERGED","created":"2025-01-17 17:22:58.000000000","updated":"2025-01-25 10:32:45.000000000","submitted":"2025-01-25 10:32:45.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8719","meta_rev_id":"2323d3292ef4c1df0883fd78b7fcb3ab46016830","_number":8719,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1002363,"name":"Jasper v. B.","email":"jasper@mezzo.de","username":"jazzpi"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-01-25 10:32:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-01-25 10:32:45.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-01-25 10:32:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1002363,"name":"Jasper v. B.","email":"jasper@mezzo.de","username":"jazzpi"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-01-25 10:32:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1002363,"name":"Jasper v. B.","email":"jasper@mezzo.de","username":"jazzpi"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-01-17 17:37:32.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-01-18 10:49:35.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2025-01-22 13:43:19.000000000","updated_by":{"_account_id":1002363,"name":"Jasper v. B.","email":"jasper@mezzo.de","username":"jazzpi"},"reviewer":{"_account_id":1002363,"name":"Jasper v. B.","email":"jasper@mezzo.de","username":"jazzpi"},"state":"REVIEWER"}],"messages":[{"id":"ba9ff271877bbf5c76208bd03e93577358f04aa6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-01-17 17:22:58.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1f65430cb8609e5dcbb324b868e62357cee150d3","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-01-17 17:37:32.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20584/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19735/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"e2e50e536a37f3594cc7640e13914eaffd7864fa","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-01-18 10:49:35.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"034c8f6da5b1353e8edb9a1219d47cd30a61e8b7","author":{"_account_id":1002363,"name":"Jasper v. B.","email":"jasper@mezzo.de","username":"jazzpi"},"real_author":{"_account_id":1002363,"name":"Jasper v. B.","email":"jasper@mezzo.de","username":"jazzpi"},"date":"2025-01-22 13:43:19.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"073909f295d037d0795383b959e5b98485ecf1aa","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-01-22 13:52:31.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"2323d3292ef4c1df0883fd78b7fcb3ab46016830","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-01-25 10:32:45.000000000","message":"Change has been successfully cherry-picked as 77f9da76264d4970faf22a40a31fc66fa7543b57","accounts_in_message":[],"_revision_number":2}],"current_revision":"77f9da76264d4970faf22a40a31fc66fa7543b57","revisions":{"8865d6602c2df828a0a75764d7e30e9767d18a40":{"kind":"REWORK","_number":1,"created":"2025-01-17 17:22:58.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/19/8719/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/19/8719/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/19/8719/1 \u0026\u0026 git checkout -b change-8719 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/19/8719/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/19/8719/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/19/8719/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/19/8719/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/19/8719/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"26f2df80c3f9ac54fc488ed26f6320904881c0d4","subject":"helper: list: rename macro clashing with sys/queue.h"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-01-17 17:02:50.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-01-17 17:21:58.000000000","tz":60},"subject":"flash/nor/kinetis: fix assertion during flash write","message":"flash/nor/kinetis: fix assertion during flash write\n\nIf the device has at lest one FlexNVM bank and it is set as EE backup\nonly, the bank has no protection blocks.\n\nkinetis_fill_fcf() collects protection data from all banks before\nflash write of the sector containing FCF block. In case it encountered\na FlexNVM bank with no protection blocks assert failed.\n\nFailed flash write of previously erased FCF block could cause\nengaging debugging lock (if the device was run or reset).\n\nSkip banks with zero protection blocks.\nReplace assert() by LOG_ERROR() as we have to finish FCF write.\n\nChange-Id: Ibe7e7ec6d0db4453b8a53c8256987621b809c99d\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nSuggested-by: Jasper v. Blanckenburg \u003cjazzpi@users.sourceforge.net\u003e\nFixes: https://sourceforge.net/p/openocd/tickets/448/\n"}},"77f9da76264d4970faf22a40a31fc66fa7543b57":{"kind":"REWORK","_number":2,"created":"2025-01-25 10:32:45.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/19/8719/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/19/8719/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/19/8719/2 \u0026\u0026 git checkout -b change-8719 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/19/8719/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/19/8719/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/19/8719/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/19/8719/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/19/8719/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3099547069896ccff054d64bac6041fe1e20add9","subject":"OpenOCD: fix code indentation"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-01-17 17:02:50.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-01-25 10:32:45.000000000","tz":0},"subject":"flash/nor/kinetis: fix assertion during flash write","message":"flash/nor/kinetis: fix assertion during flash write\n\nIf the device has at lest one FlexNVM bank and it is set as EE backup\nonly, the bank has no protection blocks.\n\nkinetis_fill_fcf() collects protection data from all banks before\nflash write of the sector containing FCF block. In case it encountered\na FlexNVM bank with no protection blocks assert failed.\n\nFailed flash write of previously erased FCF block could cause\nengaging debugging lock (if the device was run or reset).\n\nSkip banks with zero protection blocks.\nReplace assert() by LOG_ERROR() as we have to finish FCF write.\n\nChange-Id: Ibe7e7ec6d0db4453b8a53c8256987621b809c99d\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nSuggested-by: Jasper v. Blanckenburg \u003cjazzpi@users.sourceforge.net\u003e\nFixes: https://sourceforge.net/p/openocd/tickets/448/\nReviewed-on: https://review.openocd.org/c/openocd/+/8719\nTested-by: jenkins\nReviewed-by: Jasper v. Blanckenburg \u003cjasper@mezzo.de\u003e\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}