)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1002365,"name":"Daniel DeGrasse","email":"ddegrasse@tenstorrent.com","username":"danieldegrasse"},"change_message_id":"c8c979871d60338b8acbd4fe69fe52da1c272ec5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a9845254_10945658","updated":"2025-01-23 20:30:10.000000000","message":"Just a note- this is required as part of the RTT support for ARC in this change: https://review.openocd.org/c/openocd/+/8720","commit_id":"9a5dfb1ffc41fb38390cfe1439bd0fece98b9d0d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"35fbc47b5c218b02879a880b763ae09e2e813849","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6f802c04_98fe6aee","updated":"2025-01-25 11:17:54.000000000","message":"Thanks for the patch.\nI don\u0027t have any knowledge on arc architecture.\nAdded Evgeniy as reviewer to confirm this is ok for all the possible variants of arc.","commit_id":"1b92d5f69e3b19ad08a9f8ab92b69e630b494b89"},{"author":{"_account_id":1002365,"name":"Daniel DeGrasse","email":"ddegrasse@tenstorrent.com","username":"danieldegrasse"},"change_message_id":"dfb85baec1a3eda133f42e3039ac0024f88d9dc8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cbd488ea_3b68eac7","in_reply_to":"6f802c04_98fe6aee","updated":"2025-01-27 15:21:17.000000000","message":"Great, thank you- I\u0027d appreciate a confirmation as well. I\u0027ve confirmed this is ok on a core based on the ARC Hs4x, but I don\u0027t have access to other ARC cores to test","commit_id":"1b92d5f69e3b19ad08a9f8ab92b69e630b494b89"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0a8e9184b22575ad9b15cff46fcaf89739f5eb05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5794a89b_7eeef133","in_reply_to":"cbd488ea_3b68eac7","updated":"2025-02-16 16:26:33.000000000","message":"Ack-ed by Evgeniy","commit_id":"1b92d5f69e3b19ad08a9f8ab92b69e630b494b89"},{"author":{"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},"change_message_id":"0fb01e4fea0cd05c3ac45945a2f795c0f2a2930f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"51119d1e_1578a8a8","updated":"2025-02-07 13:49:01.000000000","message":"Hi Daniel, \n\nSorry for delayed reply. I don\u0027t expect any issues reading the memory while running. So, approve. Thank you!","commit_id":"c8d7cbb803ef01d6af850386e0e190f5e8ca0120"}],"src/target/arc_mem.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"35fbc47b5c218b02879a880b763ae09e2e813849","unresolved":true,"context_lines":[{"line_number":162,"context_line":"\t\taddress, size, count);"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"\tif (target-\u003estate !\u003d TARGET_HALTED) {"},{"line_number":165,"context_line":"\t\tLOG_TARGET_DEBUG(target, \"target not halted\");"},{"line_number":166,"context_line":"\t}"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"\t/* sanitize arguments */"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"ce51cf09_341d14b1","line":165,"updated":"2025-01-25 11:17:54.000000000","message":"If the read/write are possible on running target, then drop the test here and below in the read","commit_id":"1b92d5f69e3b19ad08a9f8ab92b69e630b494b89"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0a8e9184b22575ad9b15cff46fcaf89739f5eb05","unresolved":false,"context_lines":[{"line_number":162,"context_line":"\t\taddress, size, count);"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"\tif (target-\u003estate !\u003d TARGET_HALTED) {"},{"line_number":165,"context_line":"\t\tLOG_TARGET_DEBUG(target, \"target not halted\");"},{"line_number":166,"context_line":"\t}"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"\t/* sanitize arguments */"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"a2003720_4f435311","line":165,"in_reply_to":"c034e11f_f275c4c6","updated":"2025-02-16 16:26:33.000000000","message":"Done","commit_id":"1b92d5f69e3b19ad08a9f8ab92b69e630b494b89"},{"author":{"_account_id":1002365,"name":"Daniel DeGrasse","email":"ddegrasse@tenstorrent.com","username":"danieldegrasse"},"change_message_id":"dfb85baec1a3eda133f42e3039ac0024f88d9dc8","unresolved":true,"context_lines":[{"line_number":162,"context_line":"\t\taddress, size, count);"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"\tif (target-\u003estate !\u003d TARGET_HALTED) {"},{"line_number":165,"context_line":"\t\tLOG_TARGET_DEBUG(target, \"target not halted\");"},{"line_number":166,"context_line":"\t}"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"\t/* sanitize arguments */"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"c034e11f_f275c4c6","line":165,"in_reply_to":"ce51cf09_341d14b1","updated":"2025-01-27 15:21:17.000000000","message":"Done, thanks","commit_id":"1b92d5f69e3b19ad08a9f8ab92b69e630b494b89"}]}
