)]}'
{"id":"openocd~master~I2accfb4b99bf77c5473d133623e0eb0632cb45f6","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2025-02-16 16:26:33.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}},"1001674":{"account":{"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},"last_update":"2025-02-07 13:49:01.000000000","reason":"\u003cGERRIT_ACCOUNT_1001674\u003e replied on the change","reason_account":{"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"}},"1002365":{"account":{"_account_id":1002365,"name":"Daniel DeGrasse","email":"ddegrasse@tenstorrent.com","username":"danieldegrasse"},"last_update":"2025-02-16 16:26:42.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I2accfb4b99bf77c5473d133623e0eb0632cb45f6","subject":"target/arc: allow reading memory while target runs","status":"MERGED","created":"2025-01-23 20:24:48.000000000","updated":"2025-02-16 16:26:42.000000000","submitted":"2025-02-16 16:26:42.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8721","meta_rev_id":"cf62e18d5fa11ca55cf42b3d284689f555dcfa0e","_number":8721,"owner":{"_account_id":1002365,"name":"Daniel DeGrasse","email":"ddegrasse@tenstorrent.com","username":"danieldegrasse"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-02-16 16:26:42.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-02-16 16:26:42.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-02-16 16:26:42.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-01-23 20:42:47.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-01-25 11:17:54.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2025-01-25 11:17:54.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},"state":"REVIEWER"},{"updated":"2025-02-16 16:26:33.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"deac9f92bd236d8c7c9a12db791a2f5873c607e7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002365,"name":"Daniel DeGrasse","email":"ddegrasse@tenstorrent.com","username":"danieldegrasse"},"real_author":{"_account_id":1002365,"name":"Daniel DeGrasse","email":"ddegrasse@tenstorrent.com","username":"danieldegrasse"},"date":"2025-01-23 20:24:48.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c8c979871d60338b8acbd4fe69fe52da1c272ec5","author":{"_account_id":1002365,"name":"Daniel DeGrasse","email":"ddegrasse@tenstorrent.com","username":"danieldegrasse"},"real_author":{"_account_id":1002365,"name":"Daniel DeGrasse","email":"ddegrasse@tenstorrent.com","username":"danieldegrasse"},"date":"2025-01-23 20:30:10.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"42cc63e58d2d5e21194164fc0812bb6329b39704","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-01-23 20:42:47.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/20618/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19769/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"d8573ef792f306033fcfad80e8d2fe1ec33fc723","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002365,"name":"Daniel DeGrasse","email":"ddegrasse@tenstorrent.com","username":"danieldegrasse"},"real_author":{"_account_id":1002365,"name":"Daniel DeGrasse","email":"ddegrasse@tenstorrent.com","username":"danieldegrasse"},"date":"2025-01-23 20:47:17.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"8f48341cd6426890b8260b90d4c0b106711c9fe3","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-01-23 21:05:27.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20619/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19770/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"35fbc47b5c218b02879a880b763ae09e2e813849","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-01-25 11:17:54.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"0d380bb63324ae31ce477db0cd4addac98440c57","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002365,"name":"Daniel DeGrasse","email":"ddegrasse@tenstorrent.com","username":"danieldegrasse"},"real_author":{"_account_id":1002365,"name":"Daniel DeGrasse","email":"ddegrasse@tenstorrent.com","username":"danieldegrasse"},"date":"2025-01-27 15:14:23.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"dfb85baec1a3eda133f42e3039ac0024f88d9dc8","author":{"_account_id":1002365,"name":"Daniel DeGrasse","email":"ddegrasse@tenstorrent.com","username":"danieldegrasse"},"real_author":{"_account_id":1002365,"name":"Daniel DeGrasse","email":"ddegrasse@tenstorrent.com","username":"danieldegrasse"},"date":"2025-01-27 15:21:17.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"25e4019ad79e8d490e74bd4d1e57d160b36e2ca4","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-01-27 15:30:14.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20655/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19805/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"0fb01e4fea0cd05c3ac45945a2f795c0f2a2930f","author":{"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},"real_author":{"_account_id":1001674,"name":"Evgeniy Didin","email":"didin@synopsys.com","username":"EvgeniiDidin"},"date":"2025-02-07 13:49:01.000000000","message":"Patch Set 3: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"0a8e9184b22575ad9b15cff46fcaf89739f5eb05","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-02-16 16:26:33.000000000","message":"Patch Set 3: Code-Review+2\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"cf62e18d5fa11ca55cf42b3d284689f555dcfa0e","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-02-16 16:26:42.000000000","message":"Change has been successfully cherry-picked as 44e782d55bf1ce0d924c082281082496cdc2495e","accounts_in_message":[],"_revision_number":4}],"current_revision":"44e782d55bf1ce0d924c082281082496cdc2495e","revisions":{"c8d7cbb803ef01d6af850386e0e190f5e8ca0120":{"kind":"REWORK","_number":3,"created":"2025-01-27 15:14:23.000000000","uploader":{"_account_id":1002365,"name":"Daniel DeGrasse","email":"ddegrasse@tenstorrent.com","username":"danieldegrasse"},"ref":"refs/changes/21/8721/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/21/8721/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/21/8721/3 \u0026\u0026 git checkout -b change-8721 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/21/8721/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/21/8721/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/21/8721/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/21/8721/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/21/8721/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"af8ec8482c1db4e33948e3c625fd73b06038a4b5","subject":"target/arc: add RTT commands"}],"author":{"name":"Daniel DeGrasse","email":"ddegrasse@tenstorrent.com","date":"2025-01-17 03:33:48.000000000","tz":-300},"committer":{"name":"Daniel DeGrasse","email":"ddegrasse@tenstorrent.com","date":"2025-01-27 15:13:27.000000000","tz":-360},"subject":"target/arc: allow reading memory while target runs","message":"target/arc: allow reading memory while target runs\n\nThere is no reason that ARC can\u0027t support reading from memory over JTAG\nwhile the target is executing, and this is in fact required for RTT\nsupport. Remove this check from arc_mem_read and arc_mem_write\n\nChange-Id: I2accfb4b99bf77c5473d133623e0eb0632cb45f6\nSigned-off-by: Daniel DeGrasse \u003cddegrasse@tenstorrent.com\u003e\n"}},"1b92d5f69e3b19ad08a9f8ab92b69e630b494b89":{"kind":"REWORK","_number":2,"created":"2025-01-23 20:47:17.000000000","uploader":{"_account_id":1002365,"name":"Daniel DeGrasse","email":"ddegrasse@tenstorrent.com","username":"danieldegrasse"},"ref":"refs/changes/21/8721/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/21/8721/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/21/8721/2 \u0026\u0026 git checkout -b change-8721 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/21/8721/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/21/8721/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/21/8721/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/21/8721/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/21/8721/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"af8ec8482c1db4e33948e3c625fd73b06038a4b5","subject":"target/arc: add RTT commands"}],"author":{"name":"Daniel DeGrasse","email":"ddegrasse@tenstorrent.com","date":"2025-01-17 03:33:48.000000000","tz":-300},"committer":{"name":"Daniel DeGrasse","email":"ddegrasse@tenstorrent.com","date":"2025-01-23 20:47:09.000000000","tz":-360},"subject":"target/arc: allow reading memory while target runs","message":"target/arc: allow reading memory while target runs\n\nThere is no reason that ARC can\u0027t support reading from memory over JTAG\nwhile the target is executing, and this is in fact required for RTT\nsupport. Remove the error return when the target is running, and reduce\nthe log message to a debug print\n\nChange-Id: I2accfb4b99bf77c5473d133623e0eb0632cb45f6\nSigned-off-by: Daniel DeGrasse \u003cddegrasse@tenstorrent.com\u003e\n"}},"9a5dfb1ffc41fb38390cfe1439bd0fece98b9d0d":{"kind":"REWORK","_number":1,"created":"2025-01-23 20:24:48.000000000","uploader":{"_account_id":1002365,"name":"Daniel DeGrasse","email":"ddegrasse@tenstorrent.com","username":"danieldegrasse"},"ref":"refs/changes/21/8721/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/21/8721/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/21/8721/1 \u0026\u0026 git checkout -b change-8721 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/21/8721/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/21/8721/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/21/8721/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/21/8721/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/21/8721/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"af8ec8482c1db4e33948e3c625fd73b06038a4b5","subject":"target/arc: add RTT commands"}],"author":{"name":"Daniel DeGrasse","email":"ddegrasse@tenstorrent.com","date":"2025-01-17 03:33:48.000000000","tz":-300},"committer":{"name":"Daniel DeGrasse","email":"ddegrasse@tenstorrent.com","date":"2025-01-23 20:23:46.000000000","tz":-360},"subject":"target/arc: allow reading memory while target runs","message":"target/arc: allow reading memory while target runs\n\nThere is no reason that ARC can\u0027t support reading from memory over JTAG\nwhile the target is executing, and this is in fact required for RTT\nsupport. Remove the error return when the target is running, and reduce\nthe log message to a debug print\n\nChange-Id: I2accfb4b99bf77c5473d133623e0eb0632cb45f6\nSigned-off-by: Daniel DeGrasse \u003cddegrasse@tenstorrent.com\u003e\n"}},"44e782d55bf1ce0d924c082281082496cdc2495e":{"kind":"REWORK","_number":4,"created":"2025-02-16 16:26:42.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/21/8721/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/21/8721/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/21/8721/4 \u0026\u0026 git checkout -b change-8721 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/21/8721/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/21/8721/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/21/8721/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/21/8721/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/21/8721/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9bb0a4558bc84b8be63aa937d4b7b9283614f132","subject":"target/arc: add RTT commands"}],"author":{"name":"Daniel DeGrasse","email":"ddegrasse@tenstorrent.com","date":"2025-01-17 03:33:48.000000000","tz":-300},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-02-16 16:26:42.000000000","tz":0},"subject":"target/arc: allow reading memory while target runs","message":"target/arc: allow reading memory while target runs\n\nThere is no reason that ARC can\u0027t support reading from memory over JTAG\nwhile the target is executing, and this is in fact required for RTT\nsupport. Remove this check from arc_mem_read and arc_mem_write\n\nChange-Id: I2accfb4b99bf77c5473d133623e0eb0632cb45f6\nSigned-off-by: Daniel DeGrasse \u003cddegrasse@tenstorrent.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8721\nTested-by: jenkins\nReviewed-by: Evgeniy Didin \u003cdidin@synopsys.com\u003e\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}