)]}'
{"id":"openocd~master~Ibe5b1f23ccf3fbaa21c48b574a1b3f3e9f6fb916","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000438":{"account":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"last_update":"2025-02-16 16:29:00.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ibe5b1f23ccf3fbaa21c48b574a1b3f3e9f6fb916","subject":"Makefile.am: DISTCHECK_CONFIGURE_FLAGS -\u003e AM_DISTCHECK_CONFIGURE_FLAGS","status":"MERGED","created":"2025-01-25 22:07:30.000000000","updated":"2025-02-16 16:29:00.000000000","submitted":"2025-02-16 16:29:00.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8724","meta_rev_id":"92b56ead6e2c4d80ab98fcbd26d4943256bf3c4f","_number":8724,"owner":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-02-16 16:29:00.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-02-16 16:29:00.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-01-25 22:20:29.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-01-26 15:51:54.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"0816bde6dc4d3cd58d0fd555ec5a29b555b363da","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"real_author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"date":"2025-01-25 22:07:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e5ce1124954f549cd018b4bb5c4e2802a6eb5049","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-01-25 22:20:29.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20631/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19781/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"604ab80b26144162aecf6310ab26fc85a84f8aaa","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-01-26 15:51:54.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"92b56ead6e2c4d80ab98fcbd26d4943256bf3c4f","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-02-16 16:29:00.000000000","message":"Change has been successfully cherry-picked as dcf02f46ff8355eb3f889aaa9d660f73dacede4f","accounts_in_message":[],"_revision_number":2}],"current_revision":"dcf02f46ff8355eb3f889aaa9d660f73dacede4f","revisions":{"dcf02f46ff8355eb3f889aaa9d660f73dacede4f":{"kind":"REWORK","_number":2,"created":"2025-02-16 16:29:00.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/24/8724/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/24/8724/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/24/8724/2 \u0026\u0026 git checkout -b change-8724 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/24/8724/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/24/8724/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/24/8724/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/24/8724/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/24/8724/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5e4ad24ba610e81ee6e9358154ef176e15c36fe7","subject":"configure.ac: show vdebug in the config summary"}],"author":{"name":"R. Diez","email":"rdiezmail-openocd@yahoo.de","date":"2025-01-25 22:04:50.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-02-16 16:29:00.000000000","tz":0},"subject":"Makefile.am: DISTCHECK_CONFIGURE_FLAGS -\u003e AM_DISTCHECK_CONFIGURE_FLAGS","message":"Makefile.am: DISTCHECK_CONFIGURE_FLAGS -\u003e AM_DISTCHECK_CONFIGURE_FLAGS\n\nThe Automake manual states: \"The user can still extend or override\nthe flags provided there by defining the DISTCHECK_CONFIGURE_FLAGS\nvariable\". Overriding variable DISTCHECK_CONFIGURE_FLAGS in Makefile.am\nmakes it impossible for the user to do that. I discovered this\nwhen trying to pass --enable-internal-jimtcl to distcheck.\n\nChange-Id: Ibe5b1f23ccf3fbaa21c48b574a1b3f3e9f6fb916\nSigned-off-by: R. Diez \u003crdiezmail-openocd@yahoo.de\u003e\n\nReviewed-on: https://review.openocd.org/c/openocd/+/8724\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\n"}},"cb1bb92d9cea6dd7d6d16d762709637d1f15abd6":{"kind":"REWORK","_number":1,"created":"2025-01-25 22:07:30.000000000","uploader":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"ref":"refs/changes/24/8724/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/24/8724/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/24/8724/1 \u0026\u0026 git checkout -b change-8724 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/24/8724/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/24/8724/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/24/8724/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/24/8724/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/24/8724/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a510d51a78f14fbb8416037a587ce1bfc6016d24","subject":"bootstrap: Do not set up Git submodules by default"}],"author":{"name":"R. Diez","email":"rdiezmail-openocd@yahoo.de","date":"2025-01-25 22:04:50.000000000","tz":60},"committer":{"name":"R. Diez","email":"rdiezmail-openocd@yahoo.de","date":"2025-01-25 22:06:09.000000000","tz":60},"subject":"Makefile.am: DISTCHECK_CONFIGURE_FLAGS -\u003e AM_DISTCHECK_CONFIGURE_FLAGS","message":"Makefile.am: DISTCHECK_CONFIGURE_FLAGS -\u003e AM_DISTCHECK_CONFIGURE_FLAGS\n\nThe Automake manual states: \"The user can still extend or override\nthe flags provided there by defining the DISTCHECK_CONFIGURE_FLAGS\nvariable\". Overriding variable DISTCHECK_CONFIGURE_FLAGS in Makefile.am\nmakes it impossible for the user to do that. I discovered this\nwhen trying to pass --enable-internal-jimtcl to distcheck.\n\nChange-Id: Ibe5b1f23ccf3fbaa21c48b574a1b3f3e9f6fb916\nSigned-off-by: R. Diez \u003crdiezmail-openocd@yahoo.de\u003e\n\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}