)]}'
{"id":"openocd~master~Ib9c671b656998a91c0e7626beed185c9c156d32b","project":"openocd","branch":"master","attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2025-09-10 09:13:53.000000000","reason":"\u003cGERRIT_ACCOUNT_1000687\u003e replied on the change","reason_account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2026-01-14 10:29:06.000000000","reason":"\u003cGERRIT_ACCOUNT_1000853\u003e replied on the change","reason_account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"}}},"removed_from_attention_set":{"1000853":{"account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2026-01-14 10:29:06.000000000","reason":"\u003cGERRIT_ACCOUNT_1000853\u003e replied on the change","reason_account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"}}},"hashtags":[],"change_id":"Ib9c671b656998a91c0e7626beed185c9c156d32b","subject":"target/adi_v5_swd, drivers: allow error passing from SWD read/write reg","status":"NEW","created":"2025-01-28 10:42:22.000000000","updated":"2026-01-14 10:29:06.000000000","submit_type":"CHERRY_PICK","submittable":false,"total_comment_count":2,"unresolved_comment_count":1,"has_review_started":true,"meta_rev_id":"512516d3c0451f5b63f327aa2d17d1ad4321ae3c","_number":8728,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"tag":"autogenerated:jenkins-gerrit-trigger","value":1,"date":"2025-09-10 09:05:49.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-01-28 10:52:28.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-09-10 09:13:53.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"state":"REVIEWER"},{"updated":"2025-09-10 09:13:53.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"8ffd83ee077e6553bc71bbb3254efc88f6034c9a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-01-28 10:42:22.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a5227af21ce9c1d08a1ff52423d836399c33b87a","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-01-28 10:52:28.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/20658/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19808/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"63d1b622544e7efed7d124e9e3b484f1df275a02","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-01-28 11:13:57.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"ee52913a4127816d13d11348542d564324a8b60f","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-01-28 11:21:45.000000000","message":"Patch Set 2: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/20659/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19809/ : FAILURE","accounts_in_message":[],"_revision_number":2},{"id":"5e790ccc0393bde3422709103501aab9b45071b5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-01-28 11:27:33.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"37102d791ae84e187481c442c8950865d2269113","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-01-28 11:41:19.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20660/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19810/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"e60a76610f2d53c2d40bd8fc27d5f39312960c7b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-02-06 21:11:47.000000000","message":"Uploaded patch set 4.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":4},{"id":"b1229b3cb5ec9e41ad671c92d8d7831e1116e21d","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-02-06 22:00:45.000000000","message":"Patch Set 4: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20743/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19890/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"b7b8f6acb562b99b8aee0aec15868bbec6660d4a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-09-10 06:10:02.000000000","message":"Uploaded patch set 5.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":5},{"id":"a17216279188b1e847dd8b6dbde2921c46a67b6e","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-09-10 09:05:49.000000000","message":"Patch Set 5: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20890/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/21758/ : SUCCESS","accounts_in_message":[],"_revision_number":5},{"id":"4dbf57cf623324720d7bc638d29e24e12ac174fd","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2026-01-08 07:03:39.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"512516d3c0451f5b63f327aa2d17d1ad4321ae3c","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2026-01-14 10:29:06.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5}],"current_revision":"9af31c3b29ae36e7cf021b692767ea721999a1c0","revisions":{"df32a3ecc07a906bfecade6fe1f48f751dcc4360":{"kind":"REWORK","_number":3,"created":"2025-01-28 11:27:33.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/28/8728/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/28/8728/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/28/8728/3 \u0026\u0026 git checkout -b change-8728 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/28/8728/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/28/8728/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/28/8728/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/28/8728/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/28/8728/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a510d51a78f14fbb8416037a587ce1bfc6016d24","subject":"bootstrap: Do not set up Git submodules by default"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-01-28 10:01:31.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-01-28 11:27:24.000000000","tz":60},"subject":"target/adi_v5_swd, drivers: allow error passing from SWD read/write reg","message":"target/adi_v5_swd, drivers: allow error passing from SWD read/write reg\n\nSWD driver read/write reg operations were originally meant as pure\nqueuing and therefore do not return any error code.\n\nThe real SWD implementation in an adapter driver either executes\nSWD operation immediately (bitbang etc...) or eventually runs\nthe queue as soon as it\u0027s getting full.\n\nIn both cases the adapter driver code needs to pass an eventual error\nto the caller. The queuing of the return value complicates the code\nof the driver and is more error prone than standard error passing.\n\nGet rid of the queued retval concept partially.\nChange swd-\u003eread/write_reg() adapter driver methods to return error\ncode.\nCheck returned error code in ADI SWD layer and request reconnect\nas error recovery after an error.\nRemove queued retval from bitbang style adapter drivers.\n\nTo prevent oversizing the patch other adapter drivers return\nunconditional ERROR_OK from read/write_reg() for the moment.\nThis should be functionally identical to the previous code\nand the drivers could be retval-de-queued one by one.\n\nChange-Id: Ib9c671b656998a91c0e7626beed185c9c156d32b\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"0e7fa9d5be9f9c3fbc45f10083f13e4e74c5abf2":{"kind":"REWORK","_number":2,"created":"2025-01-28 11:13:57.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/28/8728/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/28/8728/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/28/8728/2 \u0026\u0026 git checkout -b change-8728 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/28/8728/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/28/8728/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/28/8728/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/28/8728/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/28/8728/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a510d51a78f14fbb8416037a587ce1bfc6016d24","subject":"bootstrap: Do not set up Git submodules by default"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-01-28 10:01:31.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-01-28 11:13:19.000000000","tz":60},"subject":"target/adi_v5_swd, drivers: allow error passing from SWD read/write reg","message":"target/adi_v5_swd, drivers: allow error passing from SWD read/write reg\n\nSWD driver read/write reg operations were originally meant as pure\nqueuing and therefore do not return any error code.\n\nThe real SWD implementation in an adapter driver either executes\nSWD operation immediately (bitbang etc...) or eventually runs\nthe queue as soon as it\u0027s getting full.\n\nIn both cases the adapter driver code needs to pass an eventual error\nto the caller. The queuing of the return value complicates the code\nof the driver and is more error prone than standard error passing.\n\nGet rid of the queued retval concept partially.\nChange swd-\u003eread/write_reg() adapter driver methods to return error\ncode.\nCheck returned error code in ADI SWD layer and request reconnect\nas error recovery after an error.\nRemove queued retval from bitbang style adapter drivers.\n\nTo prevent oversizing the patch other adapter drivers return\nunconditional ERROR_OK from read/write_reg() for the moment.\nThis should be functionally identical to the previous code\nand the drivers could be retval-de-queued one by one.\n\nChange-Id: Ib9c671b656998a91c0e7626beed185c9c156d32b\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"997c5cd878b505d5355b2b2f8879dc058e865e7b":{"kind":"REWORK","_number":1,"created":"2025-01-28 10:42:22.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/28/8728/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/28/8728/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/28/8728/1 \u0026\u0026 git checkout -b change-8728 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/28/8728/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/28/8728/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/28/8728/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/28/8728/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/28/8728/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a510d51a78f14fbb8416037a587ce1bfc6016d24","subject":"bootstrap: Do not set up Git submodules by default"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-01-28 10:01:31.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-01-28 10:34:00.000000000","tz":60},"subject":"target/adi_v5_swd, drivers: allow error passing from SWD read/write reg","message":"target/adi_v5_swd, drivers: allow error passing from SWD read/write reg\n\nSWD driver read/write reg operations were originally meant as pure\nqueuing and therefore do not return any error code.\n\nThe real SWD implementation in an adapter driver either executes\nSWD operation immediately (bitbang etc...) or eventually runs\nthe queue as soon as it\u0027s getting full.\n\nIn both cases the adapter driver code needs to pass an eventual error\nto the caller. The queuing of the return value complicates the code\nof the driver and is more error prone than standard error passing.\n\nGet rid of the queued retval concept partially.\nChange swd-\u003eread/write_reg() adapter driver methods to return error\ncode.\nCheck returned error code in ADI SWD layer and request reconnect\nas error recovery after an error.\nRemove queued retval from bitbang style adapter drivers.\n\nTo prevent oversizing the patch other adapter drivers return\nunconditional ERROR_OK from read/write_reg() for the moment.\nThis should be functionally identical to the previous code\nand the drivers could be retval-de-queued one by one.\n\nChange-Id: Ib9c671b656998a91c0e7626beed185c9c156d32b\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"9af31c3b29ae36e7cf021b692767ea721999a1c0":{"kind":"REWORK","_number":5,"created":"2025-09-10 06:10:02.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/28/8728/5","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/28/8728/5","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/28/8728/5 \u0026\u0026 git checkout -b change-8728 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/28/8728/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/28/8728/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/28/8728/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/28/8728/5","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/28/8728/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"fcff4b712c53a6169f0f96dd63f0adb1b12a1789","subject":"jtag/drivers/cmsis_dap: add new backend cmsis_dap_tcp"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-01-28 10:01:31.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-09-10 06:05:05.000000000","tz":120},"subject":"target/adi_v5_swd, drivers: allow error passing from SWD read/write reg","message":"target/adi_v5_swd, drivers: allow error passing from SWD read/write reg\n\nSWD driver read/write reg operations were originally meant as pure\nqueuing and therefore do not return any error code.\n\nThe real SWD implementation in an adapter driver either executes\nSWD operation immediately (bitbang etc...) or eventually runs\nthe queue as soon as it\u0027s getting full.\n\nIn both cases the adapter driver code needs to pass an eventual error\nto the caller. The queuing of the return value complicates the code\nof the driver and is more error prone than standard error passing.\n\nGet rid of the queued retval concept partially.\nChange swd-\u003eread/write_reg() adapter driver methods to return error\ncode.\nCheck returned error code in ADI SWD layer and request reconnect\nas error recovery after an error.\nRemove queued retval from bitbang style adapter drivers.\n\nTo prevent oversizing the patch other adapter drivers return\nunconditional ERROR_OK from read/write_reg() for the moment.\nThis should be functionally identical to the previous code\nand the drivers could be retval-de-queued one by one.\n\nChange-Id: Ib9c671b656998a91c0e7626beed185c9c156d32b\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"430d593d1e01af55fbfc2c291f52e32eec1253b4":{"kind":"REWORK","_number":4,"created":"2025-02-06 21:11:47.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/28/8728/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/28/8728/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/28/8728/4 \u0026\u0026 git checkout -b change-8728 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/28/8728/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/28/8728/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/28/8728/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/28/8728/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/28/8728/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"eb6f2745b7d9924d0dddeab91c1743867c4e812c","subject":"flash/nor: add DesignWare SPI controller driver"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-01-28 10:01:31.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-02-06 17:18:10.000000000","tz":60},"subject":"target/adi_v5_swd, drivers: allow error passing from SWD read/write reg","message":"target/adi_v5_swd, drivers: allow error passing from SWD read/write reg\n\nSWD driver read/write reg operations were originally meant as pure\nqueuing and therefore do not return any error code.\n\nThe real SWD implementation in an adapter driver either executes\nSWD operation immediately (bitbang etc...) or eventually runs\nthe queue as soon as it\u0027s getting full.\n\nIn both cases the adapter driver code needs to pass an eventual error\nto the caller. The queuing of the return value complicates the code\nof the driver and is more error prone than standard error passing.\n\nGet rid of the queued retval concept partially.\nChange swd-\u003eread/write_reg() adapter driver methods to return error\ncode.\nCheck returned error code in ADI SWD layer and request reconnect\nas error recovery after an error.\nRemove queued retval from bitbang style adapter drivers.\n\nTo prevent oversizing the patch other adapter drivers return\nunconditional ERROR_OK from read/write_reg() for the moment.\nThis should be functionally identical to the previous code\nand the drivers could be retval-de-queued one by one.\n\nChange-Id: Ib9c671b656998a91c0e7626beed185c9c156d32b\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"NEED"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}}]}