)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"32296e35f747b9fca765a581775f2b04492aeb58","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d2588ab7_70734730","line":16,"updated":"2025-01-30 11:29:26.000000000","message":"Please add a line here:\n```\nFixes: 83e0293f7ba3 (\"Add Linux SPI device SWD adapter support\")\n```","commit_id":"62e319baa148c11dd3499fc282df27887c5819f1"},{"author":{"_account_id":1002347,"name":"Richard Pasek","email":"rpasek@google.com","username":"rpasek"},"change_message_id":"2f54fe227a1a9b13201bfcbb846315cf2584b808","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"03c8ecd0_57c3e23c","line":16,"in_reply_to":"d2588ab7_70734730","updated":"2025-01-30 13:16:16.000000000","message":"Thanks. Fixed.","commit_id":"62e319baa148c11dd3499fc282df27887c5819f1"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1002347,"name":"Richard Pasek","email":"rpasek@google.com","username":"rpasek"},"change_message_id":"3f9c47b4ed83c99fe8c3d267f4a8d5f2462a9a67","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"45d52275_c04bea1b","updated":"2025-01-30 10:44:13.000000000","message":"I haven\u0027t tested this patch yet. I\u0027ve unhooked the setup at my desk and I\u0027m out of office till Monday. I will test it as soon as I get in.","commit_id":"62e319baa148c11dd3499fc282df27887c5819f1"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"32296e35f747b9fca765a581775f2b04492aeb58","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bfeddf91_d99cca5a","updated":"2025-01-30 11:29:26.000000000","message":"It could also be fixed by injecting zeroed bits, but I expect the memset in this patch should be faster that shifting bits.\nShould be ok.","commit_id":"62e319baa148c11dd3499fc282df27887c5819f1"},{"author":{"_account_id":1002347,"name":"Richard Pasek","email":"rpasek@google.com","username":"rpasek"},"change_message_id":"cb1376f3dcb383154f586980e2f31f2a38ddd1f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7ed025d4_2808d6e5","in_reply_to":"45d52275_c04bea1b","updated":"2025-02-04 21:02:06.000000000","message":"This is now tested as done in the commit message.","commit_id":"62e319baa148c11dd3499fc282df27887c5819f1"}],"src/jtag/drivers/linuxspidev.c":[{"author":{"_account_id":1002348,"name":"Jonathon Reinhart","email":"jrreinhart@google.com"},"change_message_id":"33f7a733f60f806b785f5fba88a3f45e8925235f","unresolved":true,"context_lines":[{"line_number":243,"context_line":"\tqueue_infos \u003d realloc(queue_infos, sizeof(struct queue_info) * new_queue_entries);"},{"line_number":244,"context_line":"\tif (!queue_infos)"},{"line_number":245,"context_line":"\t\tgoto realloc_fail;"},{"line_number":246,"context_line":"\tmemset(queue_infos, 0, sizeof(struct queue_info) * new_queue_entries);"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"\tqueue_tx_buf \u003d realloc(queue_tx_buf, new_queue_buf_size);"},{"line_number":249,"context_line":"\tif (!queue_tx_buf)"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"a1610609_4b22f069","line":246,"updated":"2025-01-30 14:01:04.000000000","message":"You might also consider adding a new function e.g. `spidev_clear_queue()`, then calling that here and in `spidev_swd_execute_queue()` (at `// Clear everything in the queue`).","commit_id":"3cea51c5fdadb9b65915114f1c8ec3b2bc19ccfa"},{"author":{"_account_id":1002347,"name":"Richard Pasek","email":"rpasek@google.com","username":"rpasek"},"change_message_id":"cb1376f3dcb383154f586980e2f31f2a38ddd1f3","unresolved":false,"context_lines":[{"line_number":243,"context_line":"\tqueue_infos \u003d realloc(queue_infos, sizeof(struct queue_info) * new_queue_entries);"},{"line_number":244,"context_line":"\tif (!queue_infos)"},{"line_number":245,"context_line":"\t\tgoto realloc_fail;"},{"line_number":246,"context_line":"\tmemset(queue_infos, 0, sizeof(struct queue_info) * new_queue_entries);"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"\tqueue_tx_buf \u003d realloc(queue_tx_buf, new_queue_buf_size);"},{"line_number":249,"context_line":"\tif (!queue_tx_buf)"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"6af5bd4f_fd8cc91a","line":246,"in_reply_to":"5e7044d1_1dec261c","updated":"2025-02-04 21:02:06.000000000","message":"Done","commit_id":"3cea51c5fdadb9b65915114f1c8ec3b2bc19ccfa"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"eba2de591d3476ad6e7ae6bf9a2a435812c2b695","unresolved":true,"context_lines":[{"line_number":243,"context_line":"\tqueue_infos \u003d realloc(queue_infos, sizeof(struct queue_info) * new_queue_entries);"},{"line_number":244,"context_line":"\tif (!queue_infos)"},{"line_number":245,"context_line":"\t\tgoto realloc_fail;"},{"line_number":246,"context_line":"\tmemset(queue_infos, 0, sizeof(struct queue_info) * new_queue_entries);"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"\tqueue_tx_buf \u003d realloc(queue_tx_buf, new_queue_buf_size);"},{"line_number":249,"context_line":"\tif (!queue_tx_buf)"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"5e7044d1_1dec261c","line":246,"in_reply_to":"a1610609_4b22f069","updated":"2025-02-03 19:46:34.000000000","message":"I like the suggested refactoring. Richard please...","commit_id":"3cea51c5fdadb9b65915114f1c8ec3b2bc19ccfa"}]}