)]}'
{"id":"openocd~master~I26f011ae59fc942a34d9bb517f467c22f735091d","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2025-02-11 11:56:39.000000000","reason":"Change was submitted"},"1002347":{"account":{"_account_id":1002347,"name":"Richard Pasek","email":"rpasek@google.com","username":"rpasek"},"last_update":"2025-02-06 18:24:01.000000000","reason":"\u003cGERRIT_ACCOUNT_1002347\u003e replied on the change","reason_account":{"_account_id":1002347,"name":"Richard Pasek","email":"rpasek@google.com","username":"rpasek"}},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2025-02-06 18:58:30.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I26f011ae59fc942a34d9bb517f467c22f735091d","subject":"drivers/linuxspidev: fix use of uninitialized speed variable","status":"MERGED","created":"2025-02-03 20:15:48.000000000","updated":"2025-02-11 11:56:39.000000000","submitted":"2025-02-11 11:56:39.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8733","meta_rev_id":"6cb239cced32d182cfd83a2196107b805c28f1bd","_number":8733,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1002347,"name":"Richard Pasek","email":"rpasek@google.com","username":"rpasek"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-02-11 11:56:39.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-02-11 11:56:39.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1002347,"name":"Richard Pasek","email":"rpasek@google.com","username":"rpasek"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-02-11 11:56:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1002347,"name":"Richard Pasek","email":"rpasek@google.com","username":"rpasek"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-02-03 20:47:57.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-02-03 20:56:20.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1002347,"name":"Richard Pasek","email":"rpasek@google.com","username":"rpasek"},"state":"REVIEWER"},{"updated":"2025-02-04 08:52:50.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"64a6b36d273068a39254aa435b5d32cfc0ea8b7a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-02-03 20:15:48.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"33d5c90f91f5401082ddcd07d285449dcb86eafd","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-02-03 20:47:57.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20695/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19844/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"3f7c433742e089a01bcbddd5b3fdd4a922c290ff","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-02-04 08:52:50.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"e735c78af5596908f3fe88f294cc3af664c4219e","author":{"_account_id":1002347,"name":"Richard Pasek","email":"rpasek@google.com","username":"rpasek"},"real_author":{"_account_id":1002347,"name":"Richard Pasek","email":"rpasek@google.com","username":"rpasek"},"date":"2025-02-04 21:03:26.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"2d7f59ba91227d7bfa3b6750d3204e588e091237","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-02-04 21:31:24.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"ed770b498568c23ca43a7c5915a0aa2c42376931","author":{"_account_id":1002347,"name":"Richard Pasek","email":"rpasek@google.com","username":"rpasek"},"real_author":{"_account_id":1002347,"name":"Richard Pasek","email":"rpasek@google.com","username":"rpasek"},"date":"2025-02-04 21:33:20.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"7f75da3e3a4d924a6dd6058bfe0ea3e1cff908aa","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-02-04 21:34:54.000000000","message":"Patch Set 2: Commit message was updated.\n\nOutdated Votes:\n* Code-Review+1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"c489d53aefca8a51dec6af5055f95753c0cbcf5f","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-02-04 21:35:47.000000000","message":"Patch Set 2: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/20718/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19864/ : FAILURE","accounts_in_message":[],"_revision_number":2},{"id":"fecc0cb598ec9e18a165b3c0d4d6caf46cabaac6","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-02-04 21:37:21.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"05c774fbe842affdf1d7f945510c92d6f6b6cee8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-02-04 21:38:37.000000000","message":"Patch Set 3: Commit message was updated.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"1fcb8ccc50273940e4a506ca92af81231b85a7ae","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-02-04 21:39:23.000000000","message":"Patch Set 3: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/20719/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19865/ : FAILURE","accounts_in_message":[],"_revision_number":3},{"id":"007d69670ee3ae864b3f491f9f2eace3a370c32c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-02-04 21:42:39.000000000","message":"Patch Set 4: Commit message was updated.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":4},{"id":"4841fa660660686184dbfc65d4bdd1655684bb2a","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-02-04 21:54:55.000000000","message":"Patch Set 4: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20720/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19866/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"24d88ae67b3749ae4af458eab3da8ef639d0e1cf","author":{"_account_id":1002347,"name":"Richard Pasek","email":"rpasek@google.com","username":"rpasek"},"real_author":{"_account_id":1002347,"name":"Richard Pasek","email":"rpasek@google.com","username":"rpasek"},"date":"2025-02-06 18:24:01.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"b092e33dc16bc6ff28e88a5c37807dea4fc97a6a","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-02-06 18:58:30.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"6cb239cced32d182cfd83a2196107b805c28f1bd","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-02-11 11:56:39.000000000","message":"Change has been successfully cherry-picked as 82277462b91506a9e7ee4bdcee86d6b414d59149","accounts_in_message":[],"_revision_number":5}],"current_revision":"82277462b91506a9e7ee4bdcee86d6b414d59149","revisions":{"00a4b901572a91033684d209a1d59672ebbb6ef3":{"kind":"REWORK","_number":1,"created":"2025-02-03 20:15:48.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/33/8733/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/33/8733/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/33/8733/1 \u0026\u0026 git checkout -b change-8733 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/33/8733/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/33/8733/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/33/8733/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/33/8733/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/33/8733/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"975222c134143e5a9c51d907d6fd5b6c1d5c5103","subject":"drivers/linuxspidev: fix minor memory leak"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-02-03 19:28:49.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-02-03 20:15:16.000000000","tz":60},"subject":"drivers/linuxspidev: fix use of uninitialised speed variable","message":"drivers/linuxspidev: fix use of uninitialised speed variable\n\nValgrind reported\n\u003d\u003d Syscall param ioctl(generic) points to uninitialised byte(s)\n\u003d\u003d    at 0x4ABF990: ioctl (ioctl.S:26)\n\u003d\u003d    by 0x19D00B: spidev_speed (linuxspidev.c:181)\n\u003d\u003d    by 0x19D00B: spidev_init (linuxspidev.c:307)\n\nIndeed, spidev_init() uses adapter_get_speed(), it calls\nadapter_khz_to_speed() and it returns early without setting the output\nparameter if adapter is not initialised. Of course the adapter initialized\nflag is not set until spidev_init() returns.\n\nSimply drop this code as the adapter infrastructure initializes\nadapter speed just after spidev_init() return.\n\nChange-Id: I26f011ae59fc942a34d9bb517f467c22f735091d\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nFixes: 83e0293f7ba3 (\"Add Linux SPI device SWD adapter support\")\n"}},"57a46ddc07847c22ec477b701feffb71a0649f0c":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2025-02-04 21:34:54.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/33/8733/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/33/8733/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/33/8733/2 \u0026\u0026 git checkout -b change-8733 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/33/8733/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/33/8733/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/33/8733/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/33/8733/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/33/8733/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"975222c134143e5a9c51d907d6fd5b6c1d5c5103","subject":"drivers/linuxspidev: fix minor memory leak"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-02-03 19:28:49.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-02-04 21:34:54.000000000","tz":0},"subject":"drivers/linuxspidev: fix use of uninitialized speed variable","message":"drivers/linuxspidev: fix use of uninitialized speed variable\n\nValgrind reported\n\u003d\u003d Syscall param ioctl(generic) points to uninitialised byte(s)\n\u003d\u003d    at 0x4ABF990: ioctl (ioctl.S:26)\n\u003d\u003d    by 0x19D00B: spidev_speed (linuxspidev.c:181)\n\u003d\u003d    by 0x19D00B: spidev_init (linuxspidev.c:307)\n\nIndeed, spidev_init() uses adapter_get_speed(), it calls\nadapter_khz_to_speed() and it returns early without setting the output\nparameter if adapter is not initialized. Of course the adapter initialized flag is not set until spidev_init() returns.\n\nSimply drop this code as the adapter infrastructure initializes\nadapter speed just after spidev_init() return.\n\nChange-Id: I26f011ae59fc942a34d9bb517f467c22f735091d\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nFixes: 83e0293f7ba3 (\"Add Linux SPI device SWD adapter support\")\n"},"description":"Edit commit message"},"ac3a3b35cc6a4d2d6c2d5d2145bb857f34136f11":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2025-02-04 21:38:37.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/33/8733/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/33/8733/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/33/8733/3 \u0026\u0026 git checkout -b change-8733 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/33/8733/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/33/8733/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/33/8733/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/33/8733/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/33/8733/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"975222c134143e5a9c51d907d6fd5b6c1d5c5103","subject":"drivers/linuxspidev: fix minor memory leak"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-02-03 19:28:49.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-02-04 21:38:37.000000000","tz":0},"subject":"drivers/linuxspidev: fix use of uninitialized speed variable","message":"drivers/linuxspidev: fix use of uninitialized speed variable\n\nValgrind reported\n\u003d\u003d Syscall param ioctl(generic) points to uninitialised byte(s)\n\u003d\u003d    at 0x4ABF990: ioctl (ioctl.S:26)\n\u003d\u003d    by 0x19D00B: spidev_speed (linuxspidev.c:181)\n\u003d\u003d    by 0x19D00B: spidev_init (linuxspidev.c:307)\n\nIndeed, spidev_init() uses adapter_get_speed(), it calls\nadapter_khz_to_speed() and it returns early without setting\nthe output parameter if adapter is not initialized.\nOf course the adapter initialized flag is not set until spidev_init() returns.\n\nSimply drop this code as the adapter infrastructure initializes\nadapter speed just after spidev_init() return.\n\nChange-Id: I26f011ae59fc942a34d9bb517f467c22f735091d\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nFixes: 83e0293f7ba3 (\"Add Linux SPI device SWD adapter support\")\n"},"description":"Edit commit message"},"9c864725d3c9434968d3154b8469ec363893bd0c":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2025-02-04 21:42:39.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/33/8733/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/33/8733/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/33/8733/4 \u0026\u0026 git checkout -b change-8733 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/33/8733/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/33/8733/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/33/8733/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/33/8733/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/33/8733/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"975222c134143e5a9c51d907d6fd5b6c1d5c5103","subject":"drivers/linuxspidev: fix minor memory leak"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-02-03 19:28:49.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-02-04 21:42:39.000000000","tz":0},"subject":"drivers/linuxspidev: fix use of uninitialized speed variable","message":"drivers/linuxspidev: fix use of uninitialized speed variable\n\nValgrind reported\n\u003d\u003d Syscall param ioctl(generic) points to uninitialised byte(s)\n\u003d\u003d    at 0x4ABF990: ioctl (ioctl.S:26)\n\u003d\u003d    by 0x19D00B: spidev_speed (linuxspidev.c:181)\n\u003d\u003d    by 0x19D00B: spidev_init (linuxspidev.c:307)\n\nIndeed, spidev_init() uses adapter_get_speed(), it calls\nadapter_khz_to_speed() and it returns early without setting\nthe output parameter if adapter is not initialized.\nOf course the adapter initialized flag is not set until\nspidev_init() returns.\n\nSimply drop this code as the adapter infrastructure initializes\nadapter speed just after spidev_init() return.\n\nChange-Id: I26f011ae59fc942a34d9bb517f467c22f735091d\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nFixes: 83e0293f7ba3 (\"Add Linux SPI device SWD adapter support\")\n"},"description":"Edit commit message"},"82277462b91506a9e7ee4bdcee86d6b414d59149":{"kind":"REWORK","_number":5,"created":"2025-02-11 11:56:39.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/33/8733/5","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/33/8733/5","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/33/8733/5 \u0026\u0026 git checkout -b change-8733 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/33/8733/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/33/8733/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/33/8733/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/33/8733/5","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/33/8733/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7dd875900ec252b5f332298cef3030f67a37150f","subject":"drivers/linuxspidev: fix minor memory leak"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-02-03 19:28:49.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-02-11 11:56:39.000000000","tz":0},"subject":"drivers/linuxspidev: fix use of uninitialized speed variable","message":"drivers/linuxspidev: fix use of uninitialized speed variable\n\nValgrind reported\n\u003d\u003d Syscall param ioctl(generic) points to uninitialised byte(s)\n\u003d\u003d    at 0x4ABF990: ioctl (ioctl.S:26)\n\u003d\u003d    by 0x19D00B: spidev_speed (linuxspidev.c:181)\n\u003d\u003d    by 0x19D00B: spidev_init (linuxspidev.c:307)\n\nIndeed, spidev_init() uses adapter_get_speed(), it calls\nadapter_khz_to_speed() and it returns early without setting\nthe output parameter if adapter is not initialized.\nOf course the adapter initialized flag is not set until\nspidev_init() returns.\n\nSimply drop this code as the adapter infrastructure initializes\nadapter speed just after spidev_init() return.\n\nChange-Id: I26f011ae59fc942a34d9bb517f467c22f735091d\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nFixes: 83e0293f7ba3 (\"Add Linux SPI device SWD adapter support\")\nReviewed-on: https://review.openocd.org/c/openocd/+/8733\nTested-by: jenkins\nReviewed-by: Richard Pasek \u003crpasek@google.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}