)]}'
{"id":"openocd~master~If8ddf165dbc563cf6d64b2094968151075778ba7","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2025-02-16 16:31:06.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"If8ddf165dbc563cf6d64b2094968151075778ba7","subject":"jtag/core: fix segfault when adapter driver has no reset method","status":"MERGED","created":"2025-02-03 20:54:36.000000000","updated":"2025-02-16 16:31:06.000000000","submitted":"2025-02-16 16:31:06.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8735","meta_rev_id":"c23610f889422c44bb917a7e4df4282385ed277d","_number":8735,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-02-16 16:31:06.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-02-16 16:31:06.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-02-03 21:09:58.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-02-04 08:46:07.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"5c08d782e53a5a38f25b80aa3e0f6c566ed5261c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-02-03 20:54:36.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e472e74bcf5222ce2730538e4fef8a5c63cd5a63","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-02-03 21:09:58.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20696/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19845/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"94e6042f9211a344c8b4c7df2335fcc930799f56","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-02-04 05:06:21.000000000","message":"Patch Set 2: Commit message was updated.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"91ea77fefc52b3acd3346707e94d9d6b042e7134","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-02-04 05:19:10.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20698/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19847/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"5bb39a2c80fa21732ab5a0204e14a07fbd556848","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-02-04 08:46:07.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"d38dda40b34a6c307e984f16427faa51c877032d","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-02-16 16:31:02.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"c23610f889422c44bb917a7e4df4282385ed277d","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-02-16 16:31:06.000000000","message":"Change has been successfully cherry-picked as ed4e58410446343a485625ee2722144cc23d55a6","accounts_in_message":[],"_revision_number":3}],"current_revision":"ed4e58410446343a485625ee2722144cc23d55a6","revisions":{"243ff24f8b307217d6c8bfedeb4a68ce4ba93d66":{"kind":"REWORK","_number":1,"created":"2025-02-03 20:54:36.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/35/8735/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/35/8735/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/35/8735/1 \u0026\u0026 git checkout -b change-8735 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/35/8735/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/35/8735/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/35/8735/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/35/8735/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/35/8735/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a697615a280322ef11ac415d276bc7401a99bc12","subject":"target/cortex_m: call adapter_deassert_reset() only if srst is configured"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-02-03 20:45:07.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-02-03 20:45:07.000000000","tz":60},"subject":"jtag/core: fix segfault when adapter driver has no reset method","message":"jtag/core: fix segfault when adapter driver has no reset method\n\nxlnx-pcie-xvc and linuxspidev adapter drivers does not implement\nthe reset method.\nAlthough its likely both adapters will implement the method in\nthe near future, avoid segfault and return an error instead.\n\nChange-Id: If8ddf165dbc563cf6d64b2094968151075778ba7\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nFixes: commit 8850eb8f2c51 (\"swd: get rid of jtag queue to assert/deassert srst\")\n"}},"c0f3c9ca04e1a9a26d65eab44c5bd2ec06924a51":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2025-02-04 05:06:21.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/35/8735/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/35/8735/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/35/8735/2 \u0026\u0026 git checkout -b change-8735 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/35/8735/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/35/8735/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/35/8735/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/35/8735/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/35/8735/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a697615a280322ef11ac415d276bc7401a99bc12","subject":"target/cortex_m: call adapter_deassert_reset() only if srst is configured"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-02-03 20:45:07.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-02-04 05:06:21.000000000","tz":0},"subject":"jtag/core: fix segfault when adapter driver has no reset method","message":"jtag/core: fix segfault when adapter driver has no reset method\n\nxlnx-pcie-xvc and linuxspidev adapter drivers does not implement\nthe reset method.\nAlthough it is likely both adapters will implement the method in\nthe near future, avoid segfault and return an error instead.\n\nChange-Id: If8ddf165dbc563cf6d64b2094968151075778ba7\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nFixes: commit 8850eb8f2c51 (\"swd: get rid of jtag queue to assert/deassert srst\")\n"},"description":"Edit commit message"},"ed4e58410446343a485625ee2722144cc23d55a6":{"kind":"REWORK","_number":3,"created":"2025-02-16 16:31:06.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/35/8735/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/35/8735/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/35/8735/3 \u0026\u0026 git checkout -b change-8735 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/35/8735/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/35/8735/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/35/8735/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/35/8735/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/35/8735/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"71f92c94468f370be80ce60dd76d5d924ddba69a","subject":"target/cortex_m: call adapter_deassert_reset() only if srst is configured"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-02-03 20:45:07.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-02-16 16:31:06.000000000","tz":0},"subject":"jtag/core: fix segfault when adapter driver has no reset method","message":"jtag/core: fix segfault when adapter driver has no reset method\n\nxlnx-pcie-xvc and linuxspidev adapter drivers does not implement\nthe reset method.\nAlthough it is likely both adapters will implement the method in\nthe near future, avoid segfault and return an error instead.\n\nChange-Id: If8ddf165dbc563cf6d64b2094968151075778ba7\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nFixes: commit 8850eb8f2c51 (\"swd: get rid of jtag queue to assert/deassert srst\")\nReviewed-on: https://review.openocd.org/c/openocd/+/8735\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}