)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"change_message_id":"dfc7f2313992daa00b2bb33cee33b0cb47a5a779","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2dd1ba1f_7c86d7a2","updated":"2025-02-04 11:58:07.000000000","message":"Hi,\n\nThank you for the patch, however, I do not like it at all!\n\nIs VirtualBox /so/ broken that requires special casing, why? How come other devices and software works without silly tricks? Where\u0027s the bugreport for the VB itself? Is VirtualBox at all relevant these days? I thought Linux has KVM+QEMU, Windows has HyperV machines, there\u0027s also VMWare for all common platforms etc, who even needs to think about VirtualBox ever?\n\nAlso, you\u0027re adding a new command but not adding proper documentation for it to the User Manual.","commit_id":"11bc6ae422e47bd85b36957a8187e3eb6b59c891"},{"author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"change_message_id":"4c0b9fa9fa20abecf5014925c8221cc4b24eb098","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0201611e_5539064f","updated":"2025-02-04 14:19:02.000000000","message":"My thoughts is if you need a longer one-time timeout for an operation which happens at most once per OpenOCD launch, just go for it without any conditionals. What would you win by having it shorter for \"normal\" case, when does it play any role?\n\nSorry but I find your explanations regarding VB delays to be unsatisfactory. Is FX2 special in this regard or is it common for enumerating any USB device? Is it a documented behaviour or a bug? How does other common software handle it, e.g. sigrok with FX2-based devices?","commit_id":"11bc6ae422e47bd85b36957a8187e3eb6b59c891"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"e07993ff4a220491a0a325ff8340729368a13a56","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9cfd2d9c_645fad01","in_reply_to":"0201611e_5539064f","updated":"2025-02-04 14:42:57.000000000","message":"Regarding the timeout, I wanted to keep it as short as possible for normal cases to avoid unnecessary delays. However, since the operation only happens once per OpenOCD launch, I understand your point. If using a fixed longer timeout (e.g., 3 seconds) is preferable for simplicity, I can remove the conditional handling.\n\nAs for the VirtualBox delays, FX2 is not unique in performing USB renumeration, but its behavior is more noticeable because it fully disconnects and re-enumerates the device after firmware loading, unlike many other USB devices that simply reset. This process is documented in Cypress FX2LP’s technical reference manual and is expected behavior.\n\nI haven\u0027t specifically tested how sigrok handles this, other than include a longer timeout, it might be intressting to look into.","commit_id":"11bc6ae422e47bd85b36957a8187e3eb6b59c891"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"55392a4eb5a840cf9898ec83ed45a1896d2bf391","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e4a6ee4c_8341f9de","in_reply_to":"2dd1ba1f_7c86d7a2","updated":"2025-02-04 14:04:59.000000000","message":"Hello,\n \nThank you for reviewing the patch and for your feedback.\n \nWe provided support for VirtualBox because we try to ensure compatibility across multiple environments, since OpenOCD is used in diverse setups, its good to accommodate common configurations, including VirtualBox.\nI would like to mention for example that this issue was reported by one of our clients.\n \nRegarding the delay issue, in the Angie adapter, we use a Cypress FX2 microcontroller, which performs a renumeration (disconnect and reconnect to the USB port) after its programmation. The problem is that this renumeration process takes longer in a virtualized environment like VirtualBox, USB passthrough introduces additional delays due to the need to detach the device from Windows and reattach it to the Linux guest and general overhead from virtualization, which is not present on a native Linux system.\n \nRegarding the new command, I agree that I should have added documentation, I\u0027ll make sure to include it in the next update. However, since I also implemented an automatic check for VirtualBox within angie_init(), the command might not be strictly necessary. I initially kept it as I thought it could be useful for debugging or future development, but I’m open to feedback on whether to remove it or just properly document it.\n \nPlease let me know your thoughts. I appreciate your input and will be happy to adjust the patch accordingly.","commit_id":"11bc6ae422e47bd85b36957a8187e3eb6b59c891"}],"src/jtag/drivers/angie.c":[{"author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"change_message_id":"dfc7f2313992daa00b2bb33cee33b0cb47a5a779","unresolved":true,"context_lines":[{"line_number":66,"context_line":"#define FIRMWARE_ADDR\t0x0000"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"/** Delay (in microseconds) to wait while EZ-USB performs ReNumeration. */"},{"line_number":69,"context_line":"uint32_t ANGIE_RENUMERATION_DELAY_US;"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"/** Default location of ANGIE firmware image. */"},{"line_number":72,"context_line":"#define ANGIE_FIRMWARE_FILE\tPKGDATADIR \"/angie/angie_firmware.bin\""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"d921f501_4f51de96","line":69,"updated":"2025-02-04 11:58:07.000000000","message":"It\u0027s not a macro anymore so having this ALL CAPS is plain confusing.","commit_id":"11bc6ae422e47bd85b36957a8187e3eb6b59c891"},{"author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"change_message_id":"dfc7f2313992daa00b2bb33cee33b0cb47a5a779","unresolved":true,"context_lines":[{"line_number":1326,"context_line":""},{"line_number":1327,"context_line":"/**"},{"line_number":1328,"context_line":" * Handle the AT91SAM9 CLE command for specifying the address line to use for"},{"line_number":1329,"context_line":" * writing commands to a NAND device."},{"line_number":1330,"context_line":" */"},{"line_number":1331,"context_line":"COMMAND_HANDLER(handle_vm_activate_command)"},{"line_number":1332,"context_line":"{"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"ba16ad15_ceda3b1c","line":1329,"updated":"2025-02-04 11:58:07.000000000","message":"What?","commit_id":"11bc6ae422e47bd85b36957a8187e3eb6b59c891"},{"author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"change_message_id":"dfc7f2313992daa00b2bb33cee33b0cb47a5a779","unresolved":true,"context_lines":[{"line_number":1337,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":1338,"context_line":"\t}"},{"line_number":1339,"context_line":""},{"line_number":1340,"context_line":"\tif (strcmp(CMD_ARGV[0], \"true\") \u003d\u003d 0) {"},{"line_number":1341,"context_line":"\t\tactivate \u003d true;"},{"line_number":1342,"context_line":"\t\tANGIE_RENUMERATION_DELAY_US \u003d 2500000;"},{"line_number":1343,"context_line":"\t} else if (strcmp(CMD_ARGV[0], \"false\") \u003d\u003d 0) {"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"2aaa7679_780dc6c8","line":1340,"updated":"2025-02-04 11:58:07.000000000","message":"Not using generic helpers for bool, why?","commit_id":"11bc6ae422e47bd85b36957a8187e3eb6b59c891"},{"author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"change_message_id":"dfc7f2313992daa00b2bb33cee33b0cb47a5a779","unresolved":true,"context_lines":[{"line_number":1402,"context_line":"\t\t.name \u003d \"vm_activate\","},{"line_number":1403,"context_line":"\t\t.handler \u003d handle_vm_activate_command,"},{"line_number":1404,"context_line":"\t\t.mode \u003d COMMAND_CONFIG,"},{"line_number":1405,"context_line":"\t\t.help \u003d \"set command vm delay activate\","},{"line_number":1406,"context_line":"\t\t.usage \u003d \"\u003ctrue|false\u003e\","},{"line_number":1407,"context_line":"\t},"},{"line_number":1408,"context_line":"\tCOMMAND_REGISTRATION_DONE"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"dceca6c8_10fe359b","line":1405,"updated":"2025-02-04 11:58:07.000000000","message":"This help is incomprehensible, pure word salad.","commit_id":"11bc6ae422e47bd85b36957a8187e3eb6b59c891"}]}