)]}'
{"id":"openocd~master~Iadd6803431edb83d0d84f4e4dc6d36b454f912ac","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2025-02-16 16:31:35.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"Iadd6803431edb83d0d84f4e4dc6d36b454f912ac","subject":"build: drop space after \u0027angie\u0027 folder name","status":"MERGED","created":"2025-02-06 10:53:46.000000000","updated":"2025-02-16 16:31:39.000000000","submitted":"2025-02-16 16:31:39.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8740","meta_rev_id":"7f5c70863768744ae7a3d04fa0dad5e8afc23916","_number":8740,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001319,"name":"Liviu Ionescu","username":"ilg-ul"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1002344,"name":"Adrien Charruel","email":"acharruel@nanoxplore.com","username":"acharruel","status":"NanoXplore"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-02-16 16:31:39.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-02-16 16:31:39.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001319,"name":"Liviu Ionescu","username":"ilg-ul"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-02-16 16:31:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-02-16 16:31:39.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1002344,"name":"Adrien Charruel","email":"acharruel@nanoxplore.com","username":"acharruel","status":"NanoXplore"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001319,"name":"Liviu Ionescu","username":"ilg-ul"},{"_account_id":1002344,"name":"Adrien Charruel","email":"acharruel@nanoxplore.com","username":"acharruel","status":"NanoXplore"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-02-06 11:08:07.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-02-06 11:12:05.000000000","updated_by":{"_account_id":1001319,"name":"Liviu Ionescu","username":"ilg-ul"},"reviewer":{"_account_id":1001319,"name":"Liviu Ionescu","username":"ilg-ul"},"state":"REVIEWER"},{"updated":"2025-02-06 12:03:52.000000000","updated_by":{"_account_id":1002344,"name":"Adrien Charruel","email":"acharruel@nanoxplore.com","username":"acharruel","status":"NanoXplore"},"reviewer":{"_account_id":1002344,"name":"Adrien Charruel","email":"acharruel@nanoxplore.com","username":"acharruel","status":"NanoXplore"},"state":"REVIEWER"}],"messages":[{"id":"b33b6de2116fe9ba067ef90feb10b397e08faa00","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-02-06 10:53:46.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a65e79e90783a3e5bf2db3e82b27495fbe896863","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-02-06 11:08:07.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20732/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19878/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"75a435af467c248010af88aa2a31b79eb338d42f","author":{"_account_id":1001319,"name":"Liviu Ionescu","username":"ilg-ul"},"real_author":{"_account_id":1001319,"name":"Liviu Ionescu","username":"ilg-ul"},"date":"2025-02-06 11:12:05.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e6fcb33b990c1fcc891353e41f6bf76aed955141","author":{"_account_id":1002344,"name":"Adrien Charruel","email":"acharruel@nanoxplore.com","username":"acharruel","status":"NanoXplore"},"real_author":{"_account_id":1002344,"name":"Adrien Charruel","email":"acharruel@nanoxplore.com","username":"acharruel","status":"NanoXplore"},"date":"2025-02-06 12:03:52.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"c4b2fe61912c65f1ac67378ece4581caf60aaef4","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-02-16 16:31:35.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"7f5c70863768744ae7a3d04fa0dad5e8afc23916","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-02-16 16:31:39.000000000","message":"Change has been successfully cherry-picked as 1f3f635693a1ddc85f362dc324cb49c3e7b75f27","accounts_in_message":[],"_revision_number":2}],"current_revision":"1f3f635693a1ddc85f362dc324cb49c3e7b75f27","revisions":{"1f3f635693a1ddc85f362dc324cb49c3e7b75f27":{"kind":"REWORK","_number":2,"created":"2025-02-16 16:31:39.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/40/8740/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/40/8740/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/40/8740/2 \u0026\u0026 git checkout -b change-8740 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/40/8740/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/40/8740/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/40/8740/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/40/8740/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/40/8740/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ed4e58410446343a485625ee2722144cc23d55a6","subject":"jtag/core: fix segfault when adapter driver has no reset method"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-02-06 10:48:30.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-02-16 16:31:39.000000000","tz":0},"subject":"build: drop space after \u0027angie\u0027 folder name","message":"build: drop space after \u0027angie\u0027 folder name\n\nThe makefile consider the two white spaces between the end of the\nfolder name and the \u0027#\u0027 character for the beginning of the comment\nas part of the folder name.\nThis cause \u0027make install\u0027 to create a folder named  \u0027angie  \u0027 that\nis not welcome on all the OS.\n\nDrop the comment and the space after the folder name.\n\nReported-by: Liviu Ionescu \u003cilg@livius.net\u003e\nChange-Id: Iadd6803431edb83d0d84f4e4dc6d36b454f912ac\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nFixes: 0ed03df6e95b (\"amend angie build definitions to fix make dist\")\nReviewed-on: https://review.openocd.org/c/openocd/+/8740\nReviewed-by: Liviu Ionescu\nTested-by: jenkins\nReviewed-by: Adrien Charruel \u003cacharruel@nanoxplore.com\u003e\n"}},"f060a5bf11e6cf6f69638df0671688b9df7c89f6":{"kind":"REWORK","_number":1,"created":"2025-02-06 10:53:46.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/40/8740/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/40/8740/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/40/8740/1 \u0026\u0026 git checkout -b change-8740 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/40/8740/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/40/8740/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/40/8740/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/40/8740/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/40/8740/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"eb6f2745b7d9924d0dddeab91c1743867c4e812c","subject":"flash/nor: add DesignWare SPI controller driver"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-02-06 10:48:30.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-02-06 10:52:38.000000000","tz":60},"subject":"build: drop space after \u0027angie\u0027 folder name","message":"build: drop space after \u0027angie\u0027 folder name\n\nThe makefile consider the two white spaces between the end of the\nfolder name and the \u0027#\u0027 character for the beginning of the comment\nas part of the folder name.\nThis cause \u0027make install\u0027 to create a folder named  \u0027angie  \u0027 that\nis not welcome on all the OS.\n\nDrop the comment and the space after the folder name.\n\nReported-by: Liviu Ionescu \u003cilg@livius.net\u003e\nChange-Id: Iadd6803431edb83d0d84f4e4dc6d36b454f912ac\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nFixes: 0ed03df6e95b (\"amend angie build definitions to fix make dist\")\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}