)]}'
{"src/jtag/drivers/ch347.c":[{"author":{"_account_id":1002199,"name":"ZhiYuanNJ","display_name":" ZhiYuanNJ","email":"871238103@qq.com","username":"ZhiYuanNJ"},"change_message_id":"c1f164f62f1512ac83597110b3e30a48abccb48e","unresolved":true,"context_lines":[{"line_number":1675,"context_line":" */"},{"line_number":1676,"context_line":"static int ch347_speed_get(int speed_idx, int *khz)"},{"line_number":1677,"context_line":"{"},{"line_number":1678,"context_line":"\tif (swd_mode) {"},{"line_number":1679,"context_line":"\t\tif (speed_idx)"},{"line_number":1680,"context_line":"\t\t\t*khz \u003d (1000 + speed_idx / 2) / speed_idx;"},{"line_number":1681,"context_line":"\t\telse"},{"line_number":1682,"context_line":"\t\t\t*khz \u003d 100;"},{"line_number":1683,"context_line":"\t\treturn ERROR_OK;"},{"line_number":1684,"context_line":"\t}"},{"line_number":1685,"context_line":""},{"line_number":1686,"context_line":"\tint retval \u003d ch347_init_pack_size();"},{"line_number":1687,"context_line":"\tif (retval !\u003d ERROR_OK)"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"23acf7a9_97f76589","line":1684,"range":{"start_line":1678,"start_character":1,"end_line":1684,"end_character":2},"updated":"2025-08-05 02:37:35.000000000","message":"Refer to https://review.openocd.org/c/openocd/+/8741/comment/8ed85f50_99d2632b/ for details.","commit_id":"6a80ca376735e511baf61251a36907687b91d3b6"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"03d9f2aca0f287e99bef16dbac06ce6684f39690","unresolved":false,"context_lines":[{"line_number":1675,"context_line":" */"},{"line_number":1676,"context_line":"static int ch347_speed_get(int speed_idx, int *khz)"},{"line_number":1677,"context_line":"{"},{"line_number":1678,"context_line":"\tif (swd_mode) {"},{"line_number":1679,"context_line":"\t\tif (speed_idx)"},{"line_number":1680,"context_line":"\t\t\t*khz \u003d (1000 + speed_idx / 2) / speed_idx;"},{"line_number":1681,"context_line":"\t\telse"},{"line_number":1682,"context_line":"\t\t\t*khz \u003d 100;"},{"line_number":1683,"context_line":"\t\treturn ERROR_OK;"},{"line_number":1684,"context_line":"\t}"},{"line_number":1685,"context_line":""},{"line_number":1686,"context_line":"\tint retval \u003d ch347_init_pack_size();"},{"line_number":1687,"context_line":"\tif (retval !\u003d ERROR_OK)"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"6edf218c_fa60cdb5","line":1684,"range":{"start_line":1678,"start_character":1,"end_line":1684,"end_character":2},"in_reply_to":"23acf7a9_97f76589","updated":"2025-08-06 09:37:08.000000000","message":"I prefer to have low speeds available as commented in my reply to https://review.openocd.org/c/openocd/+/8746/comments/1750f903_59e9ec20\nThe zero index of 5 MHz clocks of v5.44/1.1 was added.","commit_id":"6a80ca376735e511baf61251a36907687b91d3b6"},{"author":{"_account_id":1002199,"name":"ZhiYuanNJ","display_name":" ZhiYuanNJ","email":"871238103@qq.com","username":"ZhiYuanNJ"},"change_message_id":"c1f164f62f1512ac83597110b3e30a48abccb48e","unresolved":true,"context_lines":[{"line_number":1708,"context_line":"\t}"},{"line_number":1709,"context_line":""},{"line_number":1710,"context_line":"\tif (swd_mode) {"},{"line_number":1711,"context_line":"\t\t*speed_idx \u003d MIN(DIV_ROUND_UP(1000, khz), 20);"},{"line_number":1712,"context_line":"\t\treturn ERROR_OK;"},{"line_number":1713,"context_line":"\t}"},{"line_number":1714,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"a295c171_eff72e7b","line":1711,"range":{"start_line":1711,"start_character":2,"end_line":1711,"end_character":48},"updated":"2025-08-05 02:37:35.000000000","message":"Hi, Requires modification here. Refer to [https://review.openocd.org/c/openocd/+/8741/comment/8ed85f50_99d2632b/](https://review.openocd.org/c/openocd/+/8741/comment/8ed85f50_99d2632b/) for details.","commit_id":"6a80ca376735e511baf61251a36907687b91d3b6"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"03d9f2aca0f287e99bef16dbac06ce6684f39690","unresolved":false,"context_lines":[{"line_number":1708,"context_line":"\t}"},{"line_number":1709,"context_line":""},{"line_number":1710,"context_line":"\tif (swd_mode) {"},{"line_number":1711,"context_line":"\t\t*speed_idx \u003d MIN(DIV_ROUND_UP(1000, khz), 20);"},{"line_number":1712,"context_line":"\t\treturn ERROR_OK;"},{"line_number":1713,"context_line":"\t}"},{"line_number":1714,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"395a3c33_e651671d","line":1711,"range":{"start_line":1711,"start_character":2,"end_line":1711,"end_character":48},"in_reply_to":"a295c171_eff72e7b","updated":"2025-08-06 09:37:08.000000000","message":"Done","commit_id":"6a80ca376735e511baf61251a36907687b91d3b6"},{"author":{"_account_id":1002199,"name":"ZhiYuanNJ","display_name":" ZhiYuanNJ","email":"871238103@qq.com","username":"ZhiYuanNJ"},"change_message_id":"586f4833939468a20bf603a8fb75584f910e2ea8","unresolved":true,"context_lines":[{"line_number":1507,"context_line":"\t\tch347.use_bitwise_mode \u003d false;"},{"line_number":1508,"context_line":"\t}"},{"line_number":1509,"context_line":""},{"line_number":1510,"context_line":"\tch347.swclk_5mhz_supported \u003d ch347.chip_variant \u003d\u003d CH347F || ch347_device_descriptor.bcdDevice \u003e\u003d 0x544;"},{"line_number":1511,"context_line":""},{"line_number":1512,"context_line":"\tif (ch347.chip_variant \u003d\u003d CH347T) {"},{"line_number":1513,"context_line":"\t\tif (swd_mode) {"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"7936dd6c_c4d29279","line":1510,"range":{"start_line":1510,"start_character":1,"end_line":1510,"end_character":105},"updated":"2025-08-06 02:44:14.000000000","message":"CH347F v1.0 not support 5mhz,\n```\nch347.swclk_5mhz_supported \u003d (ch347.chip_variant \u003d\u003d CH347F \u0026\u0026 ch347_device_descriptor.bcdDevice \u003e\u003d 0x110) || ch347_device_descriptor.bcdDevice \u003e\u003d 0x544;\n```","commit_id":"64fc3bb3234c97335267a7971b7d1a429f5213df"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"03d9f2aca0f287e99bef16dbac06ce6684f39690","unresolved":false,"context_lines":[{"line_number":1507,"context_line":"\t\tch347.use_bitwise_mode \u003d false;"},{"line_number":1508,"context_line":"\t}"},{"line_number":1509,"context_line":""},{"line_number":1510,"context_line":"\tch347.swclk_5mhz_supported \u003d ch347.chip_variant \u003d\u003d CH347F || ch347_device_descriptor.bcdDevice \u003e\u003d 0x544;"},{"line_number":1511,"context_line":""},{"line_number":1512,"context_line":"\tif (ch347.chip_variant \u003d\u003d CH347T) {"},{"line_number":1513,"context_line":"\t\tif (swd_mode) {"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"c4200b4a_f5b1510d","line":1510,"range":{"start_line":1510,"start_character":1,"end_line":1510,"end_character":105},"in_reply_to":"5c4efd58_3610187e","updated":"2025-08-06 09:37:08.000000000","message":"Done","commit_id":"64fc3bb3234c97335267a7971b7d1a429f5213df"},{"author":{"_account_id":1002199,"name":"ZhiYuanNJ","display_name":" ZhiYuanNJ","email":"871238103@qq.com","username":"ZhiYuanNJ"},"change_message_id":"10b246301fd406ca2ceb241c459fb2998bdeec12","unresolved":true,"context_lines":[{"line_number":1507,"context_line":"\t\tch347.use_bitwise_mode \u003d false;"},{"line_number":1508,"context_line":"\t}"},{"line_number":1509,"context_line":""},{"line_number":1510,"context_line":"\tch347.swclk_5mhz_supported \u003d ch347.chip_variant \u003d\u003d CH347F || ch347_device_descriptor.bcdDevice \u003e\u003d 0x544;"},{"line_number":1511,"context_line":""},{"line_number":1512,"context_line":"\tif (ch347.chip_variant \u003d\u003d CH347T) {"},{"line_number":1513,"context_line":"\t\tif (swd_mode) {"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"5c4efd58_3610187e","line":1510,"range":{"start_line":1510,"start_character":1,"end_line":1510,"end_character":105},"in_reply_to":"7936dd6c_c4d29279","updated":"2025-08-06 03:39:02.000000000","message":"\u003e CH347F v1.0 not support 5mhz,\n\u003e ```\n\u003e ch347.swclk_5mhz_supported \u003d (ch347.chip_variant \u003d\u003d CH347F \u0026\u0026 ch347_device_descriptor.bcdDevice \u003e\u003d 0x110) || ch347_device_descriptor.bcdDevice \u003e\u003d 0x544;\n\u003e ```\n\nIt should be **0x101**, not 0x110","commit_id":"64fc3bb3234c97335267a7971b7d1a429f5213df"}]}
