)]}'
{"id":"openocd~master~Ia7b7f0d373ff463e2f0742bdd068c3833c57f340","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2025-08-14 13:39:38.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"Ia7b7f0d373ff463e2f0742bdd068c3833c57f340","subject":"drivers/ch347: fix conditional sending of idle clock cycles","status":"MERGED","created":"2025-02-08 21:05:55.000000000","updated":"2025-08-24 05:03:55.000000000","submitted":"2025-08-24 05:03:55.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8744","meta_rev_id":"f27bf24bac20a84039c54257e9a7f837d2c531a3","_number":8744,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1002199,"name":"ZhiYuanNJ","display_name":" ZhiYuanNJ","email":"871238103@qq.com","username":"ZhiYuanNJ"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-08-24 05:03:55.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-08-24 05:03:55.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1002199,"name":"ZhiYuanNJ","display_name":" ZhiYuanNJ","email":"871238103@qq.com","username":"ZhiYuanNJ"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-08-24 05:03:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1002199,"name":"ZhiYuanNJ","display_name":" ZhiYuanNJ","email":"871238103@qq.com","username":"ZhiYuanNJ"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-02-08 21:49:36.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-08-13 09:59:14.000000000","updated_by":{"_account_id":1002199,"name":"ZhiYuanNJ","display_name":" ZhiYuanNJ","email":"871238103@qq.com","username":"ZhiYuanNJ"},"reviewer":{"_account_id":1002199,"name":"ZhiYuanNJ","display_name":" ZhiYuanNJ","email":"871238103@qq.com","username":"ZhiYuanNJ"},"state":"REVIEWER"}],"messages":[{"id":"9d69d560331c1d530887d99aeeeb2dff540dea29","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-02-08 21:05:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ae06f9a5d4275ed253fd21b026e4532834486818","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-02-08 21:49:36.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20760/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19905/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"28969524a8f6d6b8022f9f39a8babe27edc2ee1c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-02-08 22:43:20.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"46c0fe4b2c217c405f74c762a442870b3e07ad0d","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-02-08 23:00:42.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20764/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19907/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"a9cc411bb86f1ba01f6a5cf2821258016214593d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-02-09 11:16:38.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"6e32a9c24fa92eee5554fd4bf928b5a3ac5ef8c7","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-02-09 12:00:24.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20769/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19913/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"e4c52bfb8a577e156d7115b31b690cc05b3f5062","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-08-05 20:00:33.000000000","message":"Uploaded patch set 4.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":4},{"id":"c3a358e7bb3edfa693acf38f6a723d8e0bc586dd","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-08-05 21:06:46.000000000","message":"Patch Set 4: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20722/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/21589/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"ad6785b7ff08d7e7b092bd20b20993ef4f6022de","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-08-06 09:22:58.000000000","message":"Uploaded patch set 5: Patch Set 4 was rebased.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":5},{"id":"fb79f7a97047d5e859eecfcf8b1a6b33cc1b0856","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-08-06 09:41:35.000000000","message":"Patch Set 5: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20730/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/21597/ : SUCCESS","accounts_in_message":[],"_revision_number":5},{"id":"e3e5a7a415276ea5e4e251646f540e99a4abf435","author":{"_account_id":1002199,"name":"ZhiYuanNJ","display_name":" ZhiYuanNJ","email":"871238103@qq.com","username":"ZhiYuanNJ"},"real_author":{"_account_id":1002199,"name":"ZhiYuanNJ","display_name":" ZhiYuanNJ","email":"871238103@qq.com","username":"ZhiYuanNJ"},"date":"2025-08-13 09:59:14.000000000","message":"Patch Set 5: Code-Review+1","accounts_in_message":[],"_revision_number":5},{"id":"23e34ddb0b150e870b7d9beeb34af65f4595d915","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-08-14 13:39:38.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"f27bf24bac20a84039c54257e9a7f837d2c531a3","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-08-24 05:03:55.000000000","message":"Change has been successfully cherry-picked as 0c575ced95219f11d554bdf5c34008362fb38f7b","accounts_in_message":[],"_revision_number":6}],"current_revision":"0c575ced95219f11d554bdf5c34008362fb38f7b","revisions":{"0c575ced95219f11d554bdf5c34008362fb38f7b":{"kind":"REWORK","_number":6,"created":"2025-08-24 05:03:55.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/44/8744/6","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/44/8744/6","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/44/8744/6 \u0026\u0026 git checkout -b change-8744 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/44/8744/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/44/8744/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/44/8744/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/44/8744/6","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/44/8744/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"87f78286794f6d8fbf885715b01b685f98885d9d","subject":"drivers/ch347: add SWD speed settings"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-02-08 20:36:15.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-08-24 05:03:55.000000000","tz":0},"subject":"drivers/ch347: fix conditional sending of idle clock cycles","message":"drivers/ch347: fix conditional sending of idle clock cycles\n\nch347_swd_run_queue() fulfilled ADI requirement for idle cycles\nafter the last transaction just if there was room in the buffer.\nA lazy programmer avoided this way the danger of recurrent call.\n\nIntroduce ch347_swd_run_queue_inner() without sending idle cycles.\nThey are useless when flushing the queue to get room for the next\ntransaction.\n\nch347_swd_run_queue() now can make room for idle cycles\nin the queue without recursion.\n\nWhile on it remove two useless debug logs showing ap_delay_clk\nvalue and prevent the overflow of ap_delay_clk forcing it to be \u003c\u003d 255.\n\nChange-Id: Ia7b7f0d373ff463e2f0742bdd068c3833c57f340\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8744\nReviewed-by: ZhiYuanNJ \u003c871238103@qq.com\u003e\nTested-by: jenkins\n"}},"a5a1fdaa0d2a1921507df079a6f545e1987066f0":{"kind":"TRIVIAL_REBASE","_number":5,"created":"2025-08-06 09:22:58.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/44/8744/5","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/44/8744/5","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/44/8744/5 \u0026\u0026 git checkout -b change-8744 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/44/8744/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/44/8744/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/44/8744/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/44/8744/5","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/44/8744/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a827306c56ac0d7db1e0f981399b1093376c4f03","subject":"drivers/ch347: add SWD speed settings"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-02-08 20:36:15.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-08-06 09:18:51.000000000","tz":120},"subject":"drivers/ch347: fix conditional sending of idle clock cycles","message":"drivers/ch347: fix conditional sending of idle clock cycles\n\nch347_swd_run_queue() fulfilled ADI requirement for idle cycles\nafter the last transaction just if there was room in the buffer.\nA lazy programmer avoided this way the danger of recurrent call.\n\nIntroduce ch347_swd_run_queue_inner() without sending idle cycles.\nThey are useless when flushing the queue to get room for the next\ntransaction.\n\nch347_swd_run_queue() now can make room for idle cycles\nin the queue without recursion.\n\nWhile on it remove two useless debug logs showing ap_delay_clk\nvalue and prevent the overflow of ap_delay_clk forcing it to be \u003c\u003d 255.\n\nChange-Id: Ia7b7f0d373ff463e2f0742bdd068c3833c57f340\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"da1823fc668fce73183424234fd283843256b84f":{"kind":"REWORK","_number":4,"created":"2025-08-05 20:00:33.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/44/8744/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/44/8744/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/44/8744/4 \u0026\u0026 git checkout -b change-8744 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/44/8744/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/44/8744/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/44/8744/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/44/8744/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/44/8744/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"64fc3bb3234c97335267a7971b7d1a429f5213df","subject":"drivers/ch347: add SWD speed settings"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-02-08 20:36:15.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-08-05 19:48:35.000000000","tz":120},"subject":"drivers/ch347: fix conditional sending of idle clock cycles","message":"drivers/ch347: fix conditional sending of idle clock cycles\n\nch347_swd_run_queue() fulfilled ADI requirement for idle cycles\nafter the last transaction just if there was room in the buffer.\nA lazy programmer avoided this way the danger of recurrent call.\n\nIntroduce ch347_swd_run_queue_inner() without sending idle cycles.\nThey are useless when flushing the queue to get room for the next\ntransaction.\n\nch347_swd_run_queue() now can make room for idle cycles\nin the queue without recursion.\n\nWhile on it remove two useless debug logs showing ap_delay_clk\nvalue and prevent the overflow of ap_delay_clk forcing it to be \u003c\u003d 255.\n\nChange-Id: Ia7b7f0d373ff463e2f0742bdd068c3833c57f340\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"ae9cbdeb7ceac62aeae6b3bb367f62e099087e1f":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2025-02-09 11:16:38.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/44/8744/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/44/8744/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/44/8744/3 \u0026\u0026 git checkout -b change-8744 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/44/8744/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/44/8744/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/44/8744/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/44/8744/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/44/8744/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6a80ca376735e511baf61251a36907687b91d3b6","subject":"drivers/ch347: add SWD speed settings"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-02-08 20:36:15.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-02-09 11:16:24.000000000","tz":60},"subject":"drivers/ch347: fix conditional sending of idle clock cycles","message":"drivers/ch347: fix conditional sending of idle clock cycles\n\nch347_swd_run_queue() fulfilled ADI requirement for idle cycles\nafter the last transaction just if there was room in the buffer.\nA lazy programmer avoided this way the danger of recurrent call.\n\nIntroduce ch347_swd_run_queue_inner() without sending idle cycles.\nThey are useless when flushing the queue to get room for the next\ntransaction.\n\nch347_swd_run_queue() now can make room for idle cycles\nin the queue without recursion.\n\nWhile on it remove two useless debug logs showing ap_delay_clk\nvalue and prevent the overflow of ap_delay_clk forcing it to be \u003c\u003d 255.\n\nChange-Id: Ia7b7f0d373ff463e2f0742bdd068c3833c57f340\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"04a2dbd0447a0b9d013b967c398ba36461e3dc27":{"kind":"REWORK","_number":2,"created":"2025-02-08 22:43:20.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/44/8744/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/44/8744/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/44/8744/2 \u0026\u0026 git checkout -b change-8744 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/44/8744/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/44/8744/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/44/8744/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/44/8744/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/44/8744/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a1d1ea0446248672ee0237892ca593528397fa46","subject":"drivers/ch347: add SWD speed settings"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-02-08 20:36:15.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-02-08 22:36:03.000000000","tz":60},"subject":"drivers/ch347: fix conditional sending of idle clock cycles","message":"drivers/ch347: fix conditional sending of idle clock cycles\n\nch347_swd_run_queue() fulfilled ADI requirement for idle cycles\nafter the last transaction just if there was room in the buffer.\nA lazy programmer avoided this way the danger of recurrent call.\n\nIntroduce ch347_swd_run_queue_inner() without sending idle cycles.\nThey are useless when flushing the queue to get room for the next\ntransaction.\n\nch347_swd_run_queue() now can make room for idle cycles\nin the queue without recursion.\n\nWhile on it remove two useless debug logs showing ap_delay_clk\nvalue and prevent the overflow of ap_delay_clk forcing it to be \u003c\u003d 255.\n\nChange-Id: Ia7b7f0d373ff463e2f0742bdd068c3833c57f340\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"97d666747e3b36e451abdce8133603f2b9135379":{"kind":"REWORK","_number":1,"created":"2025-02-08 21:05:55.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/44/8744/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/44/8744/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/44/8744/1 \u0026\u0026 git checkout -b change-8744 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/44/8744/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/44/8744/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/44/8744/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/44/8744/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/44/8744/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a1d1ea0446248672ee0237892ca593528397fa46","subject":"drivers/ch347: add SWD speed settings"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-02-08 20:36:15.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-02-08 21:00:09.000000000","tz":60},"subject":"drivers/ch347: fix conditional sending of idle clock cycles","message":"drivers/ch347: fix conditional sending of idle clock cycles\n\nch347_swd_queue_flush() fulfilled ADI requirement for idle cycles\nafter the last transaction just if there was room in the buffer.\nA lazy programmer avoided this way the danger of recurrent call.\n\nIntroduce ch347_swd_queue_flush_inner() without sending idle cycles.\nThey are useless when flushing the queue to get room for the next\ntransaction.\n\nch347_swd_queue_flush() now can make room for idle cycles\nin the queue without recursion.\n\nWhile on it remove two useless debug logs showing ap_delay_clk\nvalue.\n\nChange-Id: Ia7b7f0d373ff463e2f0742bdd068c3833c57f340\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}