)]}'
{"id":"openocd~master~I89b05eec6fac299bcedf1c17c873212c17f519de","project":"openocd","branch":"master","attention_set":{"1001667":{"account":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"last_update":"2025-02-09 17:08:25.000000000","reason":"A robot voted negatively on a label"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I89b05eec6fac299bcedf1c17c873212c17f519de","subject":"helper/binarybuffer: Avoid -Wconversion warnings","status":"NEW","created":"2025-02-09 17:07:04.000000000","updated":"2025-02-12 16:40:14.000000000","submit_type":"CHERRY_PICK","submittable":false,"total_comment_count":2,"unresolved_comment_count":2,"has_review_started":true,"meta_rev_id":"c952e616636660049bf0a0144c0f8d143dc85cf4","_number":8748,"owner":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:jenkins-gerrit-trigger","value":1,"date":"2025-02-09 17:58:07.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"CC":[{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-02-09 17:08:25.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-02-09 22:45:55.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2025-02-12 16:40:14.000000000","updated_by":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"reviewer":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"state":"CC"}],"messages":[{"id":"cd2892af43f7a1ad5cdb94b6da392ea3061878bd","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2025-02-09 17:07:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ff292e6da1d89c38f65de36c0ba35d311c1b5c47","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-02-09 17:08:25.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/20773/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19918/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"0d2251e24c50044ca63fb13ba834ea711ed4ad03","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2025-02-09 17:17:44.000000000","message":"Uploaded patch set 2: Commit message was updated.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"df3b1d40052dfddf77a2bd9fe00e7931c99e0ded","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-02-09 17:58:07.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20774/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19919/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"2dd535f85eee534c285f4162d00784d1f4f7d8c8","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-02-09 22:45:55.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2}],"current_revision":"78cdb83fa2141c342dc880db92a99050f4b8fd13","revisions":{"3bd53815c5a0b790d235201fd5439916f6bfd159":{"kind":"REWORK","_number":1,"created":"2025-02-09 17:07:04.000000000","uploader":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"ref":"refs/changes/48/8748/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/48/8748/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/48/8748/1 \u0026\u0026 git checkout -b change-8748 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/48/8748/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/48/8748/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/48/8748/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/48/8748/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/48/8748/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"eb6f2745b7d9924d0dddeab91c1743867c4e812c","subject":"flash/nor: add DesignWare SPI controller driver"}],"author":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2025-02-09 16:59:21.000000000","tz":60},"committer":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2025-02-09 17:06:49.000000000","tz":60},"subject":"helper/binarybuffer: Avoid -Wconversion warnings","message":"helper/binarybuffer: Avoid -Wconversion warnings\n\nAvoid -Wconversion warnings in binarybuffer.{c,h} by replacing\nimplicit trucnations (or implicit sign conversions) by explict\ncasts.\n\nHopefully, it will become possible to enable -Wconversion on\n(parts of) OpenOCD code one day; and this patch is a step that\ndirection.\n\nNote: The occurrences of -Wconversion in the current OpenOCD\ncode can be shown by manually enabling this warning during\nconfigure - for example this way:\n\n  ./bootstrap \u0026\u0026  \\\n  ./configure CFLAGS\u003d\"-Wconversion\" --disable-werror \u0026\u0026  \\\n  make clean \u0026\u0026  \\\n  make -j`nproc` 2\u003e\u00261 | tee build_log.txt \u0026\u0026  \\\n  grep -P \"\\[\\-W(sign\\-)?conversion\\]\"  \\\n    \u003c build_log.txt \u003e wconversion.txt\n\nChange-Id: I89b05eec6fac299bcedf1c17c873212c17f519de\nSigned-off-by: Jan Matyas \u003cjan.matyas@codasip.com\u003e\n"}},"78cdb83fa2141c342dc880db92a99050f4b8fd13":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2025-02-09 17:17:44.000000000","uploader":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"ref":"refs/changes/48/8748/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/48/8748/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/48/8748/2 \u0026\u0026 git checkout -b change-8748 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/48/8748/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/48/8748/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/48/8748/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/48/8748/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/48/8748/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"eb6f2745b7d9924d0dddeab91c1743867c4e812c","subject":"flash/nor: add DesignWare SPI controller driver"}],"author":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2025-02-09 16:59:21.000000000","tz":60},"committer":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2025-02-09 17:17:10.000000000","tz":60},"subject":"helper/binarybuffer: Avoid -Wconversion warnings","message":"helper/binarybuffer: Avoid -Wconversion warnings\n\nAvoid -Wconversion warnings in binarybuffer.{c,h} by replacing\nimplicit trucnations (or implicit sign conversions) by explicit\ncasts.\n\nHopefully, it will become possible to enable -Wconversion on\n(parts of) OpenOCD code one day; and this patch is a step that\ndirection.\n\nNote: The occurrences of -Wconversion in the current OpenOCD\ncode can be shown by manually enabling this warning during\nconfigure - for example this way:\n\n  ./bootstrap \u0026\u0026  \\\n  ./configure CFLAGS\u003d\"-Wconversion\" --disable-werror \u0026\u0026  \\\n  make clean \u0026\u0026  \\\n  make -j`nproc` 2\u003e\u00261 | tee build_log.txt \u0026\u0026  \\\n  grep -P \"\\[\\-W(sign\\-)?conversion\\]\"  \\\n    \u003c build_log.txt \u003e wconversion.txt\n\nChange-Id: I89b05eec6fac299bcedf1c17c873212c17f519de\nSigned-off-by: Jan Matyas \u003cjan.matyas@codasip.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"NEED"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}}]}