)]}'
{"src/helper/bits.h":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"cd64a98b89de5fb2965e6f9833f6783e154fe971","unresolved":true,"context_lines":[{"line_number":33,"context_line":" * @param dst the address of the bitmap"},{"line_number":34,"context_line":" * @param nbits the number of bits to clear"},{"line_number":35,"context_line":" */"},{"line_number":36,"context_line":"static inline void bitmap_zero(unsigned long *dst, size_t nbits)"},{"line_number":37,"context_line":"{"},{"line_number":38,"context_line":"\tconst size_t len \u003d BITS_TO_LONGS(nbits) * sizeof(unsigned long);"},{"line_number":39,"context_line":"\tmemset(dst, 0, len);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"de71903b_730766f4","line":36,"range":{"start_line":36,"start_character":51,"end_line":36,"end_character":57},"updated":"2025-02-09 21:51:29.000000000","message":"Why `size_t`? This change doesn\u0027t seem necessary.\nAnd would promote abusing `size_t` where `unsigned int` should be","commit_id":"1e3b8b16d05a35128e7da70c118248ff008deed9"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"cd64a98b89de5fb2965e6f9833f6783e154fe971","unresolved":true,"context_lines":[{"line_number":35,"context_line":" */"},{"line_number":36,"context_line":"static inline void bitmap_zero(unsigned long *dst, size_t nbits)"},{"line_number":37,"context_line":"{"},{"line_number":38,"context_line":"\tconst size_t len \u003d BITS_TO_LONGS(nbits) * sizeof(unsigned long);"},{"line_number":39,"context_line":"\tmemset(dst, 0, len);"},{"line_number":40,"context_line":"}"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"984b8414_f6f804e4","line":38,"range":{"start_line":38,"start_character":1,"end_line":38,"end_character":6},"updated":"2025-02-09 21:51:29.000000000","message":"OMG! What is infomation value of `const` if the variable lifetime is just one short line of code and the variable is used only once? Just unnecessary noise, crap. Please reserve `const` for places where it means something and don\u0027t fill it to local vars here and there.\n\nBTW Why you didn\u0027t add `const` also to the function parameters?\n`static inline void bitmap_zero(unsigned long *const dst, const size_t nbits)`\nWouldn\u0027t it be better? I don\u0027t think so...\n\nAnd what about `0` in the memset call? Shouldn\u0027t we cast it to `(const int)0` to make sure it doesn\u0027t change?? Sounds silly, doesn\u0027t it...\n\nMaybe I\u0027m getting too old and this is the modern style of programming. But until I get paid for each one word I must read during the review, I don\u0027t want to read thousands of meaningless crap const","commit_id":"1e3b8b16d05a35128e7da70c118248ff008deed9"}]}