)]}'
{"id":"openocd~master~I91011490715998ef5a931c19c3c9d74a1a304e5d","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2025-03-10 09:05:27.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}},"1002047":{"account":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"last_update":"2025-03-15 10:19:45.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I91011490715998ef5a931c19c3c9d74a1a304e5d","subject":"helper/log: mark `fmt` argument of `alloc_vprintf()` as format string","status":"MERGED","created":"2025-02-17 17:48:09.000000000","updated":"2025-10-12 09:53:44.000000000","submitted":"2025-03-15 10:19:45.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":10,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8764","meta_rev_id":"dcc2a375c1c7ce3fe747aa800e27b3ff1a54e17b","_number":8764,"owner":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-03-15 10:19:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-03-15 10:19:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"}],"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-02-17 17:48:56.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-03-09 23:52:56.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2025-03-10 09:05:27.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2025-10-07 18:52:58.000000000","updated_by":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"reviewer":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"state":"CC"}],"messages":[{"id":"1cac4c8939f5d49b770d3e82410ae3ad54dd7e20","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2025-02-17 17:48:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"244b709129a6eba3b78862aeca3d316236f90d4e","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-02-17 17:48:56.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/19946/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit/20802/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"564a10f828752e68f1acddd9be26096c695b2d1e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2025-02-18 07:53:05.000000000","message":"Uploaded patch set 2: Commit message was updated.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"f0164a7133dd2ba6ff00a32adac90a25edafa7db","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-02-18 08:54:59.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/19951/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/20807/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"7fdcce6daa072a6775ea6c4217c38e8e9d6ed10c","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-03-09 23:52:56.000000000","message":"Patch Set 2:\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"3164360dcf3ba8e452866b64fab99f9f6969c72b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2025-03-10 08:42:13.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"fd76a2542613ec38c5b16235623283484f209631","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2025-03-10 08:46:12.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"283cb56647aeb8b9c6ef5129ad1dd71495c02272","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-03-10 09:05:27.000000000","message":"Patch Set 3: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"50316777eca9b8a54ac41b7b375a9ef671670a1c","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-03-10 09:06:00.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"47ec857a00930eb9576d486c88c013d25639aca6","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-03-10 09:52:13.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20037/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/20896/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"895608a65ac3179aa41c6810e72b601308c233d7","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-03-15 10:19:40.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"9cf9bf5f3650873e73deb5ca8e56fa82b2866fc4","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-03-15 10:19:45.000000000","message":"Change has been successfully cherry-picked as e12ceddd5ee4d946107e3764d05ce2810befb293","accounts_in_message":[],"_revision_number":4},{"id":"155b55e3af2c32da266db03d88e75dcb2cc51063","author":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"real_author":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"date":"2025-10-07 18:52:58.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"dcc2a375c1c7ce3fe747aa800e27b3ff1a54e17b","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-10-12 09:53:44.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4}],"current_revision":"e12ceddd5ee4d946107e3764d05ce2810befb293","revisions":{"e12ceddd5ee4d946107e3764d05ce2810befb293":{"kind":"REWORK","_number":4,"created":"2025-03-15 10:19:45.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/64/8764/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/64/8764/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/64/8764/4 \u0026\u0026 git checkout -b change-8764 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/64/8764/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/64/8764/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/64/8764/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/64/8764/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/64/8764/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a2d4b9b718552a4bbb88e0f210444b4f5047bc0c","subject":"bcm2835gpio.c: change adapter init order"}],"author":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2025-02-14 16:20:58.000000000","tz":180},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-03-15 10:19:45.000000000","tz":0},"subject":"helper/log: mark `fmt` argument of `alloc_vprintf()` as format string","message":"helper/log: mark `fmt` argument of `alloc_vprintf()` as format string\n\nBuilding on Ubuntu 22.04 with `-fsanitize\u003dundefined` (GCC 12.3.0)\nresults in an error:\nCheckpatch-ignore: COMMIT_LOG_LONG_LINE\n```\nIn file included from /usr/include/stdio.h:894,\n                 from \u003copenocd\u003e/src/helper/system.h:23,\n                 from \u003copenocd\u003e/src/helper/replacements.h:18,\n                 from \u003copenocd\u003e/src/helper/log.c:20:\nIn function ‘vsnprintf’,\n    inlined from ‘alloc_vprintf’ at \u003copenocd\u003e/src/helper/log.c:347:8:\n/usr/include/x86_64-linux-gnu/bits/stdio2.h:85:10: error: null format string [-Werror\u003dformat-truncation\u003d]\n   85 |   return __builtin___vsnprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,\n      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n   86 |                                     __glibc_objsize (__s), __fmt, __ap);\n      |                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\ncc1: all warnings being treated as errors\n```\n\nThe error mentiones the call site `src/helper/log.c:347`. There\n`vsnprintf()` is called passing `fmt` as format string.\n\nTo mitigate this, mark the format string with the corresponding\nattribute in `alloc_vprintf()`\n\nChange-Id: I91011490715998ef5a931c19c3c9d74a1a304e5d\nSigned-off-by: Evgeniy Naydanov \u003cevgeniy.naydanov@syntacore.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8764\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\n"}},"8e2ddaccdd8728a85f73f0c19e5b7aee08fe6933":{"kind":"REWORK","_number":1,"created":"2025-02-17 17:48:09.000000000","uploader":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"ref":"refs/changes/64/8764/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/64/8764/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/64/8764/1 \u0026\u0026 git checkout -b change-8764 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/64/8764/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/64/8764/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/64/8764/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/64/8764/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/64/8764/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1f3f635693a1ddc85f362dc324cb49c3e7b75f27","subject":"build: drop space after \u0027angie\u0027 folder name"}],"author":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2025-02-14 16:20:58.000000000","tz":180},"committer":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2025-02-17 17:48:00.000000000","tz":180},"subject":"helper/log: mark `fmt` argument of `alloc_vprintf()` as non-null","message":"helper/log: mark `fmt` argument of `alloc_vprintf()` as non-null\n\nBuilding on Ubuntu 22.04 with `-fsanitize\u003dundefined` (GCC 12.3.0)\nresults in an error:\n```\nIn file included from /usr/include/stdio.h:894,\n                 from /home/en-sc/openocd/src/helper/system.h:23,\n                 from /home/en-sc/openocd/src/helper/replacements.h:18,\n                 from /home/en-sc/openocd/src/helper/log.c:20:\nIn function ‘vsnprintf’,\n    inlined from ‘alloc_vprintf’ at /home/en-sc/openocd/src/helper/log.c:347:8:\n/usr/include/x86_64-linux-gnu/bits/stdio2.h:85:10: error: null format string [-Werror\u003dformat-truncation\u003d]\n   85 |   return __builtin___vsnprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,\n      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n   86 |                                     __glibc_objsize (__s), __fmt, __ap);\n      |                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\ncc1: all warnings being treated as errors\n```\n\nThe error mentiones the call site `src/helper/log.c:347`. There\n`vsnprintf()` is called passing `fmt` as format string.\n\nMark the format string as non-null in `alloc_vprintf()`.\n\nChange-Id: I91011490715998ef5a931c19c3c9d74a1a304e5d\nSigned-off-by: Evgeniy Naydanov \u003cevgeniy.naydanov@syntacore.com\u003e\n"}},"2d0f52dbca744fb738678a2f393761a9d9b43608":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2025-02-18 07:53:05.000000000","uploader":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"ref":"refs/changes/64/8764/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/64/8764/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/64/8764/2 \u0026\u0026 git checkout -b change-8764 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/64/8764/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/64/8764/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/64/8764/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/64/8764/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/64/8764/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1f3f635693a1ddc85f362dc324cb49c3e7b75f27","subject":"build: drop space after \u0027angie\u0027 folder name"}],"author":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2025-02-14 16:20:58.000000000","tz":180},"committer":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2025-02-18 07:51:43.000000000","tz":180},"subject":"helper/log: mark `fmt` argument of `alloc_vprintf()` as non-null","message":"helper/log: mark `fmt` argument of `alloc_vprintf()` as non-null\n\nBuilding on Ubuntu 22.04 with `-fsanitize\u003dundefined` (GCC 12.3.0)\nresults in an error:\nCheckpatch-ignore: COMMIT_LOG_LONG_LINE\n```\nIn file included from /usr/include/stdio.h:894,\n                 from \u003copenocd\u003e/src/helper/system.h:23,\n                 from \u003copenocd\u003e/src/helper/replacements.h:18,\n                 from \u003copenocd\u003e/src/helper/log.c:20:\nIn function ‘vsnprintf’,\n    inlined from ‘alloc_vprintf’ at \u003copenocd\u003e/src/helper/log.c:347:8:\n/usr/include/x86_64-linux-gnu/bits/stdio2.h:85:10: error: null format string [-Werror\u003dformat-truncation\u003d]\n   85 |   return __builtin___vsnprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,\n      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n   86 |                                     __glibc_objsize (__s), __fmt, __ap);\n      |                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\ncc1: all warnings being treated as errors\n```\n\nThe error mentiones the call site `src/helper/log.c:347`. There\n`vsnprintf()` is called passing `fmt` as format string.\n\nMark the format string as non-null in `alloc_vprintf()`.\n\nCheckpatch-ignore: SPACING\n(To allow the space after `__attribute__`).\nChange-Id: I91011490715998ef5a931c19c3c9d74a1a304e5d\nSigned-off-by: Evgeniy Naydanov \u003cevgeniy.naydanov@syntacore.com\u003e\n"}},"a29a087bf82df28f7e486507754d1b5bc4baf784":{"kind":"REWORK","_number":3,"created":"2025-03-10 08:42:13.000000000","uploader":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"ref":"refs/changes/64/8764/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/64/8764/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/64/8764/3 \u0026\u0026 git checkout -b change-8764 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/64/8764/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/64/8764/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/64/8764/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/64/8764/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/64/8764/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1f3f635693a1ddc85f362dc324cb49c3e7b75f27","subject":"build: drop space after \u0027angie\u0027 folder name"}],"author":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2025-02-14 16:20:58.000000000","tz":180},"committer":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2025-03-10 08:38:17.000000000","tz":180},"subject":"helper/log: mark `fmt` argument of `alloc_vprintf()` as format string","message":"helper/log: mark `fmt` argument of `alloc_vprintf()` as format string\n\nBuilding on Ubuntu 22.04 with `-fsanitize\u003dundefined` (GCC 12.3.0)\nresults in an error:\nCheckpatch-ignore: COMMIT_LOG_LONG_LINE\n```\nIn file included from /usr/include/stdio.h:894,\n                 from \u003copenocd\u003e/src/helper/system.h:23,\n                 from \u003copenocd\u003e/src/helper/replacements.h:18,\n                 from \u003copenocd\u003e/src/helper/log.c:20:\nIn function ‘vsnprintf’,\n    inlined from ‘alloc_vprintf’ at \u003copenocd\u003e/src/helper/log.c:347:8:\n/usr/include/x86_64-linux-gnu/bits/stdio2.h:85:10: error: null format string [-Werror\u003dformat-truncation\u003d]\n   85 |   return __builtin___vsnprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,\n      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n   86 |                                     __glibc_objsize (__s), __fmt, __ap);\n      |                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\ncc1: all warnings being treated as errors\n```\n\nThe error mentiones the call site `src/helper/log.c:347`. There\n`vsnprintf()` is called passing `fmt` as format string.\n\nTo mitigate this, mark the format string with the corresponding\nattribute in `alloc_vprintf()`\n\nChange-Id: I91011490715998ef5a931c19c3c9d74a1a304e5d\nSigned-off-by: Evgeniy Naydanov \u003cevgeniy.naydanov@syntacore.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}