)]}'
{"id":"openocd~master~Ib08ea55a38af4e15c4fbae95f10db0e3684ae1af","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002380":{"account":{"_account_id":1002380,"name":"Jim Paris","email":"jimparis@meta.com","username":"jimmeta","status":"Meta"},"last_update":"2025-03-01 15:12:36.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ib08ea55a38af4e15c4fbae95f10db0e3684ae1af","subject":"gdb_server: fix invalid free","status":"MERGED","created":"2025-02-21 20:02:30.000000000","updated":"2025-03-01 15:12:36.000000000","submitted":"2025-03-01 15:12:36.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8768","meta_rev_id":"4920cd0a6537e342a93e61fa619322386053746b","_number":8768,"owner":{"_account_id":1002380,"name":"Jim Paris","email":"jimparis@meta.com","username":"jimmeta","status":"Meta"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-03-01 15:12:36.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-03-01 15:12:36.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-03-01 15:12:36.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-02-21 20:10:03.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-02-21 20:40:37.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2025-03-01 15:12:30.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"dfcdebb44559e97692402469810152e6e02c6de8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002380,"name":"Jim Paris","email":"jimparis@meta.com","username":"jimmeta","status":"Meta"},"real_author":{"_account_id":1002380,"name":"Jim Paris","email":"jimparis@meta.com","username":"jimmeta","status":"Meta"},"date":"2025-02-21 20:02:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5e9f9b62f7adcebe22ebabb136378c3bbf90b8e2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002380,"name":"Jim Paris","email":"jimparis@meta.com","username":"jimmeta","status":"Meta"},"real_author":{"_account_id":1002380,"name":"Jim Paris","email":"jimparis@meta.com","username":"jimmeta","status":"Meta"},"date":"2025-02-21 20:09:47.000000000","message":"Uploaded patch set 2: New patch set was added with same tree, parent tree, and commit message as Patch Set 1.","accounts_in_message":[],"_revision_number":2},{"id":"68c7e370dc3dbf526517d05bdb0b13a4b1e83da0","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-02-21 20:10:03.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/19961/ : ABORTED\n\nhttps://build.openocd.org/job/openocd-gerrit/20819/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"1cfd579105030069f62772b0241814a508c2b26b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002380,"name":"Jim Paris","email":"jimparis@meta.com","username":"jimmeta","status":"Meta"},"real_author":{"_account_id":1002380,"name":"Jim Paris","email":"jimparis@meta.com","username":"jimmeta","status":"Meta"},"date":"2025-02-21 20:10:48.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"b13e03cdbb6930050b8a7ba7b058b761545246ed","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-02-21 20:10:51.000000000","message":"Patch Set 2: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/19962/ : ABORTED\n\nhttps://build.openocd.org/job/openocd-gerrit/20820/ : ABORTED","accounts_in_message":[],"_revision_number":2},{"id":"94c2740066a7325f03191c642de77ad58492a54c","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-02-21 20:23:14.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/19963/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/20821/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"ee8e892731b71adda71599e0427c244ce56f1533","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-02-21 20:40:37.000000000","message":"Patch Set 3: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"793143f6a141427809105e698b17b9f56ff6b537","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-03-01 15:12:30.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"4920cd0a6537e342a93e61fa619322386053746b","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-03-01 15:12:36.000000000","message":"Change has been successfully cherry-picked as accbeaed99bc6014d060259d6b0b0e080c0f44b4","accounts_in_message":[],"_revision_number":4}],"current_revision":"accbeaed99bc6014d060259d6b0b0e080c0f44b4","revisions":{"accbeaed99bc6014d060259d6b0b0e080c0f44b4":{"kind":"REWORK","_number":4,"created":"2025-03-01 15:12:36.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/68/8768/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/68/8768/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/68/8768/4 \u0026\u0026 git checkout -b change-8768 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/68/8768/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/68/8768/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/68/8768/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/68/8768/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/68/8768/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c986b4dbf2ff81753adcd0235954cfd577831672","subject":"tcl/target: add Bouffalo Lab BL602 and BL702L chip series support"}],"author":{"name":"Jim Paris","email":"jimparis@meta.com","date":"2025-02-21 17:33:45.000000000","tz":-300},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-03-01 15:12:36.000000000","tz":0},"subject":"gdb_server: fix invalid free","message":"gdb_server: fix invalid free\n\n`gdb_service_free` calls `free(gdb_port_next)`, so this needs to be an\nallocated string.  Otherwise we trip up detectors like Android\u0027s tagged\npointers.\n\nChange-Id: Ib08ea55a38af4e15c4fbae95f10db0e3684ae1af\nSigned-off-by: Jim Paris \u003cjimparis@meta.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8768\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\n"}},"83422f3b1acef914d391ce2cfd701c493b74e93d":{"kind":"REWORK","_number":1,"created":"2025-02-21 20:02:30.000000000","uploader":{"_account_id":1002380,"name":"Jim Paris","email":"jimparis@meta.com","username":"jimmeta","status":"Meta"},"ref":"refs/changes/68/8768/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/68/8768/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/68/8768/1 \u0026\u0026 git checkout -b change-8768 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/68/8768/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/68/8768/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/68/8768/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/68/8768/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/68/8768/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1f3f635693a1ddc85f362dc324cb49c3e7b75f27","subject":"build: drop space after \u0027angie\u0027 folder name"}],"author":{"name":"Jim Paris","email":"jimparis@meta.com","date":"2025-02-21 17:33:45.000000000","tz":-300},"committer":{"name":"Jim Paris","email":"jimparis@meta.com","date":"2025-02-21 17:33:45.000000000","tz":-300},"subject":"gdb_server: fix invalid free","message":"gdb_server: fix invalid free\n\n`gdb_service_free` calls `free(gdb_port_next)`, so this needs to be an\nallocated string.  Otherwise we trip up detectors like Android\u0027s tagged\npointers.\n\nChange-Id: Ib08ea55a38af4e15c4fbae95f10db0e3684ae1af\nSigned-off-by: Jim Paris \u003cjimparis@meta.com\u003e\n"}},"16ef60a13ef2823fcf40e4b48aaf06d62dff0d4c":{"kind":"REWORK","_number":3,"created":"2025-02-21 20:10:48.000000000","uploader":{"_account_id":1002380,"name":"Jim Paris","email":"jimparis@meta.com","username":"jimmeta","status":"Meta"},"ref":"refs/changes/68/8768/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/68/8768/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/68/8768/3 \u0026\u0026 git checkout -b change-8768 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/68/8768/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/68/8768/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/68/8768/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/68/8768/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/68/8768/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1f3f635693a1ddc85f362dc324cb49c3e7b75f27","subject":"build: drop space after \u0027angie\u0027 folder name"}],"author":{"name":"Jim Paris","email":"jimparis@meta.com","date":"2025-02-21 17:33:45.000000000","tz":-300},"committer":{"name":"Jim Paris","email":"jimparis@meta.com","date":"2025-02-21 20:10:44.000000000","tz":-300},"subject":"gdb_server: fix invalid free","message":"gdb_server: fix invalid free\n\n`gdb_service_free` calls `free(gdb_port_next)`, so this needs to be an\nallocated string.  Otherwise we trip up detectors like Android\u0027s tagged\npointers.\n\nChange-Id: Ib08ea55a38af4e15c4fbae95f10db0e3684ae1af\nSigned-off-by: Jim Paris \u003cjimparis@meta.com\u003e\n"}},"35696aa418bcf5dd388793cd0292a8036d03d88c":{"kind":"NO_CHANGE","_number":2,"created":"2025-02-21 20:09:47.000000000","uploader":{"_account_id":1002380,"name":"Jim Paris","email":"jimparis@meta.com","username":"jimmeta","status":"Meta"},"ref":"refs/changes/68/8768/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/68/8768/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/68/8768/2 \u0026\u0026 git checkout -b change-8768 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/68/8768/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/68/8768/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/68/8768/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/68/8768/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/68/8768/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1f3f635693a1ddc85f362dc324cb49c3e7b75f27","subject":"build: drop space after \u0027angie\u0027 folder name"}],"author":{"name":"Jim Paris","email":"jimparis@meta.com","date":"2025-02-21 17:33:45.000000000","tz":-300},"committer":{"name":"Jim Paris","email":"jimparis@meta.com","date":"2025-02-21 20:09:31.000000000","tz":-300},"subject":"gdb_server: fix invalid free","message":"gdb_server: fix invalid free\n\n`gdb_service_free` calls `free(gdb_port_next)`, so this needs to be an\nallocated string.  Otherwise we trip up detectors like Android\u0027s tagged\npointers.\n\nChange-Id: Ib08ea55a38af4e15c4fbae95f10db0e3684ae1af\nSigned-off-by: Jim Paris \u003cjimparis@meta.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}