)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"d05e2e3219bcb734618f4ff0998b3e5f02ab7843","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8fa27565_df681ca0","updated":"2025-02-25 21:28:32.000000000","message":"Thanks for your patch Henrik. I assume the driver worked before. Can you explain what you fixed exactly?\n\nJust a short review from my side.","commit_id":"227f8b66d260ad326c5be9e1d2521333e548e9cf"},{"author":{"_account_id":1002302,"name":"Henrik Mau","display_name":"Henrik Mau","email":"henrik.mau@analog.com","username":"hmauadi"},"change_message_id":"1fb136017ee2c6283539af3c20df9942d3773ca6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9a51efd1_767121a8","in_reply_to":"5e4dd59c_2a2dc260","updated":"2025-07-02 09:25:53.000000000","message":"Apologies, this ended up sitting in draft since March 6th as I forgot to press the reply button.","commit_id":"227f8b66d260ad326c5be9e1d2521333e548e9cf"},{"author":{"_account_id":1002302,"name":"Henrik Mau","display_name":"Henrik Mau","email":"henrik.mau@analog.com","username":"hmauadi"},"change_message_id":"70594b389b14e5391265d069aaf13742963398e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f00cc6b0_9267826c","in_reply_to":"8fa27565_df681ca0","updated":"2025-02-26 06:44:00.000000000","message":"Thank you for the review Marc, I\u0027ll get onto the requested changes next week.\n\nAs for what exactly was fixed I will try and get some more information on this.  I noticed that the driver currently in the repo wasn\u0027t working, but the one we have from Maxim does, so I replaced it with the working one after running it through the sanity checks.  Our internal commit log just mentions a new RAM algorithm being added.","commit_id":"227f8b66d260ad326c5be9e1d2521333e548e9cf"},{"author":{"_account_id":1002302,"name":"Henrik Mau","display_name":"Henrik Mau","email":"henrik.mau@analog.com","username":"hmauadi"},"change_message_id":"85df6da41724821a099c3afcbe07dd476c53e14f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5e4dd59c_2a2dc260","in_reply_to":"f00cc6b0_9267826c","updated":"2025-07-02 09:23:50.000000000","message":"I have addressed the issues you raised.\nUnfortunately I have not been able to find out why the driver we have from Maxim differs so much from the one that this patch replaces.  Essentially I don\u0027t have any history of the older one in our repo and have not been able to get a hold of the original author.\nThe new driver in this patch is the one that is being used by all the later MAX32xxx parts.  We intend to push up patches for those in the near future and they rely on this driver for flashing.","commit_id":"227f8b66d260ad326c5be9e1d2521333e548e9cf"},{"author":{"_account_id":1002302,"name":"Henrik Mau","display_name":"Henrik Mau","email":"henrik.mau@analog.com","username":"hmauadi"},"change_message_id":"1ee7c22a798a1deecddfe44d1fda75af73f714e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b3d22bd6_481b266c","updated":"2025-07-07 15:36:12.000000000","message":"Thanks for the feedback.  I have pushed up the requested changes.","commit_id":"aab5d166c6291d0b54b8a6c309079ef13745de52"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"fb8a956b51552ec7194a2017e79e36ed36f024af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cfb1b30a_ff53d5e0","updated":"2025-07-02 19:40:40.000000000","message":"Thanks for the update, I will try to perform a regression test with some older devices.","commit_id":"aab5d166c6291d0b54b8a6c309079ef13745de52"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"fd78b700e34e94ca093dca6ab39b29f734b8def2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a31a8b16_a8c4b5ca","updated":"2025-07-10 08:33:44.000000000","message":"Actually I cannot reproduce your flashing issues on a MAX32625. However, I also found no regression with your patch (tested flashing and erasing).","commit_id":"cf2ff78be620d73e94244dcac59ebab7146fe278"}],"src/flash/nor/max32xxx.c":[{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"d05e2e3219bcb734618f4ff0998b3e5f02ab7843","unresolved":true,"context_lines":[{"line_number":136,"context_line":"\treturn ERROR_OK;"},{"line_number":137,"context_line":"}"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"static int max32xxx_flash_busy(uint32_t flash_cn)"},{"line_number":140,"context_line":"{"},{"line_number":141,"context_line":"\tif (flash_cn \u0026 (FLC_CN_PGE | FLC_CN_ME | FLC_CN_WR))"},{"line_number":142,"context_line":"\t\treturn ERROR_FLASH_BUSY;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"31e80a66_4895a9cc","line":139,"updated":"2025-02-25 21:28:32.000000000","message":"Use \u0027bool\u0027 as return type or check the return value against `ERROR_xxx` #defines. I would prefer the former.","commit_id":"227f8b66d260ad326c5be9e1d2521333e548e9cf"},{"author":{"_account_id":1002302,"name":"Henrik Mau","display_name":"Henrik Mau","email":"henrik.mau@analog.com","username":"hmauadi"},"change_message_id":"85df6da41724821a099c3afcbe07dd476c53e14f","unresolved":false,"context_lines":[{"line_number":136,"context_line":"\treturn ERROR_OK;"},{"line_number":137,"context_line":"}"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"static int max32xxx_flash_busy(uint32_t flash_cn)"},{"line_number":140,"context_line":"{"},{"line_number":141,"context_line":"\tif (flash_cn \u0026 (FLC_CN_PGE | FLC_CN_ME | FLC_CN_WR))"},{"line_number":142,"context_line":"\t\treturn ERROR_FLASH_BUSY;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"1c788242_38e3d9e5","line":139,"in_reply_to":"31e80a66_4895a9cc","updated":"2025-07-02 09:23:50.000000000","message":"Ack","commit_id":"227f8b66d260ad326c5be9e1d2521333e548e9cf"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"d05e2e3219bcb734618f4ff0998b3e5f02ab7843","unresolved":true,"context_lines":[{"line_number":551,"context_line":"\t}"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"\tif (((info-\u003eoptions \u0026 OPTIONS_128) \u003d\u003d 0) \u0026\u0026 remaining \u003e\u003d 4) {"},{"line_number":554,"context_line":"\t\t/* write in 32-bit units*/"},{"line_number":555,"context_line":"\t\ttarget_read_u32(target, info-\u003eflc_base + FLC_CN, \u0026flash_cn);"},{"line_number":556,"context_line":"\t\tflash_cn |\u003d FLC_CN_32BIT;"},{"line_number":557,"context_line":"\t\ttarget_write_u32(target, info-\u003eflc_base + FLC_CN, flash_cn);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"653273ac_9925648e","line":554,"updated":"2025-02-25 21:28:32.000000000","message":"Use \u0027//\u0027 for single-line comments","commit_id":"227f8b66d260ad326c5be9e1d2521333e548e9cf"},{"author":{"_account_id":1002302,"name":"Henrik Mau","display_name":"Henrik Mau","email":"henrik.mau@analog.com","username":"hmauadi"},"change_message_id":"85df6da41724821a099c3afcbe07dd476c53e14f","unresolved":false,"context_lines":[{"line_number":551,"context_line":"\t}"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"\tif (((info-\u003eoptions \u0026 OPTIONS_128) \u003d\u003d 0) \u0026\u0026 remaining \u003e\u003d 4) {"},{"line_number":554,"context_line":"\t\t/* write in 32-bit units*/"},{"line_number":555,"context_line":"\t\ttarget_read_u32(target, info-\u003eflc_base + FLC_CN, \u0026flash_cn);"},{"line_number":556,"context_line":"\t\tflash_cn |\u003d FLC_CN_32BIT;"},{"line_number":557,"context_line":"\t\ttarget_write_u32(target, info-\u003eflc_base + FLC_CN, flash_cn);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"1587ec6e_af5c6a3a","line":554,"in_reply_to":"653273ac_9925648e","updated":"2025-07-02 09:23:50.000000000","message":"Ack","commit_id":"227f8b66d260ad326c5be9e1d2521333e548e9cf"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"d05e2e3219bcb734618f4ff0998b3e5f02ab7843","unresolved":true,"context_lines":[{"line_number":582,"context_line":"\t}"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"\tif ((info-\u003eoptions \u0026 OPTIONS_128) \u0026\u0026 remaining \u003e\u003d 16) {"},{"line_number":585,"context_line":"\t\t/* write in 128-bit units */"},{"line_number":586,"context_line":"\t\ttarget_read_u32(target, info-\u003eflc_base + FLC_CN, \u0026flash_cn);"},{"line_number":587,"context_line":"\t\tflash_cn \u0026\u003d ~(FLC_CN_32BIT);"},{"line_number":588,"context_line":"\t\ttarget_write_u32(target, info-\u003eflc_base + FLC_CN, flash_cn);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"25f1a2b8_0c9be495","line":585,"updated":"2025-02-25 21:28:32.000000000","message":"same","commit_id":"227f8b66d260ad326c5be9e1d2521333e548e9cf"},{"author":{"_account_id":1002302,"name":"Henrik Mau","display_name":"Henrik Mau","email":"henrik.mau@analog.com","username":"hmauadi"},"change_message_id":"85df6da41724821a099c3afcbe07dd476c53e14f","unresolved":false,"context_lines":[{"line_number":582,"context_line":"\t}"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"\tif ((info-\u003eoptions \u0026 OPTIONS_128) \u0026\u0026 remaining \u003e\u003d 16) {"},{"line_number":585,"context_line":"\t\t/* write in 128-bit units */"},{"line_number":586,"context_line":"\t\ttarget_read_u32(target, info-\u003eflc_base + FLC_CN, \u0026flash_cn);"},{"line_number":587,"context_line":"\t\tflash_cn \u0026\u003d ~(FLC_CN_32BIT);"},{"line_number":588,"context_line":"\t\ttarget_write_u32(target, info-\u003eflc_base + FLC_CN, flash_cn);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"540b3aa2_b71a02af","line":585,"in_reply_to":"25f1a2b8_0c9be495","updated":"2025-07-02 09:23:50.000000000","message":"Ack","commit_id":"227f8b66d260ad326c5be9e1d2521333e548e9cf"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"d05e2e3219bcb734618f4ff0998b3e5f02ab7843","unresolved":true,"context_lines":[{"line_number":666,"context_line":"\t\t\t\t\t  0xFF, 0xFF, 0xFF, 0xFF,"},{"line_number":667,"context_line":"\t\t\t\t\t  0xFF, 0xFF, 0xFF, 0xFF};"},{"line_number":668,"context_line":""},{"line_number":669,"context_line":"\t\tint i \u003d 0;"},{"line_number":670,"context_line":""},{"line_number":671,"context_line":"\t\twhile (remaining \u003e 0) {"},{"line_number":672,"context_line":"\t\t\tlast_words[i++] \u003d *buffer;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"22b4681a_0d440f3a","line":669,"updated":"2025-02-25 21:28:32.000000000","message":"Use `unsigned int` or `uint32_t`","commit_id":"227f8b66d260ad326c5be9e1d2521333e548e9cf"},{"author":{"_account_id":1002302,"name":"Henrik Mau","display_name":"Henrik Mau","email":"henrik.mau@analog.com","username":"hmauadi"},"change_message_id":"85df6da41724821a099c3afcbe07dd476c53e14f","unresolved":false,"context_lines":[{"line_number":666,"context_line":"\t\t\t\t\t  0xFF, 0xFF, 0xFF, 0xFF,"},{"line_number":667,"context_line":"\t\t\t\t\t  0xFF, 0xFF, 0xFF, 0xFF};"},{"line_number":668,"context_line":""},{"line_number":669,"context_line":"\t\tint i \u003d 0;"},{"line_number":670,"context_line":""},{"line_number":671,"context_line":"\t\twhile (remaining \u003e 0) {"},{"line_number":672,"context_line":"\t\t\tlast_words[i++] \u003d *buffer;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"da197866_7d218b55","line":669,"in_reply_to":"22b4681a_0d440f3a","updated":"2025-07-02 09:23:50.000000000","message":"Ack","commit_id":"227f8b66d260ad326c5be9e1d2521333e548e9cf"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"968c27e2690dd049d01b0435211b3b2359c21e59","unresolved":true,"context_lines":[{"line_number":101,"context_line":"};"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"static const uint8_t write_code_arm[] \u003d {"},{"line_number":104,"context_line":"#include \"contrib/loaders/flash/max32xxx/max32xxx_write_arm.inc\""},{"line_number":105,"context_line":"};"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"FLASH_BANK_COMMAND_HANDLER(max32xxx_flash_bank_command)"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"71c6087c_4266686f","line":104,"updated":"2025-07-02 22:24:29.000000000","message":"Building out-of-tree requires the relative path, so keep\n`#include \"../../../contrib/loaders/flash/max32xxx/max32xxx_write_arm.inc\"`\n\nStrange that Jenkins didn\u0027t triggered the build error. Maybe some patch has dropped the requirement on out-of-tree build.\nAnyway, all the other files in OpenOCD use the relative path, so please keep doing the same. We will eventually fix all them in one shot!","commit_id":"aab5d166c6291d0b54b8a6c309079ef13745de52"},{"author":{"_account_id":1002302,"name":"Henrik Mau","display_name":"Henrik Mau","email":"henrik.mau@analog.com","username":"hmauadi"},"change_message_id":"3333014680189c51ac667370e8a123a0bc87973e","unresolved":false,"context_lines":[{"line_number":101,"context_line":"};"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"static const uint8_t write_code_arm[] \u003d {"},{"line_number":104,"context_line":"#include \"contrib/loaders/flash/max32xxx/max32xxx_write_arm.inc\""},{"line_number":105,"context_line":"};"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"FLASH_BANK_COMMAND_HANDLER(max32xxx_flash_bank_command)"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"27354dbd_2901eb18","line":104,"in_reply_to":"71c6087c_4266686f","updated":"2025-07-07 15:37:15.000000000","message":"Done","commit_id":"aab5d166c6291d0b54b8a6c309079ef13745de52"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"968c27e2690dd049d01b0435211b3b2359c21e59","unresolved":true,"context_lines":[{"line_number":108,"context_line":"{"},{"line_number":109,"context_line":"\tstruct max32xxx_flash_bank *info;"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"\tif (CMD_ARGC \u003c 10 || CMD_ARGC \u003e 10) {"},{"line_number":112,"context_line":"\t\tLOG_ERROR(\"incorrect flash bank max32xxx configuration: \u003cbase\u003e \u003csize\u003e 0 0 \u003ctarget\u003e \u003cFLC base\u003e \u003csector size\u003e \u003cclkdiv\u003e \u003coptions\u003e\");"},{"line_number":113,"context_line":"\t\treturn ERROR_FLASH_BANK_INVALID;"},{"line_number":114,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"e9184f49_73cb8d0c","line":111,"updated":"2025-07-02 22:24:29.000000000","message":"Maybe `if (CMD_ARGC !\u003d 10) {` ?","commit_id":"aab5d166c6291d0b54b8a6c309079ef13745de52"},{"author":{"_account_id":1002302,"name":"Henrik Mau","display_name":"Henrik Mau","email":"henrik.mau@analog.com","username":"hmauadi"},"change_message_id":"3333014680189c51ac667370e8a123a0bc87973e","unresolved":false,"context_lines":[{"line_number":108,"context_line":"{"},{"line_number":109,"context_line":"\tstruct max32xxx_flash_bank *info;"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"\tif (CMD_ARGC \u003c 10 || CMD_ARGC \u003e 10) {"},{"line_number":112,"context_line":"\t\tLOG_ERROR(\"incorrect flash bank max32xxx configuration: \u003cbase\u003e \u003csize\u003e 0 0 \u003ctarget\u003e \u003cFLC base\u003e \u003csector size\u003e \u003cclkdiv\u003e \u003coptions\u003e\");"},{"line_number":113,"context_line":"\t\treturn ERROR_FLASH_BANK_INVALID;"},{"line_number":114,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"d8351228_8c176e92","line":111,"in_reply_to":"e9184f49_73cb8d0c","updated":"2025-07-07 15:37:15.000000000","message":"Done","commit_id":"aab5d166c6291d0b54b8a6c309079ef13745de52"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"968c27e2690dd049d01b0435211b3b2359c21e59","unresolved":true,"context_lines":[{"line_number":400,"context_line":"\t}"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"\tLOG_DEBUG(\"%s bank\u003d%p buffer\u003d%p offset\u003d%08\" PRIx32 \" len\u003d%08\" PRIx32 \"\","},{"line_number":403,"context_line":"\t\t__func__, bank, buffer, offset, len);"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"\t// flash write code"},{"line_number":406,"context_line":"\tif (target_alloc_working_area(target, write_code_size, \u0026write_algorithm) !\u003d ERROR_OK) {"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"582a50ad_2ffa9601","line":403,"updated":"2025-07-02 22:24:29.000000000","message":"This is a `LOG_DEBUG()` that when is enabled already prints the function name!\nWhy you add it?","commit_id":"aab5d166c6291d0b54b8a6c309079ef13745de52"},{"author":{"_account_id":1002302,"name":"Henrik Mau","display_name":"Henrik Mau","email":"henrik.mau@analog.com","username":"hmauadi"},"change_message_id":"1ee7c22a798a1deecddfe44d1fda75af73f714e8","unresolved":false,"context_lines":[{"line_number":400,"context_line":"\t}"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"\tLOG_DEBUG(\"%s bank\u003d%p buffer\u003d%p offset\u003d%08\" PRIx32 \" len\u003d%08\" PRIx32 \"\","},{"line_number":403,"context_line":"\t\t__func__, bank, buffer, offset, len);"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"\t// flash write code"},{"line_number":406,"context_line":"\tif (target_alloc_working_area(target, write_code_size, \u0026write_algorithm) !\u003d ERROR_OK) {"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"da1ae9ac_e03995c7","line":403,"in_reply_to":"582a50ad_2ffa9601","updated":"2025-07-07 15:36:12.000000000","message":"It was a leftover from the code that hadn\u0027t been updated to follow the current syntax and was inadvertently included in this PR.  I\u0027ve removed the superfluous __func__","commit_id":"aab5d166c6291d0b54b8a6c309079ef13745de52"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"968c27e2690dd049d01b0435211b3b2359c21e59","unresolved":true,"context_lines":[{"line_number":418,"context_line":"\t\t}"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"\t\tLOG_DEBUG(\"retry target_alloc_working_area(%s, size\u003d%u)\","},{"line_number":421,"context_line":"\t\t\ttarget_name(target), (unsigned int)buffer_size);"},{"line_number":422,"context_line":"\t}"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"\ttarget_write_buffer(target, write_algorithm-\u003eaddress, write_code_size,"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"78fbef91_b6127f3f","line":421,"updated":"2025-07-02 22:24:29.000000000","message":"No! the original code use the right format string to avoid the cast.\nPlease revert this code statement to the original version.","commit_id":"aab5d166c6291d0b54b8a6c309079ef13745de52"},{"author":{"_account_id":1002302,"name":"Henrik Mau","display_name":"Henrik Mau","email":"henrik.mau@analog.com","username":"hmauadi"},"change_message_id":"1ee7c22a798a1deecddfe44d1fda75af73f714e8","unresolved":false,"context_lines":[{"line_number":418,"context_line":"\t\t}"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"\t\tLOG_DEBUG(\"retry target_alloc_working_area(%s, size\u003d%u)\","},{"line_number":421,"context_line":"\t\t\ttarget_name(target), (unsigned int)buffer_size);"},{"line_number":422,"context_line":"\t}"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"\ttarget_write_buffer(target, write_algorithm-\u003eaddress, write_code_size,"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"aa0325c0_4f64126d","line":421,"in_reply_to":"78fbef91_b6127f3f","updated":"2025-07-07 15:36:12.000000000","message":"Reverted.","commit_id":"aab5d166c6291d0b54b8a6c309079ef13745de52"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"968c27e2690dd049d01b0435211b3b2359c21e59","unresolved":true,"context_lines":[{"line_number":499,"context_line":"\t}"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"\tLOG_DEBUG(\"%s bank\u003d%p buffer\u003d%p offset\u003d%08\" PRIx32 \" count\u003d%08\" PRIx32 \"\","},{"line_number":502,"context_line":"\t\t__func__, bank, buffer, offset, count);"},{"line_number":503,"context_line":""},{"line_number":504,"context_line":"\tif (!info-\u003eprobed)"},{"line_number":505,"context_line":"\t\treturn ERROR_FLASH_BANK_NOT_PROBED;"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"7d30ce43_177ccffb","line":502,"updated":"2025-07-02 22:24:29.000000000","message":"Also here, why printing the function name twice?","commit_id":"aab5d166c6291d0b54b8a6c309079ef13745de52"},{"author":{"_account_id":1002302,"name":"Henrik Mau","display_name":"Henrik Mau","email":"henrik.mau@analog.com","username":"hmauadi"},"change_message_id":"1ee7c22a798a1deecddfe44d1fda75af73f714e8","unresolved":false,"context_lines":[{"line_number":499,"context_line":"\t}"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"\tLOG_DEBUG(\"%s bank\u003d%p buffer\u003d%p offset\u003d%08\" PRIx32 \" count\u003d%08\" PRIx32 \"\","},{"line_number":502,"context_line":"\t\t__func__, bank, buffer, offset, count);"},{"line_number":503,"context_line":""},{"line_number":504,"context_line":"\tif (!info-\u003eprobed)"},{"line_number":505,"context_line":"\t\treturn ERROR_FLASH_BANK_NOT_PROBED;"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"ed9a8be2_907df8cf","line":502,"in_reply_to":"7d30ce43_177ccffb","updated":"2025-07-07 15:36:12.000000000","message":"As before inadvertently included.  Removed","commit_id":"aab5d166c6291d0b54b8a6c309079ef13745de52"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"968c27e2690dd049d01b0435211b3b2359c21e59","unresolved":true,"context_lines":[{"line_number":989,"context_line":"\tLOG_WARNING(\"s:\u003csector number\u003e a:\u003caddress\u003e p:\u003cprotection bit\u003e\");"},{"line_number":990,"context_line":"\tfor (unsigned int i \u003d 0; i \u003c bank-\u003enum_sectors; i +\u003d 4) {"},{"line_number":991,"context_line":"\t\tLOG_WARNING(\"s:%03d a:0x%06x p:%d | s:%03d a:0x%06x p:%d | s:%03d a:0x%06x p:%d | s:%03d a:0x%06x p:%d\","},{"line_number":992,"context_line":"\t\t\t(i + 0),"},{"line_number":993,"context_line":"\t\t\t(i + 0) * info-\u003esector_size,"},{"line_number":994,"context_line":"\t\t\tbank-\u003esectors[(i + 0)].is_protected,"},{"line_number":995,"context_line":"\t\t\t(i + 1),"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"0cae7f2b_fed8bae7","line":992,"updated":"2025-07-02 22:24:29.000000000","message":"I think it was way more readable in the formatting of the previous code.\nCan you revert the line split, while keep adding the space around the operators?","commit_id":"aab5d166c6291d0b54b8a6c309079ef13745de52"},{"author":{"_account_id":1002302,"name":"Henrik Mau","display_name":"Henrik Mau","email":"henrik.mau@analog.com","username":"hmauadi"},"change_message_id":"1ee7c22a798a1deecddfe44d1fda75af73f714e8","unresolved":false,"context_lines":[{"line_number":989,"context_line":"\tLOG_WARNING(\"s:\u003csector number\u003e a:\u003caddress\u003e p:\u003cprotection bit\u003e\");"},{"line_number":990,"context_line":"\tfor (unsigned int i \u003d 0; i \u003c bank-\u003enum_sectors; i +\u003d 4) {"},{"line_number":991,"context_line":"\t\tLOG_WARNING(\"s:%03d a:0x%06x p:%d | s:%03d a:0x%06x p:%d | s:%03d a:0x%06x p:%d | s:%03d a:0x%06x p:%d\","},{"line_number":992,"context_line":"\t\t\t(i + 0),"},{"line_number":993,"context_line":"\t\t\t(i + 0) * info-\u003esector_size,"},{"line_number":994,"context_line":"\t\t\tbank-\u003esectors[(i + 0)].is_protected,"},{"line_number":995,"context_line":"\t\t\t(i + 1),"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"f98004e0_49396ee0","line":992,"in_reply_to":"0cae7f2b_fed8bae7","updated":"2025-07-07 15:36:12.000000000","message":"Reverted line split and kept spacing between operators","commit_id":"aab5d166c6291d0b54b8a6c309079ef13745de52"}]}