)]}'
{"id":"openocd~master~Iec7f3d70237312b646ac58f76ecaab2fa25eab41","project":"openocd","branch":"master","hashtags":[],"change_id":"Iec7f3d70237312b646ac58f76ecaab2fa25eab41","subject":"list: silent scan-build false positive","status":"MERGED","created":"2025-04-05 15:50:37.000000000","updated":"2025-04-19 09:18:36.000000000","submitted":"2025-04-19 09:18:36.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8824","meta_rev_id":"71b38839e582fcb73969b59c88fc595c32e58fc6","_number":8824,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-04-19 09:18:36.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-04-19 09:18:36.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-04-05 17:13:43.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"0c62c2f14cc2f66e8700ecf4a7320fbfe3125480","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-04-05 15:50:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6fce5c7cf31d506683e38705ab1451f2ddd7bcad","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-04-05 17:13:43.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20145/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/21004/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"b42028a0dc93bf856237d248a820b5a04082ba95","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-04-19 09:18:33.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"71b38839e582fcb73969b59c88fc595c32e58fc6","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-04-19 09:18:36.000000000","message":"Change has been successfully cherry-picked as cfed1f78db635b504e4d11da537e614adfd57d3f","accounts_in_message":[],"_revision_number":2}],"current_revision":"cfed1f78db635b504e4d11da537e614adfd57d3f","revisions":{"cfed1f78db635b504e4d11da537e614adfd57d3f":{"kind":"REWORK","_number":2,"created":"2025-04-19 09:18:36.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/24/8824/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/24/8824/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/24/8824/2 \u0026\u0026 git checkout -b change-8824 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/24/8824/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/24/8824/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/24/8824/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/24/8824/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/24/8824/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"16c5c1b353b06602d81a8a81f5243154a6c366cc","subject":"command: rewrite command \u0027capture\u0027 as COMMAND_HANDLER"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-04-05 15:04:43.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-04-19 09:18:36.000000000","tz":0},"subject":"list: silent scan-build false positive","message":"list: silent scan-build false positive\n\nWith commit c023534e7b6f (\"target: use list for target events\")\nscan build incorrectly states that list_add() would be called with\nthe field \u0027next\u0027 of the parameter \u0027head\u0027 (thus \u0027head-\u003enext\u0027) set\nto NULL. Then, list_add() would call linux_list_add() with the\nparameter \u0027next\u0027 set to NULL that will cause a NULL dereference.\n\nWhile this can really happen with broken code, it\u0027s not the case\nwith the code from the change above.\n\nAdd assert() in linux_list_add() to silent scan build on this\nfalse positive and to detect future incorrect use of the list.\n\nChange-Id: Iec7f3d70237312b646ac58f76ecaab2fa25eab41\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8824\nTested-by: jenkins\n"}},"285fb90639af8c84e03359220ce64d4e6a6049f2":{"kind":"REWORK","_number":1,"created":"2025-04-05 15:50:37.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/24/8824/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/24/8824/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/24/8824/1 \u0026\u0026 git checkout -b change-8824 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/24/8824/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/24/8824/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/24/8824/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/24/8824/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/24/8824/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6834f022b96fb1c7f5829166578e01a0ac223cb0","subject":"Makefile.am: Use SOURCE_DATE_EPOCH environment variable"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-04-05 15:04:43.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-04-05 15:45:19.000000000","tz":120},"subject":"list: silent scan-build false positive","message":"list: silent scan-build false positive\n\nWith commit c023534e7b6f (\"target: use list for target events\")\nscan build incorrectly states that list_add() would be called with\nthe field \u0027next\u0027 of the parameter \u0027head\u0027 (thus \u0027head-\u003enext\u0027) set\nto NULL. Then, list_add() would call linux_list_add() with the\nparameter \u0027next\u0027 set to NULL that will cause a NULL dereference.\n\nWhile this can really happen with broken code, it\u0027s not the case\nwith the code from the change above.\n\nAdd assert() in linux_list_add() to silent scan build on this\nfalse positive and to detect future incorrect use of the list.\n\nChange-Id: Iec7f3d70237312b646ac58f76ecaab2fa25eab41\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}