)]}'
{"id":"openocd~master~I61a9303afe7fee6953669218330635c0b965b20d","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2025-04-19 09:21:17.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I61a9303afe7fee6953669218330635c0b965b20d","subject":"target: don\u0027t free working areas during \u0027configure -chain-position\u0027","status":"MERGED","created":"2025-04-06 09:39:22.000000000","updated":"2025-04-19 09:21:17.000000000","submitted":"2025-04-19 09:21:17.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8825","meta_rev_id":"ce401aa7ad0842a92c564693d00b22af305b5446","_number":8825,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-04-19 09:21:17.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-04-19 09:21:17.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-04-06 10:24:47.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-04-09 13:05:03.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"70a4cb60628f5782fca7bc505e184004ace1ad61","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-04-06 09:39:22.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d264abfe1327f7f28a254846411b6f57e0659ab5","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-04-06 10:24:47.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20147/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/21008/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"66fc063486e715d47b279cf2743d82dc46cfb59f","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-04-09 13:05:03.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"ce401aa7ad0842a92c564693d00b22af305b5446","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-04-19 09:21:17.000000000","message":"Change has been successfully cherry-picked as a1ecf0a03d9812c285618ed995ea818eba020be3","accounts_in_message":[],"_revision_number":2}],"current_revision":"a1ecf0a03d9812c285618ed995ea818eba020be3","revisions":{"c28b4c0594bd33e9c99e7972519f01cf92073aa4":{"kind":"REWORK","_number":1,"created":"2025-04-06 09:39:22.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/25/8825/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/25/8825/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/25/8825/1 \u0026\u0026 git checkout -b change-8825 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/25/8825/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/25/8825/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/25/8825/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/25/8825/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/25/8825/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6834f022b96fb1c7f5829166578e01a0ac223cb0","subject":"Makefile.am: Use SOURCE_DATE_EPOCH environment variable"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-04-05 23:20:44.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-04-05 23:30:35.000000000","tz":120},"subject":"target: don\u0027t free working areas during \u0027configure -chain-position\u0027","message":"target: don\u0027t free working areas during \u0027configure -chain-position\u0027\n\nSince commit ef1cfb23947b (\"Duane Ellis: \"target as an [tcl]\nobject\" feature.\") merged in 2008, the commands:\n\t$target_name configure -chain-position ...\n\ttarget create ... -chain-position ...\ncause the allocated working area to be freed.\n\nThere is no reason for this, it is probably caused by an incorrect\ncopy/paste from the author.\n\nDrop the call to target_free_all_working_areas().\n\nChange-Id: I61a9303afe7fee6953669218330635c0b965b20d\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"a1ecf0a03d9812c285618ed995ea818eba020be3":{"kind":"REWORK","_number":2,"created":"2025-04-19 09:21:17.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/25/8825/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/25/8825/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/25/8825/2 \u0026\u0026 git checkout -b change-8825 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/25/8825/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/25/8825/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/25/8825/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/25/8825/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/25/8825/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cfed1f78db635b504e4d11da537e614adfd57d3f","subject":"list: silent scan-build false positive"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-04-05 23:20:44.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-04-19 09:21:17.000000000","tz":0},"subject":"target: don\u0027t free working areas during \u0027configure -chain-position\u0027","message":"target: don\u0027t free working areas during \u0027configure -chain-position\u0027\n\nSince commit ef1cfb23947b (\"Duane Ellis: \"target as an [tcl]\nobject\" feature.\") merged in 2008, the commands:\n\t$target_name configure -chain-position ...\n\ttarget create ... -chain-position ...\ncause the allocated working area to be freed.\n\nThere is no reason for this, it is probably caused by an incorrect\ncopy/paste from the author.\n\nDrop the call to target_free_all_working_areas().\n\nChange-Id: I61a9303afe7fee6953669218330635c0b965b20d\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8825\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}