)]}'
{"id":"openocd~master~I537732fe4c08042cc02bcd0f72142254d7968fa6","project":"openocd","branch":"master","hashtags":[],"change_id":"I537732fe4c08042cc02bcd0f72142254d7968fa6","subject":"target: rewrite command \u0027invoke-event\u0027 as COMMAND_HANDLER","status":"MERGED","created":"2025-04-06 09:39:22.000000000","updated":"2025-04-19 09:21:56.000000000","submitted":"2025-04-19 09:21:56.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8826","meta_rev_id":"a9d2525938b5144d1c8e991f48396a0415d2fa2e","_number":8826,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-04-19 09:21:56.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-04-19 09:21:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-04-06 10:40:43.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"ae4776700699e925ac03a011e7edd8a90b8fa952","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-04-06 09:39:22.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"62ac406879795c65280ad80f027f61548b919601","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-04-06 10:40:43.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20148/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/21007/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"fe8ed0f1929e99e6336559d29040a0c86bdcbc13","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-04-19 09:21:50.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"a9d2525938b5144d1c8e991f48396a0415d2fa2e","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-04-19 09:21:56.000000000","message":"Change has been successfully cherry-picked as 4a616ca4d83919fea03bf084ff326f584de558d7","accounts_in_message":[],"_revision_number":2}],"current_revision":"4a616ca4d83919fea03bf084ff326f584de558d7","revisions":{"10b0c81d0e69d9d4c3d9d14837ee83870ae927a9":{"kind":"REWORK","_number":1,"created":"2025-04-06 09:39:22.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/26/8826/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/26/8826/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/26/8826/1 \u0026\u0026 git checkout -b change-8826 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/26/8826/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/26/8826/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/26/8826/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/26/8826/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/26/8826/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c28b4c0594bd33e9c99e7972519f01cf92073aa4","subject":"target: don\u0027t free working areas during \u0027configure -chain-position\u0027"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-12-02 17:40:47.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-04-05 23:30:46.000000000","tz":120},"subject":"target: rewrite command \u0027invoke-event\u0027 as COMMAND_HANDLER","message":"target: rewrite command \u0027invoke-event\u0027 as COMMAND_HANDLER\n\nThe command shares with command \u0027target create\u0027 the\n\tstruct jim_nvp nvp_target_event[]\n\n- Convert the \u0027struct jim_nvp\u0027 in \u0027struct nvp\u0027.\n- Create an alias \u0027struct jim_nvp\u0027 to decouple the commands\n  \u0027invoke-event\u0027 and \u0027target create\u0027, abusing the fact that the\n  actual layout of the two struct\u0027s type is the same. This alias\n  will be dropped in a following change.\n- Rewrite the command \u0027invoke-event\u0027 and the helper function\n  target_event_name().\n\nChange-Id: I537732fe4c08042cc02bcd0f72142254d7968fa6\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"4a616ca4d83919fea03bf084ff326f584de558d7":{"kind":"REWORK","_number":2,"created":"2025-04-19 09:21:56.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/26/8826/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/26/8826/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/26/8826/2 \u0026\u0026 git checkout -b change-8826 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/26/8826/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/26/8826/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/26/8826/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/26/8826/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/26/8826/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a1ecf0a03d9812c285618ed995ea818eba020be3","subject":"target: don\u0027t free working areas during \u0027configure -chain-position\u0027"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-12-02 17:40:47.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-04-19 09:21:56.000000000","tz":0},"subject":"target: rewrite command \u0027invoke-event\u0027 as COMMAND_HANDLER","message":"target: rewrite command \u0027invoke-event\u0027 as COMMAND_HANDLER\n\nThe command shares with command \u0027target create\u0027 the\n\tstruct jim_nvp nvp_target_event[]\n\n- Convert the \u0027struct jim_nvp\u0027 in \u0027struct nvp\u0027.\n- Create an alias \u0027struct jim_nvp\u0027 to decouple the commands\n  \u0027invoke-event\u0027 and \u0027target create\u0027, abusing the fact that the\n  actual layout of the two struct\u0027s type is the same. This alias\n  will be dropped in a following change.\n- Rewrite the command \u0027invoke-event\u0027 and the helper function\n  target_event_name().\n\nChange-Id: I537732fe4c08042cc02bcd0f72142254d7968fa6\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8826\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}