)]}'
{"id":"openocd~master~I7e5699ca6d124e34d3b2199714e3ce584bfcce80","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002047":{"account":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"last_update":"2025-04-19 09:22:42.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I7e5699ca6d124e34d3b2199714e3ce584bfcce80","subject":"target: rewrite function target_configure() as COMMAND_HELPER","status":"MERGED","created":"2025-04-06 09:39:22.000000000","updated":"2025-04-19 09:22:42.000000000","submitted":"2025-04-19 09:22:42.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8829","meta_rev_id":"9f6392e0b641e93e375d5feafdc878840df93a0e","_number":8829,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-04-19 09:22:42.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-04-19 09:22:42.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-04-06 09:47:01.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"state":"REVIEWER"},{"updated":"2025-04-06 11:23:01.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"4c762f87262b896de19885d1039a76dddf04e680","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-04-06 09:39:22.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b835572d19232e005f677ef3a18ab3285ba56fe0","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-04-06 11:23:01.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20151/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/21010/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"f0147ebbd613143ab89e97f32e23217a99d8d6d3","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-04-19 09:22:32.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"9f6392e0b641e93e375d5feafdc878840df93a0e","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-04-19 09:22:42.000000000","message":"Change has been successfully cherry-picked as 61890e3dc3201ce38e5af7f6b561389a123448e0","accounts_in_message":[],"_revision_number":2}],"current_revision":"61890e3dc3201ce38e5af7f6b561389a123448e0","revisions":{"61890e3dc3201ce38e5af7f6b561389a123448e0":{"kind":"REWORK","_number":2,"created":"2025-04-19 09:22:42.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/29/8829/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/29/8829/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/29/8829/2 \u0026\u0026 git checkout -b change-8829 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/29/8829/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/29/8829/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/29/8829/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/29/8829/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/29/8829/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1d9b34baa3c5087f2a3387523c6c556b4e4f1afb","subject":"target: rewrite commands \u0027configure\u0027 and \u0027cget\u0027 as COMMAND_HANDLER"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-12-03 14:41:27.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-04-19 09:22:42.000000000","tz":0},"subject":"target: rewrite function target_configure() as COMMAND_HELPER","message":"target: rewrite function target_configure() as COMMAND_HELPER\n\nThe function target_configure() is used by the commands\n\u0027target create\u0027, \u0027configure\u0027 and \u0027cget\u0027, already rewritten as\nCOMMAND_HANDLER.\n\nRewrite the common function as COMMAND_HELPER.\nWhile there:\n- fix the check on arguments, even if it should be coded better;\n- keep jimtcl code for target_type::target_jim_configure() and for\n  rtos_create(); these would be rewritten later on.\n\nChange-Id: I7e5699ca6d124e34d3b2199714e3ce584bfcce80\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8829\nTested-by: jenkins\n"}},"ad5f85cda4b70bc9037cb3ec8b277953edfb189a":{"kind":"REWORK","_number":1,"created":"2025-04-06 09:39:22.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/29/8829/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/29/8829/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/29/8829/1 \u0026\u0026 git checkout -b change-8829 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/29/8829/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/29/8829/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/29/8829/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/29/8829/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/29/8829/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"514fbe49b7f0ea2aadd95ed9cdac27366f04b6f1","subject":"target: rewrite commands \u0027configure\u0027 and \u0027cget\u0027 as COMMAND_HANDLER"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-12-03 14:41:27.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-04-06 09:28:06.000000000","tz":120},"subject":"target: rewrite function target_configure() as COMMAND_HELPER","message":"target: rewrite function target_configure() as COMMAND_HELPER\n\nThe function target_configure() is used by the commands\n\u0027target create\u0027, \u0027configure\u0027 and \u0027cget\u0027, already rewritten as\nCOMMAND_HANDLER.\n\nRewrite the common function as COMMAND_HELPER.\nWhile there:\n- fix the check on arguments, even if it should be coded better;\n- keep jimtcl code for target_type::target_jim_configure() and for\n  rtos_create(); these would be rewritten later on.\n\nChange-Id: I7e5699ca6d124e34d3b2199714e3ce584bfcce80\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}