)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"827867a99b9be5c07c1cd58cc15def379ad48a36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2f9194b7_6aae763e","updated":"2025-04-18 12:32:30.000000000","message":"Thanks!","commit_id":"5f142fa001e0ed349f75ca0658e6cc54840a23e5"}],"src/rtos/rtos.c":[{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"827867a99b9be5c07c1cd58cc15def379ad48a36","unresolved":true,"context_lines":[{"line_number":116,"context_line":"\t\treturn os_alloc(target, rtos_types[0]);"},{"line_number":117,"context_line":"\t}"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"\tfor (int x \u003d 0; rtos_types[x]; x++)"},{"line_number":120,"context_line":"\t\tif (strcmp(rtos_name, rtos_types[x]-\u003ename) \u003d\u003d 0)"},{"line_number":121,"context_line":"\t\t\treturn os_alloc_create(target, rtos_types[x]);"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"d4ffcccb_b7f25fc9","line":119,"updated":"2025-04-18 12:32:30.000000000","message":"Maybe \u0027size_t\u0027 instead of \u0027int\u0027?","commit_id":"5f142fa001e0ed349f75ca0658e6cc54840a23e5"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"f168ad5db853baa5243900055f4bec7c0f8d8610","unresolved":false,"context_lines":[{"line_number":116,"context_line":"\t\treturn os_alloc(target, rtos_types[0]);"},{"line_number":117,"context_line":"\t}"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"\tfor (int x \u003d 0; rtos_types[x]; x++)"},{"line_number":120,"context_line":"\t\tif (strcmp(rtos_name, rtos_types[x]-\u003ename) \u003d\u003d 0)"},{"line_number":121,"context_line":"\t\t\treturn os_alloc_create(target, rtos_types[x]);"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"f3f3db8b_2913da0e","line":119,"in_reply_to":"12bfa19a_1e6f0f53","updated":"2025-04-20 07:32:17.000000000","message":"\u003e I\u0027m even ok to report this in the coding style, maybe copying the \"usage note\" from https://www.gnu.org/software/libc/manual/html_node/Important-Data-Types.html\n\nYes, would be nice to have that in the coding style guide.\n\n\n\n\u003e If you agree, I will keep this patch as is and move the change s/int/size_t/ in next patch https://review.openocd.org/c/openocd/+/8855\n\nYep.\n\n\u003e What\u0027s your opinion on https://review.openocd.org/c/openocd/+/8750 ?\n\nI\u0027m not sure if `size_t` is suitable in this case, to be honest. But it seems we need *some* guideline for `const` :D","commit_id":"5f142fa001e0ed349f75ca0658e6cc54840a23e5"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"698cb20ac056a07c0c23c6bbdf36335bb32ccd6c","unresolved":true,"context_lines":[{"line_number":116,"context_line":"\t\treturn os_alloc(target, rtos_types[0]);"},{"line_number":117,"context_line":"\t}"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"\tfor (int x \u003d 0; rtos_types[x]; x++)"},{"line_number":120,"context_line":"\t\tif (strcmp(rtos_name, rtos_types[x]-\u003ename) \u003d\u003d 0)"},{"line_number":121,"context_line":"\t\t\treturn os_alloc_create(target, rtos_types[x]);"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"d6459fc2_3700b2ad","line":119,"in_reply_to":"d4ffcccb_b7f25fc9","updated":"2025-04-18 15:00:35.000000000","message":"Thanks for the review.\nI\u0027m even ok to report this in the coding style, maybe copying the \"usage note\" from\nhttps://www.gnu.org/software/libc/manual/html_node/Important-Data-Types.html\n\nWhat\u0027s your opinion on https://review.openocd.org/c/openocd/+/8750 ?","commit_id":"5f142fa001e0ed349f75ca0658e6cc54840a23e5"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a39b1d4b7c957a38bf43c12d4e32b69be9807068","unresolved":true,"context_lines":[{"line_number":116,"context_line":"\t\treturn os_alloc(target, rtos_types[0]);"},{"line_number":117,"context_line":"\t}"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"\tfor (int x \u003d 0; rtos_types[x]; x++)"},{"line_number":120,"context_line":"\t\tif (strcmp(rtos_name, rtos_types[x]-\u003ename) \u003d\u003d 0)"},{"line_number":121,"context_line":"\t\t\treturn os_alloc_create(target, rtos_types[x]);"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"12bfa19a_1e6f0f53","line":119,"in_reply_to":"d6459fc2_3700b2ad","updated":"2025-04-19 08:53:56.000000000","message":"If you agree, I will keep this patch as is and move the change s/int/size_t/ in next patch https://review.openocd.org/c/openocd/+/8855","commit_id":"5f142fa001e0ed349f75ca0658e6cc54840a23e5"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"827867a99b9be5c07c1cd58cc15def379ad48a36","unresolved":true,"context_lines":[{"line_number":121,"context_line":"\t\t\treturn os_alloc_create(target, rtos_types[x]);"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"\tchar *all \u003d NULL;"},{"line_number":124,"context_line":"\tfor (int x \u003d 0; rtos_types[x]; x++) {"},{"line_number":125,"context_line":"\t\tchar *prev \u003d all;"},{"line_number":126,"context_line":"\t\tif (all)"},{"line_number":127,"context_line":"\t\t\tall \u003d alloc_printf(\"%s, %s\", all, rtos_types[x]-\u003ename);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"c218ebc0_2eb8036c","line":124,"updated":"2025-04-18 12:32:30.000000000","message":"Same","commit_id":"5f142fa001e0ed349f75ca0658e6cc54840a23e5"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"f168ad5db853baa5243900055f4bec7c0f8d8610","unresolved":false,"context_lines":[{"line_number":121,"context_line":"\t\t\treturn os_alloc_create(target, rtos_types[x]);"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"\tchar *all \u003d NULL;"},{"line_number":124,"context_line":"\tfor (int x \u003d 0; rtos_types[x]; x++) {"},{"line_number":125,"context_line":"\t\tchar *prev \u003d all;"},{"line_number":126,"context_line":"\t\tif (all)"},{"line_number":127,"context_line":"\t\t\tall \u003d alloc_printf(\"%s, %s\", all, rtos_types[x]-\u003ename);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"f1e04a57_32d6dd71","line":124,"in_reply_to":"c218ebc0_2eb8036c","updated":"2025-04-20 07:32:17.000000000","message":"Done","commit_id":"5f142fa001e0ed349f75ca0658e6cc54840a23e5"}]}