)]}'
{"id":"openocd~master~I8beacc235ee781ab4e3b415fccad7b72ec55b098","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2025-04-17 07:41:50.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}},"1002399":{"account":{"_account_id":1002399,"name":"Chien Wong","email":"m@xv97.com","username":"ivq"},"last_update":"2025-05-09 12:08:39.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I8beacc235ee781ab4e3b415fccad7b72ec55b098","subject":"rtos/FreeRTOS: fix next pointer member offset in FreeRTOS lists","status":"MERGED","created":"2025-04-10 14:09:14.000000000","updated":"2025-05-09 12:08:39.000000000","submitted":"2025-05-09 12:08:39.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8833","meta_rev_id":"b09f318e698729d9f5f70a5202c84d2b79587690","_number":8833,"owner":{"_account_id":1002399,"name":"Chien Wong","email":"m@xv97.com","username":"ivq"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-05-09 12:08:39.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-05-09 12:08:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-04-10 14:16:34.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-04-16 21:41:30.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2025-04-17 07:41:50.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"28db4832f768784be01bd78a22d1c9c6781c155d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002399,"name":"Chien Wong","email":"m@xv97.com","username":"ivq"},"real_author":{"_account_id":1002399,"name":"Chien Wong","email":"m@xv97.com","username":"ivq"},"date":"2025-04-10 14:09:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6f9d03eedce5aa232933e1330dd7745015b9dfdb","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-04-10 14:16:34.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20158/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit/21017/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"8f195fbf4b248ee4276d5bee841e32d2d8a8f6b4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002399,"name":"Chien Wong","email":"m@xv97.com","username":"ivq"},"real_author":{"_account_id":1002399,"name":"Chien Wong","email":"m@xv97.com","username":"ivq"},"date":"2025-04-11 02:18:49.000000000","message":"Uploaded patch set 2: Commit message was updated.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"07e852da2d1b53bf624f9fc93e29745011fe9fd5","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-04-11 02:35:31.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20160/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/21019/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"21cad93688e4c42f9f7dc5009120e42adfe19ec5","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-04-16 21:41:30.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"1a9752e8c539246ed8d83eaa28033d4b4a0701b4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002399,"name":"Chien Wong","email":"m@xv97.com","username":"ivq"},"real_author":{"_account_id":1002399,"name":"Chien Wong","email":"m@xv97.com","username":"ivq"},"date":"2025-04-17 03:01:42.000000000","message":"Patch Set 3: Commit message was updated.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"6e0459e94a7f930618cec8c6893891b676dd452e","author":{"_account_id":1002399,"name":"Chien Wong","email":"m@xv97.com","username":"ivq"},"real_author":{"_account_id":1002399,"name":"Chien Wong","email":"m@xv97.com","username":"ivq"},"date":"2025-04-17 03:09:25.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"35c80a9bb5f002f96768e9216b060cb02440dcc7","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-04-17 07:41:50.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"90293c065c8a6c3c9e23683646ca6f6d5c2489b6","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-04-17 08:57:28.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/21022/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/20163/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"f07b803c284849f492483b2da977e4776fb0bc19","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-05-09 12:08:35.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"b09f318e698729d9f5f70a5202c84d2b79587690","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-05-09 12:08:39.000000000","message":"Change has been successfully cherry-picked as 3954896d6e41298efd74e8bb7af60ec49efae809","accounts_in_message":[],"_revision_number":4}],"current_revision":"3954896d6e41298efd74e8bb7af60ec49efae809","revisions":{"3954896d6e41298efd74e8bb7af60ec49efae809":{"kind":"REWORK","_number":4,"created":"2025-05-09 12:08:39.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/33/8833/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/33/8833/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/33/8833/4 \u0026\u0026 git checkout -b change-8833 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/33/8833/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/33/8833/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/33/8833/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/33/8833/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/33/8833/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3a879c7dcb718f7e575f5a35beeb42d0f67eaa85","subject":"rtos: rework rtos_types[] and rtos_try_next()"}],"author":{"name":"Chien Wong","email":"m@xv97.com","date":"2025-04-08 12:33:56.000000000","tz":480},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-05-09 12:08:39.000000000","tz":0},"subject":"rtos/FreeRTOS: fix next pointer member offset in FreeRTOS lists","message":"rtos/FreeRTOS: fix next pointer member offset in FreeRTOS lists\n\nCurrently, we are using offset of xListEnd.pxPrevious in List_t for\nlist_next_offset and offset of pxPrevious in ListItem_t for\nlist_elem_next_offset. This is confusing. Fix this.\nAs the related lists are doubly linked lists, only iteration order is\nchanged without breaking functionality.\nAlso document those offsets.\n\nChange-Id: I8beacc235ee781ab4e3b415fccad7b72ec55b098\nSigned-off-by: Chien Wong \u003cm@xv97.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8833\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\n"}},"d7bf1ec2ac328107dbe223e2bf1f18a769da3c8a":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2025-04-11 02:18:49.000000000","uploader":{"_account_id":1002399,"name":"Chien Wong","email":"m@xv97.com","username":"ivq"},"ref":"refs/changes/33/8833/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/33/8833/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/33/8833/2 \u0026\u0026 git checkout -b change-8833 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/33/8833/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/33/8833/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/33/8833/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/33/8833/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/33/8833/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6834f022b96fb1c7f5829166578e01a0ac223cb0","subject":"Makefile.am: Use SOURCE_DATE_EPOCH environment variable"}],"author":{"name":"Chien Wong","email":"m@xv97.com","date":"2025-04-08 12:33:56.000000000","tz":480},"committer":{"name":"Chien Wong","email":"m@xv97.com","date":"2025-04-11 02:17:06.000000000","tz":480},"subject":"rtos/FreeRTOS: fix next pointer member offset in FreeRTOS lists","message":"rtos/FreeRTOS: fix next pointer member offset in FreeRTOS lists\n\nCurrently, we are using offset of xListEnd.pxPrevious in List_t for\nlist_next_offset and offset of pxPrevious in ListItem_t for\nlist_elem_next_offset. This is confusing. Fix this.\nAs the ralated lists are doubly linked lists, only iteration order is\nchanged without breaking functionality.\nAlso document those offsets.\n\nChange-Id: I8beacc235ee781ab4e3b415fccad7b72ec55b098\nSigned-off-by: Chien Wong \u003cm@xv97.com\u003e\n"}},"02dba43379d92711e02494eea087a418ca61f3a9":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2025-04-17 03:01:42.000000000","uploader":{"_account_id":1002399,"name":"Chien Wong","email":"m@xv97.com","username":"ivq"},"ref":"refs/changes/33/8833/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/33/8833/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/33/8833/3 \u0026\u0026 git checkout -b change-8833 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/33/8833/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/33/8833/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/33/8833/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/33/8833/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/33/8833/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6834f022b96fb1c7f5829166578e01a0ac223cb0","subject":"Makefile.am: Use SOURCE_DATE_EPOCH environment variable"}],"author":{"name":"Chien Wong","email":"m@xv97.com","date":"2025-04-08 12:33:56.000000000","tz":480},"committer":{"name":"Chien Wong","email":"m@xv97.com","date":"2025-04-17 03:01:42.000000000","tz":0},"subject":"rtos/FreeRTOS: fix next pointer member offset in FreeRTOS lists","message":"rtos/FreeRTOS: fix next pointer member offset in FreeRTOS lists\n\nCurrently, we are using offset of xListEnd.pxPrevious in List_t for\nlist_next_offset and offset of pxPrevious in ListItem_t for\nlist_elem_next_offset. This is confusing. Fix this.\nAs the related lists are doubly linked lists, only iteration order is\nchanged without breaking functionality.\nAlso document those offsets.\n\nChange-Id: I8beacc235ee781ab4e3b415fccad7b72ec55b098\nSigned-off-by: Chien Wong \u003cm@xv97.com\u003e\n"},"description":"Edit commit message"},"76ef2bbe2fcc913a354bffde6284c71f98a36c02":{"kind":"REWORK","_number":1,"created":"2025-04-10 14:09:14.000000000","uploader":{"_account_id":1002399,"name":"Chien Wong","email":"m@xv97.com","username":"ivq"},"ref":"refs/changes/33/8833/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/33/8833/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/33/8833/1 \u0026\u0026 git checkout -b change-8833 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/33/8833/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/33/8833/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/33/8833/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/33/8833/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/33/8833/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6834f022b96fb1c7f5829166578e01a0ac223cb0","subject":"Makefile.am: Use SOURCE_DATE_EPOCH environment variable"}],"author":{"name":"Chien Wong","email":"m@xv97.com","date":"2025-04-08 12:33:56.000000000","tz":480},"committer":{"name":"Chien Wong","email":"m@xv97.com","date":"2025-04-10 14:08:26.000000000","tz":480},"subject":"rtos/FreeRTOS: fix next pointer member offset in FreeRTOS lists","message":"rtos/FreeRTOS: fix next pointer member offset in FreeRTOS lists\n\nCurrently, we are using offset of xListEnd.pxPrevious in List_t for list_next_offset\nand offset of pxPrevious in ListItem_t for list_elem_next_offset. This is\nconfusing. Fix this.\nAs the ralated lists are doubly linked lists, only iteration order is\nchanged without breaking functionality.\nAlso document those offsets.\n\nChange-Id: I8beacc235ee781ab4e3b415fccad7b72ec55b098\nSigned-off-by: Chien Wong \u003cm@xv97.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}