)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"18aea741c25d11ff9ddfac4cb7fc7a046c0cae06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"091c666c_482a5eb5","updated":"2025-04-28 20:11:32.000000000","message":"Looks reasonable, thanks!","commit_id":"4aae9356e4f041c537b856c5d99b0a04deebe684"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"ab4d1aaa9bcf88dec8a1d8cb1995ab52748fc343","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7f71c376_e525f13a","updated":"2025-04-28 20:51:08.000000000","message":"Not a blocker, just a minor issue:\nIt\u0027s a pity that the message\n`-chain-position ?name? required when creating target`\nis emitted even when a dap target type is given, e.g.\n`target create t cortex_m`\nbecause `target-\u003etype-\u003etarget_jim_configure` has not been called and therefore `target-\u003ehas_dap` has not been set. Any idea how to simply set `has_dap` when there is no config option?","commit_id":"4aae9356e4f041c537b856c5d99b0a04deebe684"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"62b2133baa80ce7ee782752ae10959a6096530ec","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3defb2f5_7f311f52","in_reply_to":"3231a976_a927dc56","updated":"2025-05-04 14:21:59.000000000","message":"By adding one more parameter, e.g.:\n`openocd -c \u0027target create t cortex_m -event halted {}\u0027`\nreturns\n`-dap ?name? required when creating target`\n\nIn `target_type::target_jim_configure()` we already set `has_dap` for Cortex-M.\nBut we don\u0027t enter in that function when the command line is empty.","commit_id":"4aae9356e4f041c537b856c5d99b0a04deebe684"},{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"311a648032ae5809c1db06702a4daed35cd4dd00","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3231a976_a927dc56","in_reply_to":"7f71c376_e525f13a","updated":"2025-04-29 14:33:20.000000000","message":"I\u0027d suggest to introduce a new function pointer to `struct target_type`, something like `target_type::set_defaults` and call it before processing options just after the `target-\u003etype` is assigned.","commit_id":"4aae9356e4f041c537b856c5d99b0a04deebe684"}]}