)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"50963c4288f8db69c729e053c6d93c0028088c57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3644c08b_e0c4522c","updated":"2025-04-28 20:57:25.000000000","message":"Thanks!","commit_id":"4a1e13279a19b3a915d4944916bdd6b6c573e6c7"}],"src/target/target.c":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"56ad54e46bd614be0baf9c1a6b0a999db59156fd","unresolved":true,"context_lines":[{"line_number":4924,"context_line":""},{"line_number":4925,"context_line":"\t\tcase TCFG_EVENT:"},{"line_number":4926,"context_line":"\t\t\tif (index \u003d\u003d CMD_ARGC) {"},{"line_number":4927,"context_line":"\t\t\t\tcommand_print(CMD, \"expecting %s event-name event-body\","},{"line_number":4928,"context_line":"\t\t\t\t\t\tCMD_ARGV[index - 1]);"},{"line_number":4929,"context_line":"\t\t\t\treturn ERROR_COMMAND_ARGUMENT_INVALID;"},{"line_number":4930,"context_line":"\t\t\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"3f70e956_2a86d7e2","line":4927,"range":{"start_line":4927,"start_character":34,"end_line":4927,"end_character":36},"updated":"2025-04-28 21:05:03.000000000","message":"Would not be safer and more readable to hard code `-event` string instead of getting it from already processed parameters?\nSame below.","commit_id":"4a1e13279a19b3a915d4944916bdd6b6c573e6c7"},{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"b4dd954492d0cb815a5ae37ad5502020a65cab70","unresolved":true,"context_lines":[{"line_number":4924,"context_line":""},{"line_number":4925,"context_line":"\t\tcase TCFG_EVENT:"},{"line_number":4926,"context_line":"\t\t\tif (index \u003d\u003d CMD_ARGC) {"},{"line_number":4927,"context_line":"\t\t\t\tcommand_print(CMD, \"expecting %s event-name event-body\","},{"line_number":4928,"context_line":"\t\t\t\t\t\tCMD_ARGV[index - 1]);"},{"line_number":4929,"context_line":"\t\t\t\treturn ERROR_COMMAND_ARGUMENT_INVALID;"},{"line_number":4930,"context_line":"\t\t\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"a5f307fd_def7ab0a","line":4927,"range":{"start_line":4927,"start_character":34,"end_line":4927,"end_character":36},"in_reply_to":"3f70e956_2a86d7e2","updated":"2025-04-29 13:55:16.000000000","message":"I do understand your concern with using `CMD_ARGV[index - ...]`.\nI\u0027ve presented an alternative solution in https://review.openocd.org/c/openocd/+/8862\nPlease, take a look.","commit_id":"4a1e13279a19b3a915d4944916bdd6b6c573e6c7"}]}