)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c40fbe275bfc5686ca1d3afc71eb02a0b52463f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"03779fea_b4ef8873","updated":"2025-05-01 16:18:49.000000000","message":"Thanks for this series, Marc.\n\nGerrit doesn\u0027t show correctly the files as moved, making the review heavier.\nI didn\u0027t found options in gerrit to show a better diff.\n\nLocally, gitk looks better for the moves, but then fails on the deprecated files.\n\nFrom review POW, it would be much easier if the series is re-organized as a patch that only \"moves\" the files in a new folder, then a patch that adds the deprecated files with the old name.\nWe partially loose the possibility to bisect, but we will more easily track the changes.\n\nAnd thinking to all the files that should be moved ... we cannot waste too much time for reviewing such rework","commit_id":"01539da37b19399004536152ac3047c9b80b67d5"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"a3860de6d0052b2761bba2d70d779a149f3e454f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c2b8b64a_7d0a2095","in_reply_to":"03779fea_b4ef8873","updated":"2025-05-12 06:07:49.000000000","message":"Thanks for the feedback Antonio! I hope the current series is now easier to review. I keep the board patches as the changes are very small.","commit_id":"01539da37b19399004536152ac3047c9b80b67d5"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"65e467a9f99778f2beb9bf572dc03921540c5e35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b26d0006_157e8021","in_reply_to":"12fc9d66_0bc73852","updated":"2025-05-12 08:26:35.000000000","message":"\u003e This time it\u0027s only 3 file, but we have other 413 files in tcl/boards/ that has to be replaced, probably. We cannot spend too much time in the review.\n\nFor these files I will split it, okay?","commit_id":"01539da37b19399004536152ac3047c9b80b67d5"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"78b68bd94e2d3d4cf52c0ecef81d3753adc4f0b5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"12fc9d66_0bc73852","in_reply_to":"c2b8b64a_7d0a2095","updated":"2025-05-12 08:08:30.000000000","message":"Thanks, much cleaner and easy to review.\nBut please, also for the board files it is better to split it in two patches.\nThis time it\u0027s only 3 file, but we have other 413 files in tcl/boards/ that has to be replaced, probably. We cannot spend too much time in the review.","commit_id":"01539da37b19399004536152ac3047c9b80b67d5"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"5cc9b74192422eadcc14ff1051fff89a08b7a8f1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4e264473_b82ae337","updated":"2025-05-21 07:41:43.000000000","message":"Marc, Antonio,\nif we move almost all config files we get lots of `deprecation` debris.\nWhat about extending OpenOCD error message `Can\u0027t find file.cfg` with a hint about the new config file structure instead of deprecating file by file?","commit_id":"efaaeacb71d790bb666bb6b9979a01f64f8c29b0"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"1570318d18704b5e823cc81271914a127fa7ed72","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"db117585_61c4216d","in_reply_to":"2b40a079_42aaa715","updated":"2025-06-07 09:08:20.000000000","message":"I think we can mark this as resolved, as the new 8929 addresses it","commit_id":"efaaeacb71d790bb666bb6b9979a01f64f8c29b0"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"4d1d37df085cb1b93b7a8752c40d461ef9d3e788","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ef8cf9f6_3d99d77a","in_reply_to":"4e264473_b82ae337","updated":"2025-05-21 07:49:40.000000000","message":"I\u0027m also fine with this approach and can adapt the changes. But let\u0027s move this forward ASAP and without lots of additional detours please. Since we\u0027re facing 1.0 release we also have the \u0027freedom\u0027 of breaking changes.","commit_id":"efaaeacb71d790bb666bb6b9979a01f64f8c29b0"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"c31467502ad960a79b82e0bdca2c3df4645f4ce8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2b40a079_42aaa715","in_reply_to":"77c76f95_c2f0f50c","updated":"2025-05-23 07:28:18.000000000","message":"@Tomas: the idea is quite nice, thanks! Just rebased my patches on #8929. This commit is not necessary anymore since the target files are simply moved into the `nordic` vendor folder.","commit_id":"efaaeacb71d790bb666bb6b9979a01f64f8c29b0"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"accc3e0b1eaed787dc83add5aa8acf8289834295","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"77c76f95_c2f0f50c","in_reply_to":"ef8cf9f6_3d99d77a","updated":"2025-05-21 13:23:46.000000000","message":"The idea from Tomas is not bad.\nIn `src/helper/startup.tcl` we have `proc find {filename}` that uses the command `ocd_find`. They are used in all the scripts as, e.g.:\n`source [find interface/stlink.cfg]`\nEither changing `proc find` or `ocd_find` can do the work, at least for simple replacements.\n\nI have pushed a preliminary patch https://review.openocd.org/c/openocd/+/8929\nlease have a look at it","commit_id":"efaaeacb71d790bb666bb6b9979a01f64f8c29b0"}]}