)]}'
{"id":"openocd~master~I3bbe04d99ad9b1288f55ba3c45e2e487aef9ae40","project":"openocd","branch":"master","hashtags":[],"change_id":"I3bbe04d99ad9b1288f55ba3c45e2e487aef9ae40","subject":"transport: fix incorrect statement","status":"MERGED","created":"2025-05-01 17:45:04.000000000","updated":"2025-05-09 12:10:05.000000000","submitted":"2025-05-09 12:10:05.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8868","meta_rev_id":"18c97e3e124fe920ca20c4c5a93e477ccbb6c1c5","_number":8868,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-05-09 12:10:05.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-05-09 12:10:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-05-01 18:14:07.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"9eea43bed5449430ea37f5c9949ed8e127b30c2a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-05-01 17:45:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fad133dfac6e1eda0714c0d8464b71a1850eedc8","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-05-01 17:47:17.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"997d949e7b431f154c71a54f8bb9c6eb0b436b35","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-05-01 18:14:07.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/21069/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/20210/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"18c97e3e124fe920ca20c4c5a93e477ccbb6c1c5","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-05-09 12:10:05.000000000","message":"Change has been successfully cherry-picked as 00f5b7ece6f031ece824375007e825ffc113e72b","accounts_in_message":[],"_revision_number":2}],"current_revision":"00f5b7ece6f031ece824375007e825ffc113e72b","revisions":{"00f5b7ece6f031ece824375007e825ffc113e72b":{"kind":"REWORK","_number":2,"created":"2025-05-09 12:10:05.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/68/8868/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/68/8868/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/68/8868/2 \u0026\u0026 git checkout -b change-8868 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/68/8868/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/68/8868/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/68/8868/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/68/8868/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/68/8868/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"06c827757b0c44bef5a15558a71ab666375cbb87","subject":"target: armv7a: use proper type for struct armv7a_cache_common::outer_cache"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-05-01 17:38:42.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-05-09 12:10:05.000000000","tz":0},"subject":"transport: fix incorrect statement","message":"transport: fix incorrect statement\n\nCommit 236208a5ff2d (\"transport: use a bitmask for the transport\")\nhas an incorrect C statement in place of a return.\nThe code is working thanks to the previous condition never true.\n\nThe issue has been detected by clang scan-build in OpenOCD ACI\nsince the missing return can make the following statement\ndereferencing a NULL pointer.\n\nFix it!\n\nChange-Id: I3bbe04d99ad9b1288f55ba3c45e2e487aef9ae40\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nFixes: 236208a5ff2d (\"transport: use a bitmask for the transport\")\nReviewed-on: https://review.openocd.org/c/openocd/+/8868\nTested-by: jenkins\n"}},"73cf0e3c902fae787ae25c57c3a100e78497b059":{"kind":"REWORK","_number":1,"created":"2025-05-01 17:45:04.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/68/8868/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/68/8868/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/68/8868/1 \u0026\u0026 git checkout -b change-8868 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/68/8868/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/68/8868/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/68/8868/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/68/8868/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/68/8868/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"afbd01b0a46f3a81fe6076c002ad66973dcfb64c","subject":"github/workflow: fix warnings for github actions"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-05-01 17:38:42.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-05-01 17:43:17.000000000","tz":120},"subject":"transport: fix incorrect statement","message":"transport: fix incorrect statement\n\nCommit 236208a5ff2d (\"transport: use a bitmask for the transport\")\nhas an incorrect C statement in place of a return.\nThe code is working thanks to the previous condition never true.\n\nThe issue has been detected by clang scan-build in OpenOCD ACI\nsince the missing return can make the following statement\ndereferencing a NULL pointer.\n\nFix it!\n\nChange-Id: I3bbe04d99ad9b1288f55ba3c45e2e487aef9ae40\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nFixes: 236208a5ff2d (\"transport: use a bitmask for the transport\")\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}