)]}'
{"id":"openocd~master~Iff1999de8c8e9a837055ba95714137aa03e68d4b","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2025-05-02 16:02:25.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}},"1001661":{"account":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"last_update":"2025-05-09 12:10:49.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Iff1999de8c8e9a837055ba95714137aa03e68d4b","subject":"target: cget command fix for result output","status":"MERGED","created":"2025-05-02 03:16:55.000000000","updated":"2025-05-09 12:10:49.000000000","submitted":"2025-05-09 12:10:49.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":7,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8870","meta_rev_id":"7a328f28754a418d1cad1e31e7ad775291494c1e","_number":8870,"owner":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-05-09 12:10:49.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-05-09 12:10:49.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-05-02 03:30:08.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-05-02 08:40:19.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2025-05-02 16:02:25.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"1357da85b2675bac88831809903aaed0d88bdfd5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"real_author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"date":"2025-05-02 03:16:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"746d61b96de0c6a66e377aba09bb877e8531e8e3","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-05-02 03:30:08.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20213/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit/21072/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"b37297ac2b85bc11ef5a3834041b942a78b22ef8","author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"real_author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"date":"2025-05-02 03:56:56.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"58b858f6c75859cea39b5b023473a4a56a0ff7ea","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-05-02 08:40:19.000000000","message":"Patch Set 1:\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"6abbbee393da431bdf6265801ace1a0a3e1df8a7","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-05-02 08:52:52.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/21073/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/20214/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"1af96afc83f6cb504a1b182d7939165fe515868d","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-05-02 08:54:57.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c61dccfabc73075a1ccc953bb6cff5c9db49c540","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"real_author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"date":"2025-05-02 13:56:45.000000000","message":"Uploaded patch set 2: Commit message was updated.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"1f8d56fef17ca0145c2a472cdae52191f3bcebb2","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-05-02 14:11:51.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/21074/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/20215/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"6deebf3ddb329266090d45a41e43a5170eb151aa","author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"real_author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"date":"2025-05-02 14:15:45.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"7c8112819ac28bd68bca9197c4beaf634daadf18","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-05-02 16:02:25.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"7a328f28754a418d1cad1e31e7ad775291494c1e","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-05-09 12:10:49.000000000","message":"Change has been successfully cherry-picked as d6c54b94941294628c5ebff5f9c776c4a7b2aebb","accounts_in_message":[],"_revision_number":3}],"current_revision":"d6c54b94941294628c5ebff5f9c776c4a7b2aebb","revisions":{"d6c54b94941294628c5ebff5f9c776c4a7b2aebb":{"kind":"REWORK","_number":3,"created":"2025-05-09 12:10:49.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/70/8870/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/70/8870/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/70/8870/3 \u0026\u0026 git checkout -b change-8870 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/70/8870/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/70/8870/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/70/8870/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/70/8870/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/70/8870/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"618e447278097e41daecf76f6a1e2005f9fc9450","subject":"tcl: board: convert transport select dapdirect_swd to swd"}],"author":{"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","date":"2025-05-01 02:38:15.000000000","tz":-240},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-05-09 12:10:49.000000000","tz":0},"subject":"target: cget command fix for result output","message":"target: cget command fix for result output\n\nFunction target_configure() when processing a \"cget\" command needs\nto print the result to the console. Currently the result is only printed\nwhen an error occurs. To fix this, move the command print statement from\nthe error handling section to the common code section.\n\nThe code was tested by executing a \"$target_name cget -dap\" command\nand reviewing the result.\n\nChange-Id: Iff1999de8c8e9a837055ba95714137aa03e68d4b\nSigned-off-by: Daniel Goehring \u003cdgoehrin@os.amperecomputing.com\u003e\nFixes: 61890e3dc320 (\"target: rewrite function target_configure() as COMMAND_HELPER\")\nReviewed-on: https://review.openocd.org/c/openocd/+/8870\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"7f01ce33b461a8053252d6d7a5d2fc74f4d4907d":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2025-05-02 13:56:45.000000000","uploader":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"ref":"refs/changes/70/8870/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/70/8870/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/70/8870/2 \u0026\u0026 git checkout -b change-8870 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/70/8870/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/70/8870/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/70/8870/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/70/8870/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/70/8870/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"afbd01b0a46f3a81fe6076c002ad66973dcfb64c","subject":"github/workflow: fix warnings for github actions"}],"author":{"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","date":"2025-05-01 02:38:15.000000000","tz":-240},"committer":{"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","date":"2025-05-02 13:54:40.000000000","tz":-360},"subject":"target: cget command fix for result output","message":"target: cget command fix for result output\n\nFunction target_configure() when processing a \"cget\" command needs\nto print the result to the console. Currently the result is only printed\nwhen an error occurs. To fix this, move the command print statement from\nthe error handling section to the common code section.\n\nThe code was tested by executing a \"$target_name cget -dap\" command\nand reviewing the result.\n\nChange-Id: Iff1999de8c8e9a837055ba95714137aa03e68d4b\nSigned-off-by: Daniel Goehring \u003cdgoehrin@os.amperecomputing.com\u003e\nFixes: 61890e3dc320 (\"target: rewrite function target_configure() as COMMAND_HELPER\")\n"}},"5937b35a8a17fbdb9c3dd277a3fae1507a4cc6ed":{"kind":"REWORK","_number":1,"created":"2025-05-02 03:16:55.000000000","uploader":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"ref":"refs/changes/70/8870/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/70/8870/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/70/8870/1 \u0026\u0026 git checkout -b change-8870 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/70/8870/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/70/8870/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/70/8870/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/70/8870/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/70/8870/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"afbd01b0a46f3a81fe6076c002ad66973dcfb64c","subject":"github/workflow: fix warnings for github actions"}],"author":{"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","date":"2025-05-01 02:38:15.000000000","tz":-240},"committer":{"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","date":"2025-05-02 01:24:25.000000000","tz":-360},"subject":"target: cget command fix for result output","message":"target: cget command fix for result output\n\nFunction target_configure() when processing a \"cget\" command needs\nto print the result to the console. Currently the result is only printed\nwhen an error occurs. To fix this, move the command print statement from\nthe error handling section to the common code section.\n\nThe code was tested by executing a \"$target_name cget -dap\" command\nand reviewing the result.\n\nChange-Id: Iff1999de8c8e9a837055ba95714137aa03e68d4b\nSigned-off-by: Daniel Goehring \u003cdgoehrin@os.amperecomputing.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}
