)]}'
{"id":"openocd~master~I44621ac6096791714910220d04614d0a19ce47bd","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002410":{"account":{"_account_id":1002410,"name":"Ivan","display_name":"kryvosheia","email":"Ivan.Kryvosheia@infineon.com","username":"kryvosheiaivan","status":"employer"},"last_update":"2025-06-13 16:27:37.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I44621ac6096791714910220d04614d0a19ce47bd","subject":"cmsis-dap: Fix freeing pending transfers on close","status":"MERGED","created":"2025-05-28 15:13:06.000000000","updated":"2025-06-13 16:27:37.000000000","submitted":"2025-06-13 16:27:37.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8876","meta_rev_id":"fa44d08e4dcb98be2ef670dc9e57b92c64654d09","_number":8876,"owner":{"_account_id":1002410,"name":"Ivan","display_name":"kryvosheia","email":"Ivan.Kryvosheia@infineon.com","username":"kryvosheiaivan","status":"employer"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-06-13 16:27:37.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-06-13 16:27:37.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-06-13 16:27:37.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-05-28 15:13:54.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-06-03 09:38:26.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2025-06-13 16:27:31.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"756b024d69a00d585c0d336fd52473a48e369c78","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002410,"name":"Ivan","display_name":"kryvosheia","email":"Ivan.Kryvosheia@infineon.com","username":"kryvosheiaivan","status":"employer"},"real_author":{"_account_id":1002410,"name":"Ivan","display_name":"kryvosheia","email":"Ivan.Kryvosheia@infineon.com","username":"kryvosheiaivan","status":"employer"},"date":"2025-05-28 15:13:06.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0d51637aeb792ae3172d23cee6e724d078f2c824","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-05-28 15:13:54.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20386/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit/21247/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"97771d1d43c6e6178b65a47c1d705245e5b84a83","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002410,"name":"Ivan","display_name":"kryvosheia","email":"Ivan.Kryvosheia@infineon.com","username":"kryvosheiaivan","status":"employer"},"real_author":{"_account_id":1002410,"name":"Ivan","display_name":"kryvosheia","email":"Ivan.Kryvosheia@infineon.com","username":"kryvosheiaivan","status":"employer"},"date":"2025-05-29 15:34:20.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"b8035b3a9fd1f5745656ebcc4257ecfc783b0c1e","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-05-29 16:03:00.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20409/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/21272/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"76085e94c46462b63b732925a3361d1ddb61c7c9","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-06-03 09:38:26.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"80a9ea688149e317f181e2129c71e24a751e7a48","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-06-13 16:27:31.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"fa44d08e4dcb98be2ef670dc9e57b92c64654d09","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-06-13 16:27:37.000000000","message":"Change has been successfully cherry-picked as 8046f2a38f8af0048c0d2d0842b8a708b79c0c57","accounts_in_message":[],"_revision_number":3}],"current_revision":"8046f2a38f8af0048c0d2d0842b8a708b79c0c57","revisions":{"e6ad7d7ad58c47e86c0110429bed785230435141":{"kind":"REWORK","_number":1,"created":"2025-05-28 15:13:06.000000000","uploader":{"_account_id":1002410,"name":"Ivan","display_name":"kryvosheia","email":"Ivan.Kryvosheia@infineon.com","username":"kryvosheiaivan","status":"employer"},"ref":"refs/changes/76/8876/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/76/8876/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/76/8876/1 \u0026\u0026 git checkout -b change-8876 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/76/8876/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/76/8876/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/76/8876/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/76/8876/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/76/8876/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4fe57a0c197158958c7cc295002504d6434d4777","subject":"server: gdb_server: use a macro for CTRL-C value"}],"author":{"name":"kryvosheiaivan","email":"Ivan.Kryvosheia@infineon.com","date":"2025-05-28 13:52:42.000000000","tz":180},"committer":{"name":"kryvosheiaivan","email":"Ivan.Kryvosheia@infineon.com","date":"2025-05-28 15:12:54.000000000","tz":180},"subject":"Fix pending transfer","message":"Fix pending transfer\n\nChange-Id: I44621ac6096791714910220d04614d0a19ce47bd\nSigned-off-by: kryvosheiaivan \u003cIvan.Kryvosheia@infineon.com\u003e\n"}},"8046f2a38f8af0048c0d2d0842b8a708b79c0c57":{"kind":"REWORK","_number":3,"created":"2025-06-13 16:27:37.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/76/8876/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/76/8876/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/76/8876/3 \u0026\u0026 git checkout -b change-8876 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/76/8876/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/76/8876/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/76/8876/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/76/8876/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/76/8876/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"207ecaab33b985b16a067fc2c054a4f2cc161dc3","subject":"adapter: Deprecate Gateworks GW16012 driver"}],"author":{"name":"kryvosheiaivan","email":"Ivan.Kryvosheia@infineon.com","date":"2025-05-28 13:52:42.000000000","tz":180},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-06-13 16:27:37.000000000","tz":0},"subject":"cmsis-dap: Fix freeing pending transfers on close","message":"cmsis-dap: Fix freeing pending transfers on close\n\nFreeing pending transfers on shutdown is done in openOCD\nand on libusb side. This created concurrency in freeing\nmemory and segmentation faults:\nhttps://github.com/libusb/libusb/issues/1627\nBug is reproduced better if many targets are laucnhed.\nBug was reproduced with CMSIS-DAP on targets:\ncyw20829, psoc4, stm32l5 if launching multiple times.\nProposed working fix: if some transfers pending/in-flight\non \u0027shutdown\u0027 then apply libusb_handle_events_timeout_completed()\nto make transfer complete. In all cases transfer completed\ndue to tests.\n\nChange-Id: I44621ac6096791714910220d04614d0a19ce47bd\nSigned-off-by: kryvosheiaivan \u003cIvan.Kryvosheia@infineon.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8876\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"146b92622167828a63db3411facfe1617bff1c08":{"kind":"REWORK","_number":2,"created":"2025-05-29 15:34:20.000000000","uploader":{"_account_id":1002410,"name":"Ivan","display_name":"kryvosheia","email":"Ivan.Kryvosheia@infineon.com","username":"kryvosheiaivan","status":"employer"},"ref":"refs/changes/76/8876/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/76/8876/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/76/8876/2 \u0026\u0026 git checkout -b change-8876 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/76/8876/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/76/8876/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/76/8876/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/76/8876/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/76/8876/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4fe57a0c197158958c7cc295002504d6434d4777","subject":"server: gdb_server: use a macro for CTRL-C value"}],"author":{"name":"kryvosheiaivan","email":"Ivan.Kryvosheia@infineon.com","date":"2025-05-28 13:52:42.000000000","tz":180},"committer":{"name":"kryvosheiaivan","email":"Ivan.Kryvosheia@infineon.com","date":"2025-05-29 15:18:41.000000000","tz":180},"subject":"cmsis-dap: Fix freeing pending transfers on close","message":"cmsis-dap: Fix freeing pending transfers on close\n\nFreeing pending transfers on shutdown is done in openOCD\nand on libusb side. This created concurrency in freeing\nmemory and segmentation faults:\nhttps://github.com/libusb/libusb/issues/1627\nBug is reproduced better if many targets are laucnhed.\nBug was reproduced with CMSIS-DAP on targets:\ncyw20829, psoc4, stm32l5 if launching multiple times.\nProposed working fix: if some transfers pending/in-flight\non \u0027shutdown\u0027 then apply libusb_handle_events_timeout_completed()\nto make transfer complete. In all cases transfer completed\ndue to tests.\n\nChange-Id: I44621ac6096791714910220d04614d0a19ce47bd\nSigned-off-by: kryvosheiaivan \u003cIvan.Kryvosheia@infineon.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}