)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9f4738e3fca631524f9007aae4a2a21aec40bcd0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b550534f_3a31ec76","updated":"2025-06-03 07:44:43.000000000","message":"I think there is a minor problem, please check my comments below.\n\nFor your future development in OpenOCD and for next version of this patch, do not abandon the old patch but send the new patch keeping the same Change-Id in the commit message. Gerrit will understand it is a new version and will keep the history.\nI see this is not explained in HACKING ... our fault! Let me try to fix it!","commit_id":"d0ae4b24ed2f85cdb6cacaafcbebde4eca8523c4"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f78af42a73fcdd5893ad53a4c56be2e5eda59a58","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2ccd3808_4db3e0bf","updated":"2025-06-04 12:23:49.000000000","message":"Forgot, we need some documentation.\nI have added a comment in one of the possible places for its addition","commit_id":"5ab76c91701c6c08e16cc52c0aca007334e30800"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b7e68a9de30d8067fc3e1d6bbc550277973f8a0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b323e4ed_2d5675a0","updated":"2025-06-04 12:18:14.000000000","message":"Ok for me. Thanks!\nMarc?","commit_id":"5ab76c91701c6c08e16cc52c0aca007334e30800"},{"author":{"_account_id":1002407,"name":"Vitaly Cheptsov","email":"vit9696@protonmail.com","username":"vit9696"},"change_message_id":"bb268e607f2e015c507697dc2e5b89cad1ce82b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"06ea7b72_f3e3fc2f","updated":"2025-06-03 09:31:35.000000000","message":"Should be fixed, thanks.","commit_id":"5ab76c91701c6c08e16cc52c0aca007334e30800"},{"author":{"_account_id":1002407,"name":"Vitaly Cheptsov","email":"vit9696@protonmail.com","username":"vit9696"},"change_message_id":"fedceccd17c297f5da3e3c249b261314d515b698","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4a0ca1ed_4a75c637","updated":"2025-06-05 11:41:30.000000000","message":"Yeah, sorry, did not realise there could be a better clarification in the docs. Fixed.","commit_id":"5ab76c91701c6c08e16cc52c0aca007334e30800"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"334f22775bf59fb5b68263e8591dea3e8131c33b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b858ff98_8d953e22","updated":"2025-06-13 16:24:20.000000000","message":"Marc, any comment here?","commit_id":"9e0d48e42fd5a9178c2e4d3d079c842da974d149"},{"author":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"886f2f755cfb733963d96199f5a206a4e076d0ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3a8a0eff_44e66556","updated":"2025-06-16 20:55:46.000000000","message":"Tested and works as expected, thanks. Please fix the code, afterwards we can merge it.","commit_id":"9e0d48e42fd5a9178c2e4d3d079c842da974d149"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a67acc5d0ec58571bf7d6da898ac7813ea43c978","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"07f846cb_61e8fd50","updated":"2025-06-05 12:43:23.000000000","message":"Thanks!","commit_id":"9e0d48e42fd5a9178c2e4d3d079c842da974d149"},{"author":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"1788b2279edfa0af944920e17e56cb7e3d673321","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d9a4a5c6_30b79fd5","in_reply_to":"b858ff98_8d953e22","updated":"2025-06-14 08:55:01.000000000","message":"Yep, please give me some time to test this properly with some different J-Link devices.","commit_id":"9e0d48e42fd5a9178c2e4d3d079c842da974d149"},{"author":{"_account_id":1002407,"name":"Vitaly Cheptsov","email":"vit9696@protonmail.com","username":"vit9696"},"change_message_id":"8d5be9e9fcf596cf196e9ae81fca8a953b919186","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0fb76752_b17b0619","updated":"2025-06-16 21:50:05.000000000","message":"Done :)","commit_id":"22dac58fb2730759de3c7e1fe7a61a77a1f98936"},{"author":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"bd67e43880ca8e4e6c15338c62101f9b7f957762","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"24ccf063_4f2a8d0c","in_reply_to":"0fb76752_b17b0619","updated":"2025-06-17 06:31:09.000000000","message":"Thanks.","commit_id":"22dac58fb2730759de3c7e1fe7a61a77a1f98936"}],"doc/openocd.texi":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f78af42a73fcdd5893ad53a4c56be2e5eda59a58","unresolved":true,"context_lines":[{"line_number":2499,"context_line":"Only the following adapter drivers use the serial string from this command:"},{"line_number":2500,"context_line":"arm-jtag-ew, cmsis_dap, esp_usb_jtag, ft232r, ftdi, hla (stlink, ti-icdi), jlink, kitprog, opendus,"},{"line_number":2501,"context_line":"openjtag, osbdm, presto, rlink, st-link, usb_blaster (ublast2), usbprog, vsllink, xds110."},{"line_number":2502,"context_line":"@end deffn"},{"line_number":2503,"context_line":""},{"line_number":2504,"context_line":"@section Interface Drivers"},{"line_number":2505,"context_line":""}],"source_content_type":"text/x-texinfo","patch_set":2,"id":"5112a942_80aa83bb","line":2502,"updated":"2025-06-04 12:23:49.000000000","message":"Please add here something like:\n```\nFor jlink adapters, the @var{serial_string} is also compared\nagainst the adapter\u0027s nickname.\n```","commit_id":"5ab76c91701c6c08e16cc52c0aca007334e30800"},{"author":{"_account_id":1002407,"name":"Vitaly Cheptsov","email":"vit9696@protonmail.com","username":"vit9696"},"change_message_id":"fedceccd17c297f5da3e3c249b261314d515b698","unresolved":false,"context_lines":[{"line_number":2499,"context_line":"Only the following adapter drivers use the serial string from this command:"},{"line_number":2500,"context_line":"arm-jtag-ew, cmsis_dap, esp_usb_jtag, ft232r, ftdi, hla (stlink, ti-icdi), jlink, kitprog, opendus,"},{"line_number":2501,"context_line":"openjtag, osbdm, presto, rlink, st-link, usb_blaster (ublast2), usbprog, vsllink, xds110."},{"line_number":2502,"context_line":"@end deffn"},{"line_number":2503,"context_line":""},{"line_number":2504,"context_line":"@section Interface Drivers"},{"line_number":2505,"context_line":""}],"source_content_type":"text/x-texinfo","patch_set":2,"id":"d2eb063b_e45373cd","line":2502,"in_reply_to":"5112a942_80aa83bb","updated":"2025-06-05 11:41:30.000000000","message":"Done","commit_id":"5ab76c91701c6c08e16cc52c0aca007334e30800"}],"src/jtag/drivers/jlink.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9f4738e3fca631524f9007aae4a2a21aec40bcd0","unresolved":true,"context_lines":[{"line_number":684,"context_line":"\t\t\treturn ERROR_JTAG_INIT_FAILED;"},{"line_number":685,"context_line":"\t\t}"},{"line_number":686,"context_line":"\t\tuse_serial_number \u003d true;"},{"line_number":687,"context_line":"\t\tuse_usb_address \u003d false;"},{"line_number":688,"context_line":"\t}"},{"line_number":689,"context_line":""},{"line_number":690,"context_line":"\tbool found_device;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"95124d98_f5bfa8d3","side":"PARENT","line":687,"updated":"2025-06-03 07:44:43.000000000","message":"By dropping this line now you can have `use_usb_address \u003d\u003d true` while `adapter_get_required_serial()` returns not `NULL`.\n\nThis changes the behavior in the new implementation of `jlink_open_device()`.\nIn the loop, you first find the adapter matching the serial, then you check for `use_usb_address` and trigger a `continue`.\n\nI think you need to move this line in `adapter_get_required_serial()`.","commit_id":"4fe57a0c197158958c7cc295002504d6434d4777"},{"author":{"_account_id":1002407,"name":"Vitaly Cheptsov","email":"vit9696@protonmail.com","username":"vit9696"},"change_message_id":"bb268e607f2e015c507697dc2e5b89cad1ce82b6","unresolved":false,"context_lines":[{"line_number":684,"context_line":"\t\t\treturn ERROR_JTAG_INIT_FAILED;"},{"line_number":685,"context_line":"\t\t}"},{"line_number":686,"context_line":"\t\tuse_serial_number \u003d true;"},{"line_number":687,"context_line":"\t\tuse_usb_address \u003d false;"},{"line_number":688,"context_line":"\t}"},{"line_number":689,"context_line":""},{"line_number":690,"context_line":"\tbool found_device;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"60493792_1974d7bc","side":"PARENT","line":687,"in_reply_to":"95124d98_f5bfa8d3","updated":"2025-06-03 09:31:35.000000000","message":"Done","commit_id":"4fe57a0c197158958c7cc295002504d6434d4777"},{"author":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"886f2f755cfb733963d96199f5a206a4e076d0ab","unresolved":true,"context_lines":[{"line_number":562,"context_line":"\tuse_usb_location \u003d !!adapter_usb_get_location();"},{"line_number":563,"context_line":"\tconst char *adapter_serial \u003d adapter_get_required_serial();"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"\tuint32_t serial_number;"},{"line_number":566,"context_line":"\tret \u003d jaylink_parse_serial_number(adapter_serial, \u0026serial_number);"},{"line_number":567,"context_line":"\tif (ret !\u003d JAYLINK_OK)"},{"line_number":568,"context_line":"\t\tserial_number \u003d 0;"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"e54fb12e_723a1d12","line":565,"updated":"2025-06-16 20:55:46.000000000","message":"Please move this block just before the for-loop where `serial_number` is used for the first time.","commit_id":"9e0d48e42fd5a9178c2e4d3d079c842da974d149"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"1297a917841dfa579cb799664f1a4a58ce7cc16f","unresolved":false,"context_lines":[{"line_number":562,"context_line":"\tuse_usb_location \u003d !!adapter_usb_get_location();"},{"line_number":563,"context_line":"\tconst char *adapter_serial \u003d adapter_get_required_serial();"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"\tuint32_t serial_number;"},{"line_number":566,"context_line":"\tret \u003d jaylink_parse_serial_number(adapter_serial, \u0026serial_number);"},{"line_number":567,"context_line":"\tif (ret !\u003d JAYLINK_OK)"},{"line_number":568,"context_line":"\t\tserial_number \u003d 0;"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"8edabe83_4645448c","line":565,"in_reply_to":"e54fb12e_723a1d12","updated":"2025-06-17 06:57:49.000000000","message":"Done","commit_id":"9e0d48e42fd5a9178c2e4d3d079c842da974d149"}]}