)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"5a5781ee5bdd4befe878fde6d02268311a914435","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Replace individual #define constants for STM32H7 flash registers with an"},{"line_number":10,"context_line":"enum to improve code readability and maintainability."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ib35cbdace5c2f4d12aa91c370d6ec0ce348b397f"},{"line_number":13,"context_line":"Signed-off-by: HAOUES Ahmed \u003cahmed.haoues@st.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"f55d3ff0_680677c1","line":11,"updated":"2025-07-07 16:20:31.000000000","message":"You also add another modification in the patch.\nPlease add:\n```\nWhile there, replace a magic number with the macro\nMASS_ERASE_TIMEOUT.\n```","commit_id":"d5a65e9d983acd592c2ba7f9b4f6abd865bd72cf"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"5198bf75ddbc833c4c99d501c072383c53501e89","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Replace individual #define constants for STM32H7 flash registers with an"},{"line_number":10,"context_line":"enum to improve code readability and maintainability."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ib35cbdace5c2f4d12aa91c370d6ec0ce348b397f"},{"line_number":13,"context_line":"Signed-off-by: HAOUES Ahmed \u003cahmed.haoues@st.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bc086d01_ec15c0d4","line":11,"in_reply_to":"f55d3ff0_680677c1","updated":"2025-07-28 09:52:56.000000000","message":"Done","commit_id":"d5a65e9d983acd592c2ba7f9b4f6abd865bd72cf"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"5198bf75ddbc833c4c99d501c072383c53501e89","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4d0600fd_afd39483","updated":"2025-07-28 09:52:56.000000000","message":"The patch is marked as WIP which means not ready for review. I think it looks good and could be merged with minor modification.","commit_id":"0c0aed7a611eee059f7c392fa1d6d4f80f478ed0"}],"src/flash/nor/stm32h7x.c":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"5198bf75ddbc833c4c99d501c072383c53501e89","unresolved":true,"context_lines":[{"line_number":183,"context_line":"\treturn cmd | (tmp \u003e\u003e 2) | (snb \u003c\u003c 6);"},{"line_number":184,"context_line":"}"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"static inline int stm32x_get_flash_status(struct flash_bank *bank, uint32_t *status);"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"static const struct stm32h7x_part_info stm32h7x_parts[] \u003d {"},{"line_number":189,"context_line":"\t{"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"a4783ed4_8f9fc590","line":186,"range":{"start_line":186,"start_character":7,"end_line":186,"end_character":14},"updated":"2025-07-28 09:52:56.000000000","message":"`inline` seems useless and looks very strange considering that the function is called exclusively by address so it cannot be inlined at all. You might consider dropping `inline` attribute from other `stm32x_read/write_flash_reg/reg_by_index`, I bet the speed difference is negligible unlike the code size increase.\n\nIf the `get_flash_status()` functions differ just by using STM32_FLASH_SR_INDEX vs STM32_FLASH_ISR_INDEX I would recommend to introduce a special index for reading flash errors coupled to SR or ISR and use it directly in `stm32x_read_flash_reg_by_index()` instead of introducing a new switchable function. However I have no idea if it would be sufficient even for H5.","commit_id":"0c0aed7a611eee059f7c392fa1d6d4f80f478ed0"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"74d86a0a4c3164dbacb045ad6a14652168c381ea","unresolved":true,"context_lines":[{"line_number":183,"context_line":"\treturn cmd | (tmp \u003e\u003e 2) | (snb \u003c\u003c 6);"},{"line_number":184,"context_line":"}"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"static inline int stm32x_get_flash_status(struct flash_bank *bank, uint32_t *status);"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"static const struct stm32h7x_part_info stm32h7x_parts[] \u003d {"},{"line_number":189,"context_line":"\t{"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"d0950008_1eba0ca2","line":186,"range":{"start_line":186,"start_character":7,"end_line":186,"end_character":14},"in_reply_to":"0c831ebd_caaa9f4f","updated":"2025-08-30 14:31:39.000000000","message":"No problem","commit_id":"0c0aed7a611eee059f7c392fa1d6d4f80f478ed0"},{"author":{"_account_id":1002386,"name":"Ahmed Haoues","email":"ahmed.haoues@st.com","username":"ahmed-haoues"},"change_message_id":"722f9c9287ab8c47baa2e9da3fc60f944fc5463e","unresolved":true,"context_lines":[{"line_number":183,"context_line":"\treturn cmd | (tmp \u003e\u003e 2) | (snb \u003c\u003c 6);"},{"line_number":184,"context_line":"}"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"static inline int stm32x_get_flash_status(struct flash_bank *bank, uint32_t *status);"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"static const struct stm32h7x_part_info stm32h7x_parts[] \u003d {"},{"line_number":189,"context_line":"\t{"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"0c831ebd_caaa9f4f","line":186,"range":{"start_line":186,"start_character":7,"end_line":186,"end_character":14},"in_reply_to":"a4783ed4_8f9fc590","updated":"2025-08-28 09:31:47.000000000","message":"ACK for inline removal for get_flash_status functions as they are called by pointers\nACK for inline removal stm32x_read/write_flash_reg\nIMO we can keep the inline for stm32x_read/write_flash_reg_by_index\n\nCan we postpone the SR/ISR cosmetic changes until H7RS support is merged to avoid review back-and-forth?","commit_id":"0c0aed7a611eee059f7c392fa1d6d4f80f478ed0"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"962ace4fe86c2321cd5f8e8c9f4ed8f9e8838c39","unresolved":false,"context_lines":[{"line_number":183,"context_line":"\treturn cmd | (tmp \u003e\u003e 2) | (snb \u003c\u003c 6);"},{"line_number":184,"context_line":"}"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"static inline int stm32x_get_flash_status(struct flash_bank *bank, uint32_t *status);"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"static const struct stm32h7x_part_info stm32h7x_parts[] \u003d {"},{"line_number":189,"context_line":"\t{"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"2ca60de9_6251eed2","line":186,"range":{"start_line":186,"start_character":7,"end_line":186,"end_character":14},"in_reply_to":"d0950008_1eba0ca2","updated":"2025-11-06 08:08:48.000000000","message":"Ack","commit_id":"0c0aed7a611eee059f7c392fa1d6d4f80f478ed0"}]}