)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ec55356b69b90efe33dcfd49287ab530c91b5eff","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b867a5aa_91af2b2d","updated":"2025-05-04 09:42:01.000000000","message":"Hi, in my local build I have a dirty patch to build these adapters for ARM host on my x86 PC. It is useful for build coverage. So, thanks for this effort to upstream the same functionality in a clean way.\n\nI prefer we keep the build with default \u0027yes\u0027 for ARM only and \u0027no\u0027 for the rest, so do not remove the code that checks it.\n\nIn parallel, it would be nice to add a configure flag like `--enable-force-all` to force the build also for code that would not be build.\nThis flag should be used in future not only the arm adapters, but also for adapters and for extra code that cannot be build for lack of libraries.\nFor example, in case of missing libusb we could force the build with some dummy `libusb.h` that provides the API all returning error. Of course, the libusb adapters would not be functional, but the build coverage would be ok.\n\nCan you please consider adding the flag `--enable-force-all` and use it for these three ARM adapters only? Future use cases could follow","commit_id":"a6fc50848d8fdce05f185743dc0018700bf92a7b"},{"author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"change_message_id":"acb36ee1e974e659401eb7e180a082abcf2c704a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e382ed09_868984a6","updated":"2025-05-03 18:26:20.000000000","message":"The previous code hid the configuration options for these adapters if the target architecture was not arm* or aarch64. However, these adapters build fine regardless of the architecture.\n\nThe first revision of this patch allows the user to compile them in, no matter what the target architecture is. This way, it is easier to check whether they at least compile. Is this change OK?\n\nI gather we do not want to enable these adapters by default, or do we?","commit_id":"a6fc50848d8fdce05f185743dc0018700bf92a7b"},{"author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"change_message_id":"6f0935b03a9d0021e1c5d19e74b813fe2ab3508e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e6c57f34_fc78211f","updated":"2025-05-26 16:52:49.000000000","message":"This is harder to do than expected. It turns out that Autoconf has an interesting limitation with regards to the help text. The gory details are here:\n\nhttps://lists.gnu.org/archive/html/autoconf/2025-05/msg00014.html\n\nThe current configure.ac shows --enable-bcm2835gpio etc. in the help text, but attempting to enable them on non-ARM hosts is silently ignored. Even on ARM hosts, those adapters do not appear in the configuration summary.\n\nI can write a patch which does not ignore those 5 depending on the architecture, so that you can test whether building them works on an x86-64 host. And they would appear in the configuration summary. However, I can only make those 5 adapters disabled by default, just like they are now.\n\nThis is an improvement with regards to the current situation. Would such a patch be accepted? Otherwise, I would let it be, because that would require a larger rewrite of configure.ac, and I haven\u0027t got the time at the moment (I have already invested more than a couple of hours in this simple change).\n\nThe main issue is that \"auto\" in our configure.ac means \"build the adapter if compilation would succeed because the necessary libraries etc. are installed\". If I let \"auto\" check whether the current host is ARM, then those adapters wouldn\u0027t build on x86-64, even if you explicitly enable them.","commit_id":"a6fc50848d8fdce05f185743dc0018700bf92a7b"},{"author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"change_message_id":"6f0935b03a9d0021e1c5d19e74b813fe2ab3508e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ac48138c_aaeb715e","in_reply_to":"92903439_9a1eaded","updated":"2025-05-26 16:52:49.000000000","message":"Ack","commit_id":"a6fc50848d8fdce05f185743dc0018700bf92a7b"},{"author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"change_message_id":"9aac33eba8ee1072b0a3893653520ef774966e17","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"92903439_9a1eaded","in_reply_to":"b867a5aa_91af2b2d","updated":"2025-05-20 15:03:23.000000000","message":"I\u0027ll add --enable-force-all to the wish list for a future, separate patch.\n\nThese 3 adapters are for arm*|aarch64. We also have another 2 adapters, ep93xx and at91rm9200, which are for arm* only. I\u0027ll see if I can get all 5 adapters in this patch.","commit_id":"a6fc50848d8fdce05f185743dc0018700bf92a7b"},{"author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"change_message_id":"9aac33eba8ee1072b0a3893653520ef774966e17","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"131ef224_048335b7","in_reply_to":"e382ed09_868984a6","updated":"2025-05-20 15:03:23.000000000","message":"Done","commit_id":"a6fc50848d8fdce05f185743dc0018700bf92a7b"},{"author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"change_message_id":"5d6dd4ea8d4f4548f8871306e171124df9651cfb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e005f793_743d0e89","in_reply_to":"e6c57f34_fc78211f","updated":"2025-06-08 08:56:08.000000000","message":"Done","commit_id":"a6fc50848d8fdce05f185743dc0018700bf92a7b"},{"author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"change_message_id":"5d6dd4ea8d4f4548f8871306e171124df9651cfb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a6049920_f2a5c79e","updated":"2025-06-08 08:56:08.000000000","message":"I have reworked the patch as explained in my last comment.\n\nAlthough the patch does not implement all things we want yet, it is an improvement with regards to the current situation.\n\nAt a later date, after all easy clean-ups are done, I\u0027ll see what further improvements I can contribute.","commit_id":"0f6870aa08290411d503eb7ebc376079ca7db8e8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0d2eac3efac163efc4f350bbfbff1ececbb08e4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0c44dff4_a8490374","updated":"2025-06-08 15:13:25.000000000","message":"Let\u0027s keep it this way, the comment is enough to remember the relationship with arm CPUs.\nOnce all adapters would be cleanup (and maybe the deprecated ones would be dropped) we could return to add the flag `--enable-force-all`\nThanks","commit_id":"0f6870aa08290411d503eb7ebc376079ca7db8e8"}],"configure.ac":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ec55356b69b90efe33dcfd49287ab530c91b5eff","unresolved":true,"context_lines":[{"line_number":347,"context_line":"    [parport_use_giveio\u003d$enableval], [parport_use_giveio\u003d])"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"AS_CASE([\"${host_cpu}\"],"},{"line_number":350,"context_line":"  [arm*|aarch64], ["},{"line_number":351,"context_line":"    AC_ARG_ENABLE([bcm2835gpio],"},{"line_number":352,"context_line":"      AS_HELP_STRING([--enable-bcm2835gpio], [Enable building support for bitbanging on BCM2835 (as found in Raspberry Pi)]),"},{"line_number":353,"context_line":"      [build_bcm2835gpio\u003d$enableval], [build_bcm2835gpio\u003dno])"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"cb8ee1f8_7bad96c1","side":"PARENT","line":350,"updated":"2025-05-04 09:42:01.000000000","message":"keep the check to set a variable `is_host_cpu_arm`","commit_id":"afbd01b0a46f3a81fe6076c002ad66973dcfb64c"},{"author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"change_message_id":"9aac33eba8ee1072b0a3893653520ef774966e17","unresolved":false,"context_lines":[{"line_number":347,"context_line":"    [parport_use_giveio\u003d$enableval], [parport_use_giveio\u003d])"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"AS_CASE([\"${host_cpu}\"],"},{"line_number":350,"context_line":"  [arm*|aarch64], ["},{"line_number":351,"context_line":"    AC_ARG_ENABLE([bcm2835gpio],"},{"line_number":352,"context_line":"      AS_HELP_STRING([--enable-bcm2835gpio], [Enable building support for bitbanging on BCM2835 (as found in Raspberry Pi)]),"},{"line_number":353,"context_line":"      [build_bcm2835gpio\u003d$enableval], [build_bcm2835gpio\u003dno])"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"87d90c95_8ae52ce7","side":"PARENT","line":350,"in_reply_to":"cb8ee1f8_7bad96c1","updated":"2025-05-20 15:03:23.000000000","message":"Ack","commit_id":"afbd01b0a46f3a81fe6076c002ad66973dcfb64c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ec55356b69b90efe33dcfd49287ab530c91b5eff","unresolved":true,"context_lines":[{"line_number":196,"context_line":"m4_define([AMTJTAGACCEL_ADAPTER],"},{"line_number":197,"context_line":"\t[[[amtjtagaccel], [Amontec JTAG-Accelerator driver], [AMTJTAGACCEL]]])"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"m4_define([BITBANG_ON_PARTICULAR_SYSTEMS],"},{"line_number":200,"context_line":"\t[[[bcm2835gpio], [Bitbanging on BCM2835 (as found in Raspberry Pi)], [BCM2835GPIO]],"},{"line_number":201,"context_line":"\t[[imx_gpio], [Bitbanging on NXP IMX processors], [IMX_GPIO]],"},{"line_number":202,"context_line":"\t[[am335xgpio], [Bitbanging on AM335x (as found in Beaglebones)], [AM335XGPIO]]])"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"8c40254f_584a8e4c","line":199,"updated":"2025-05-04 09:42:01.000000000","message":"maybe call them like HOST_ARM_ADAPTER or HOST_ARM_BITBANG_ADAPTER","commit_id":"a6fc50848d8fdce05f185743dc0018700bf92a7b"},{"author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"change_message_id":"9aac33eba8ee1072b0a3893653520ef774966e17","unresolved":false,"context_lines":[{"line_number":196,"context_line":"m4_define([AMTJTAGACCEL_ADAPTER],"},{"line_number":197,"context_line":"\t[[[amtjtagaccel], [Amontec JTAG-Accelerator driver], [AMTJTAGACCEL]]])"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"m4_define([BITBANG_ON_PARTICULAR_SYSTEMS],"},{"line_number":200,"context_line":"\t[[[bcm2835gpio], [Bitbanging on BCM2835 (as found in Raspberry Pi)], [BCM2835GPIO]],"},{"line_number":201,"context_line":"\t[[imx_gpio], [Bitbanging on NXP IMX processors], [IMX_GPIO]],"},{"line_number":202,"context_line":"\t[[am335xgpio], [Bitbanging on AM335x (as found in Beaglebones)], [AM335XGPIO]]])"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"6e51af9b_4e36a1fd","line":199,"in_reply_to":"8c40254f_584a8e4c","updated":"2025-05-20 15:03:23.000000000","message":"Ack","commit_id":"a6fc50848d8fdce05f185743dc0018700bf92a7b"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ec55356b69b90efe33dcfd49287ab530c91b5eff","unresolved":true,"context_lines":[{"line_number":674,"context_line":"PROCESS_ADAPTERS([RSHIM_ADAPTER], [\"x$can_build_rshim\" \u003d \"xyes\"],"},{"line_number":675,"context_line":"                                  [internal error: validation should happen beforehand])"},{"line_number":676,"context_line":"PROCESS_ADAPTERS([AMTJTAGACCEL_ADAPTER], [true], [unused])"},{"line_number":677,"context_line":"PROCESS_ADAPTERS([BITBANG_ON_PARTICULAR_SYSTEMS], [true], [unused])"},{"line_number":678,"context_line":"PROCESS_ADAPTERS([DUMMY_ADAPTER], [true], [unused])"},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"AS_IF([test \"x$enable_linuxgpiod\" !\u003d \"xno\"], ["}],"source_content_type":"application/octet-stream","patch_set":1,"id":"80245c75_87c20d58","line":677,"updated":"2025-05-04 09:42:01.000000000","message":"`PROCESS_ADAPTERS([HOST_ARM_ADAPTER], [\"x$is_host_arm\" \u003d \"xyes\"], [ARM host])`\n\ncan become:\n`[\"x$is_host_arm\" \u003d \"xyes\" -o \"x$force_all\" \u003d \"xyes\"]`","commit_id":"a6fc50848d8fdce05f185743dc0018700bf92a7b"},{"author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"change_message_id":"9aac33eba8ee1072b0a3893653520ef774966e17","unresolved":false,"context_lines":[{"line_number":674,"context_line":"PROCESS_ADAPTERS([RSHIM_ADAPTER], [\"x$can_build_rshim\" \u003d \"xyes\"],"},{"line_number":675,"context_line":"                                  [internal error: validation should happen beforehand])"},{"line_number":676,"context_line":"PROCESS_ADAPTERS([AMTJTAGACCEL_ADAPTER], [true], [unused])"},{"line_number":677,"context_line":"PROCESS_ADAPTERS([BITBANG_ON_PARTICULAR_SYSTEMS], [true], [unused])"},{"line_number":678,"context_line":"PROCESS_ADAPTERS([DUMMY_ADAPTER], [true], [unused])"},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"AS_IF([test \"x$enable_linuxgpiod\" !\u003d \"xno\"], ["}],"source_content_type":"application/octet-stream","patch_set":1,"id":"bd5213d1_18485eff","line":677,"in_reply_to":"80245c75_87c20d58","updated":"2025-05-20 15:03:23.000000000","message":"Ack","commit_id":"a6fc50848d8fdce05f185743dc0018700bf92a7b"}]}