)]}'
{"id":"openocd~master~Icbc5789f59696bd28f9d1151bc3e29f4adb74670","project":"openocd","branch":"master","hashtags":[],"change_id":"Icbc5789f59696bd28f9d1151bc3e29f4adb74670","subject":"target: drop struct target_type::target_jim_commands()","status":"MERGED","created":"2025-05-10 14:12:21.000000000","updated":"2025-05-25 12:42:46.000000000","submitted":"2025-05-25 12:42:46.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8903","meta_rev_id":"29c3c32e8c903079083150cec68763a65aba822c","_number":8903,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-05-25 12:42:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-05-25 12:42:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-05-10 14:43:10.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"e139dc9df37c43e76ba2241d22456a187b0af9f1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-05-10 14:12:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8d42823c67334615ccdc29f7be9d39e33224e7a8","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-05-10 14:43:10.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/21110/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/20251/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"29f58e320db707e40a137d375ec1f2a92d18e8c2","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-05-17 08:40:22.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"29c3c32e8c903079083150cec68763a65aba822c","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-05-25 12:42:46.000000000","message":"Change has been successfully cherry-picked as 4c1e2105c4e5ad3188dae6e62ce019df15c7e52a","accounts_in_message":[],"_revision_number":2}],"current_revision":"4c1e2105c4e5ad3188dae6e62ce019df15c7e52a","revisions":{"3d0691bcb0e35402dc71aef5d3f387cfadf4695a":{"kind":"REWORK","_number":1,"created":"2025-05-10 14:12:21.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/03/8903/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/03/8903/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/03/8903/1 \u0026\u0026 git checkout -b change-8903 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/03/8903/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/03/8903/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/03/8903/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/03/8903/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/03/8903/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"09347113980cd77b3d18360d7be67eceaf326093","subject":"checkpatch: drop camelcase symbols not used anymore"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-05-10 12:14:05.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-05-10 14:11:19.000000000","tz":120},"subject":"target: drop struct target_type::target_jim_commands()","message":"target: drop struct target_type::target_jim_commands()\n\nThe API was introduced in 2008 by commit 8d73c2a9b0c0 (\"duan ellis\ntarget tcl work in progress\") and never used.\n\nDrop it!\n\nChange-Id: Icbc5789f59696bd28f9d1151bc3e29f4adb74670\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"4c1e2105c4e5ad3188dae6e62ce019df15c7e52a":{"kind":"REWORK","_number":2,"created":"2025-05-25 12:42:46.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/03/8903/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/03/8903/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/03/8903/2 \u0026\u0026 git checkout -b change-8903 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/03/8903/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/03/8903/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/03/8903/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/03/8903/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/03/8903/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3c7725ea703e186c9d9ced3b0e03231982abdbfd","subject":"checkpatch: drop camelcase symbols not used anymore"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-05-10 12:14:05.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-05-25 12:42:46.000000000","tz":0},"subject":"target: drop struct target_type::target_jim_commands()","message":"target: drop struct target_type::target_jim_commands()\n\nThe API was introduced in 2008 by commit 8d73c2a9b0c0 (\"duan ellis\ntarget tcl work in progress\") and never used.\n\nDrop it!\n\nChange-Id: Icbc5789f59696bd28f9d1151bc3e29f4adb74670\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8903\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}