)]}'
{"id":"openocd~master~Ic0d1990361a5f1c48f9e88e1560a7927ba8fb577","project":"openocd","branch":"master","attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2025-08-26 11:24:42.000000000","reason":"\u003cGERRIT_ACCOUNT_1002047\u003e replied on the change","reason_account":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"}},"1002047":{"account":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"last_update":"2025-08-29 16:16:13.000000000","reason":"\u003cGERRIT_ACCOUNT_1000687\u003e replied on the change","reason_account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}},"removed_from_attention_set":{},"hashtags":[],"change_id":"Ic0d1990361a5f1c48f9e88e1560a7927ba8fb577","subject":"helper/command: don\u0027t stop polling under `capture`","status":"NEW","created":"2025-05-13 16:46:22.000000000","updated":"2025-08-29 16:16:13.000000000","submit_type":"CHERRY_PICK","mergeable":true,"submittable":false,"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"dd4ccccde16dd87ef43e51f4cec664b7bc79dc74","_number":8908,"owner":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:jenkins-gerrit-trigger","value":1,"date":"2025-05-17 12:21:25.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"disliked":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":-1,"date":"2025-08-29 16:16:13.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","value":-1,"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-05-17 12:21:25.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-08-26 11:24:42.000000000","updated_by":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2025-08-29 16:16:13.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"55d4efe1e8c3c0473750a3fa52cde5569cf2c1fd","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2025-05-13 16:46:22.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b7717b07b3ac09c07ea643de25c9049b0197b02c","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-05-17 12:21:25.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/21138/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"f7cb5bc212b4419a1b8ca42c584f127b94d8d827","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-05-17 13:44:34.000000000","message":"Patch Set 1:\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20279/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"f53f416f4ac97bda0c5c69d5f7ee1b6decec4314","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2025-08-26 11:24:42.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"dd4ccccde16dd87ef43e51f4cec664b7bc79dc74","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-08-29 16:16:13.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1}],"current_revision":"5caa5be48df46e8ba32ff179005bb9f16bf9853a","revisions":{"5caa5be48df46e8ba32ff179005bb9f16bf9853a":{"kind":"REWORK","_number":1,"created":"2025-05-13 16:46:22.000000000","uploader":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"ref":"refs/changes/08/8908/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/08/8908/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/08/8908/1 \u0026\u0026 git checkout -b change-8908 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/08/8908/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/08/8908/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/08/8908/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/08/8908/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/08/8908/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"744955e5b4f4f943c187622f4ae977bc4cd6fdb7","subject":"LICENSES: add dual/CC-BY-4.0"}],"author":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2025-03-31 09:36:36.000000000","tz":180},"committer":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2025-05-13 16:45:12.000000000","tz":180},"subject":"helper/command: don\u0027t stop polling under `capture`","message":"helper/command: don\u0027t stop polling under `capture`\n\nThe call to `jtag_poll_mask()` was introduced in\ncommit 1abc26d7a2b7172184c64d2151bf4803699993da (\"helper: fix flaky\ncapture command\").\nThe reasoning was: output from polling could overwrite TCL command\u0027s\nresult.\nHowever, commit 2c8c2cb6b1426afc73519a7445a71a0aed36cf0f (\"command:\nPrepend logs during command capture\") changed the behavior, so that the\nresult is appended to the output and does not overwrite it.\nTherefore, there is no point in disabling polling when capturing output.\n\nMoreover, diabling polling may cause a change in behavior, e.g.:\n* A target is using semihosting.\n* `sleep 10000` results in a number of semihosting calls being\n  handled due to `target_type::poll` being called approx. every\n  `polling_interval` ms.\n* `capture {sleep 10000}` used to result in at most one call to\n  `target_type::poll` by `target_call_timer_callbacks()` in\n  `jim_command_dispatch()`.\n\nChange-Id: Ic0d1990361a5f1c48f9e88e1560a7927ba8fb577\nSigned-off-by: Evgeniy Naydanov \u003cevgeniy.naydanov@syntacore.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"NEED"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}}]}