)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a6f5aa298a58acec2dda860f6204f349ccc30846","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"94eb0eb3_c4176014","updated":"2025-05-21 13:36:27.000000000","message":"The hardcoded list of vendors can be extended in the same patch that adds a new vendor folder.\n\nI should change in the commit message (or in a comment in the code) that the conversion works by replacing\n`path/to/a/certain/config_file`\nwith\n`path/to/a/certain/${vendor}/config_file`\nusing the same folder separator `/` or `\\` used before the file name.\n\nSome file name is already in one of the forms\n`path/to/a/certain/vendor_config_file`\n`path/to/a/certain/vendor-config_file`\nand we should try also\n`path/to/a/certain/vendor/config_file`\n\nLet me know if you think this way of working is acceptable","commit_id":"cbce1a93ed2ce90f1273bf4c181c770488f9c217"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"967cb59878ad773aa34e07410035694d1e8c70df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fc930041_a509cf84","in_reply_to":"2cfea4b5_3a0b59fc","updated":"2025-05-21 21:59:54.000000000","message":"I thought renaming were few, apart from `vendor_xxx.cfg` \u003d\u003e `vendor/xxx.cfg` already handled here.\n\nIf you think there are too renaming, than a table could be a solution. But in this case I would not put the table in `src/helper/startup.tcl` but in a dedicated script in `tcl/` folder. Or one per subfolder or a single one in top `tcl/`.\nWe cannot force users to recompile the binary to handle a script renaming.","commit_id":"cbce1a93ed2ce90f1273bf4c181c770488f9c217"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"593b01f2076c7a0660ea55aa1308347c8292e3ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2cfea4b5_3a0b59fc","in_reply_to":"94eb0eb3_c4176014","updated":"2025-05-21 18:40:17.000000000","message":"Thanks for the patch Antonio! The main problem is that we do not only move files but also rename it, right? What about using a dedicated file/list that contains a mapping between new and old filename?","commit_id":"cbce1a93ed2ce90f1273bf4c181c770488f9c217"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"1c9e2c00e423b6d5dadab55010651edb98e51da0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2f697eae_2ce203c6","in_reply_to":"c956b5f6_57f9e686","updated":"2025-05-22 09:24:45.000000000","message":"If the majority of renames are not trivial, than we can drop the handling of such trivial renames and use only the table. Let\u0027s see!\nAnyway, all these renaming helpers should be dropped asap.","commit_id":"cbce1a93ed2ce90f1273bf4c181c770488f9c217"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"4f98cd9eca5d3be286154f8dd4ac3d7d7be00ce4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c956b5f6_57f9e686","in_reply_to":"fc930041_a509cf84","updated":"2025-05-22 08:43:49.000000000","message":"No, especially board files will be renamed to the actual name provided by the vendor. This is more user friendly. Also some target files have \u0027xxx\u0027 suffixes etc that will be removed and adapted to the names provided by the vendor.\n\nThe new version looks promising, I will rebase by nordic changes on top of it and test it.","commit_id":"cbce1a93ed2ce90f1273bf4c181c770488f9c217"}]}
