)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1002412,"name":"electricworry","email":"me@electricworry.net","username":"electricworry"},"change_message_id":"b7b1dc36dccc78512f2de99d77ac00d220369ddc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2b2db2e0_0e6167fc","updated":"2025-05-29 11:40:22.000000000","message":"Really I was just following what I thought was a standard convention. e.g. the same is done for BCM2836.\n\nYou are correct. It\u0027s not changeable. Shall I fix that with a further patch?","commit_id":"38ccd8677ac2b72733fc673933f38028b85a4a50"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"1704d44422ee2e0f7cb5f296096f9437d4bd95f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e28ddd10_a9b69636","updated":"2025-05-29 11:08:33.000000000","message":"Thanks for the patch!","commit_id":"38ccd8677ac2b72733fc673933f38028b85a4a50"},{"author":{"_account_id":1002412,"name":"electricworry","email":"me@electricworry.net","username":"electricworry"},"change_message_id":"c13a44165e7b38d9be1c85584614fc07c20205a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"61bfdd38_16297b08","in_reply_to":"2b2db2e0_0e6167fc","updated":"2025-05-29 12:19:28.000000000","message":"Done","commit_id":"38ccd8677ac2b72733fc673933f38028b85a4a50"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7003df5a2c3b71d0e1fe39719bc9700b0cc95f87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f8172894_bf38fe93","updated":"2025-06-04 22:17:14.000000000","message":"Looks ok for me. Just a curiosity below","commit_id":"df92c767185598bdc533c48e8ac8c6a1cc4161d9"},{"author":{"_account_id":1002412,"name":"electricworry","email":"me@electricworry.net","username":"electricworry"},"change_message_id":"c13a44165e7b38d9be1c85584614fc07c20205a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4c77960f_3bd61508","updated":"2025-05-29 12:19:28.000000000","message":"Thanks. I think I\u0027ve done it ok...","commit_id":"df92c767185598bdc533c48e8ac8c6a1cc4161d9"},{"author":{"_account_id":1002412,"name":"electricworry","email":"me@electricworry.net","username":"electricworry"},"change_message_id":"3f778887c07f456651b3aa0faedd73a558ec5832","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"420b79b1_58f424bd","updated":"2025-06-07 15:02:26.000000000","message":"All done I think, thank you.","commit_id":"79256d6425d65d303efa05e13b76361b5f86708b"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"6fa092dc988fe2d05d43c6d68f8957d473f24c12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a5358521_f309591b","updated":"2025-06-07 20:54:28.000000000","message":"Thanks","commit_id":"79256d6425d65d303efa05e13b76361b5f86708b"}],"tcl/target/allwinner_h618.cfg":[{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"1704d44422ee2e0f7cb5f296096f9437d4bd95f4","unresolved":true,"context_lines":[{"line_number":12,"context_line":"\tset  _CHIPNAME h618"},{"line_number":13,"context_line":"}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"if { [info exists CHIPCORES] } {"},{"line_number":16,"context_line":"\tset _cores $CHIPCORES"},{"line_number":17,"context_line":"} else {"},{"line_number":18,"context_line":"\tset _cores 4"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"1178813b_e316713e","line":15,"updated":"2025-05-29 11:08:33.000000000","message":"What is the reason to make this configurable? Are there versions with different number of cores?","commit_id":"38ccd8677ac2b72733fc673933f38028b85a4a50"},{"author":{"_account_id":1002412,"name":"electricworry","email":"me@electricworry.net","username":"electricworry"},"change_message_id":"10dbb09c13ac3c9743e874bdd776b47554f8fb52","unresolved":true,"context_lines":[{"line_number":12,"context_line":"\tset  _CHIPNAME h618"},{"line_number":13,"context_line":"}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"if { [info exists CHIPCORES] } {"},{"line_number":16,"context_line":"\tset _cores $CHIPCORES"},{"line_number":17,"context_line":"} else {"},{"line_number":18,"context_line":"\tset _cores 4"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"a63d008f_d8aeacca","line":15,"in_reply_to":"1178813b_e316713e","updated":"2025-05-29 11:43:12.000000000","message":"Really I was just following what I thought was a standard convention. e.g. the same is done for BCM2836.\n\nYou are correct. It\u0027s not changeable. Shall I fix that with a further patch?","commit_id":"38ccd8677ac2b72733fc673933f38028b85a4a50"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"f84555cef3686b5b3234fc34c0140962101f12cc","unresolved":true,"context_lines":[{"line_number":12,"context_line":"\tset  _CHIPNAME h618"},{"line_number":13,"context_line":"}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"if { [info exists CHIPCORES] } {"},{"line_number":16,"context_line":"\tset _cores $CHIPCORES"},{"line_number":17,"context_line":"} else {"},{"line_number":18,"context_line":"\tset _cores 4"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"d6632228_b9064ddd","line":15,"in_reply_to":"a63d008f_d8aeacca","updated":"2025-05-29 11:49:51.000000000","message":"Yep, there are several copy/paste \u0027errors\u0027 in config files and other parts of the source code. Please upload a new version of the patch and fix it - no new/additional patch. Thanks!","commit_id":"38ccd8677ac2b72733fc673933f38028b85a4a50"},{"author":{"_account_id":1002412,"name":"electricworry","email":"me@electricworry.net","username":"electricworry"},"change_message_id":"c13a44165e7b38d9be1c85584614fc07c20205a9","unresolved":false,"context_lines":[{"line_number":12,"context_line":"\tset  _CHIPNAME h618"},{"line_number":13,"context_line":"}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"if { [info exists CHIPCORES] } {"},{"line_number":16,"context_line":"\tset _cores $CHIPCORES"},{"line_number":17,"context_line":"} else {"},{"line_number":18,"context_line":"\tset _cores 4"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"3422a927_b61bf722","line":15,"in_reply_to":"d6632228_b9064ddd","updated":"2025-05-29 12:19:28.000000000","message":"Done","commit_id":"38ccd8677ac2b72733fc673933f38028b85a4a50"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7003df5a2c3b71d0e1fe39719bc9700b0cc95f87","unresolved":true,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"\tcti create $_CTINAME -dap $_CHIPNAME.dap -ap-num 1 -baseaddr [lindex $_CTIBASE $_core]"},{"line_number":47,"context_line":"\ttarget create $_TARGETNAME aarch64 -dap $_CHIPNAME.dap -ap-num 1 -dbgbase [lindex $_DBGBASE $_core] -cti $_CTINAME"},{"line_number":48,"context_line":"\t$_TARGETNAME configure -event reset-assert-post { aarch64  dbginit }"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"\tset _smp_command \"$_smp_command $_TARGETNAME\""},{"line_number":51,"context_line":"}"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"19bd541d_79d2869f","line":48,"updated":"2025-06-04 22:17:14.000000000","message":"Curiosity:\nI see this `dbginit` command used in the event `reset-assert-post` in few config files for SoC with cortex-a or aarch64.\nI see in a previous comment that you made this file looking at the BCM2836, so probably you got from there.\n\nMy question is: what is the need for this line?\nI can imagine that at reset the CPU is not immediately accessible, so you get an error from reset de-assert and you need to run this again when the target becomes accessible.\nWhat if you remove this line or you replace it with a delay to the reset with, e.g.\n`adapter srst delay 200`\nWould OpenOCD work after a command `reset`?","commit_id":"df92c767185598bdc533c48e8ac8c6a1cc4161d9"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"bb922ad9be897bf6de1c82e04f18425ff2bae39d","unresolved":true,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"\tcti create $_CTINAME -dap $_CHIPNAME.dap -ap-num 1 -baseaddr [lindex $_CTIBASE $_core]"},{"line_number":47,"context_line":"\ttarget create $_TARGETNAME aarch64 -dap $_CHIPNAME.dap -ap-num 1 -dbgbase [lindex $_DBGBASE $_core] -cti $_CTINAME"},{"line_number":48,"context_line":"\t$_TARGETNAME configure -event reset-assert-post { aarch64  dbginit }"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"\tset _smp_command \"$_smp_command $_TARGETNAME\""},{"line_number":51,"context_line":"}"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"1e0a57d9_8c34afe9","line":48,"in_reply_to":"19bd541d_79d2869f","updated":"2025-06-04 22:25:14.000000000","message":"I see from the next patch in this series that you don\u0027t have access to the reset pin through the JTAG. So probably you cannot run the test I have asked you.\nIn this case, I would suggest you to drop this line as it\u0027s probably useless and it\u0027s not tested in your environment.","commit_id":"df92c767185598bdc533c48e8ac8c6a1cc4161d9"},{"author":{"_account_id":1002412,"name":"electricworry","email":"me@electricworry.net","username":"electricworry"},"change_message_id":"3f778887c07f456651b3aa0faedd73a558ec5832","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"\tcti create $_CTINAME -dap $_CHIPNAME.dap -ap-num 1 -baseaddr [lindex $_CTIBASE $_core]"},{"line_number":47,"context_line":"\ttarget create $_TARGETNAME aarch64 -dap $_CHIPNAME.dap -ap-num 1 -dbgbase [lindex $_DBGBASE $_core] -cti $_CTINAME"},{"line_number":48,"context_line":"\t$_TARGETNAME configure -event reset-assert-post { aarch64  dbginit }"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"\tset _smp_command \"$_smp_command $_TARGETNAME\""},{"line_number":51,"context_line":"}"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"aeddafa2_ef927957","line":48,"in_reply_to":"1e0a57d9_8c34afe9","updated":"2025-06-07 15:02:26.000000000","message":"Thank you. Yes, I am merely copying other configurations with a lack of knowledge. Removing the line caused no problem so it was redundant.","commit_id":"df92c767185598bdc533c48e8ac8c6a1cc4161d9"}]}