)]}'
{"id":"openocd~master~I3cdc0f6aef8a5110073aeef333c439e61fc54032","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2025-06-29 07:32:22.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I3cdc0f6aef8a5110073aeef333c439e61fc54032","subject":"target: use array size to constraint the loop","status":"MERGED","created":"2025-06-14 13:12:14.000000000","updated":"2025-06-29 07:32:25.000000000","submitted":"2025-06-29 07:32:25.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8952","meta_rev_id":"a7af0cdc13d596eb230f60b649cf56ec9e92ce24","_number":8952,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1002224,"name":"Brandon Martin","username":"martinbv07"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-06-29 07:32:25.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-06-29 07:32:25.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1002224,"name":"Brandon Martin","username":"martinbv07"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-06-29 07:32:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1002224,"name":"Brandon Martin","username":"martinbv07"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-06-14 16:51:17.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-06-14 18:29:10.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-06-17 04:22:36.000000000","updated_by":{"_account_id":1002224,"name":"Brandon Martin","username":"martinbv07"},"reviewer":{"_account_id":1002224,"name":"Brandon Martin","username":"martinbv07"},"state":"REVIEWER"}],"messages":[{"id":"e46984f1cc679e96e01bb9709f59694cdda3ce94","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-06-14 13:12:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c384271787f26177809a332987adefe9791184b8","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-06-14 18:29:10.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20461/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/21324/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"ab8aef62792ecb6f4d9821cff32248b5e30c4c8b","author":{"_account_id":1002224,"name":"Brandon Martin","username":"martinbv07"},"real_author":{"_account_id":1002224,"name":"Brandon Martin","username":"martinbv07"},"date":"2025-06-17 04:22:36.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"12e918c8e749ed2efa38a5420e4508d39a0c2036","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-06-29 07:32:22.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"a7af0cdc13d596eb230f60b649cf56ec9e92ce24","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-06-29 07:32:25.000000000","message":"Change has been successfully cherry-picked as df525290cb11ab40968253b7d4c5588b1aab7d82","accounts_in_message":[],"_revision_number":2}],"current_revision":"df525290cb11ab40968253b7d4c5588b1aab7d82","revisions":{"eb0aebb3dca272ca189215b1ea2050141df70b89":{"kind":"REWORK","_number":1,"created":"2025-06-14 13:12:14.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/52/8952/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/52/8952/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/52/8952/1 \u0026\u0026 git checkout -b change-8952 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/52/8952/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/52/8952/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/52/8952/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/52/8952/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/52/8952/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b2e2bc8bcbb04e008b4827fd16f80c17319c1d28","subject":"target: sort the targets by alphabetic order"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-06-14 13:02:04.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-06-14 13:10:16.000000000","tz":120},"subject":"target: use array size to constraint the loop","message":"target: use array size to constraint the loop\n\nInstead of using NULL terminated arrays to determine the last\nelement of the array, use the size of the array.\n\nChange-Id: I3cdc0f6aef8a5110073aeef333c439e61fc54032\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"df525290cb11ab40968253b7d4c5588b1aab7d82":{"kind":"REWORK","_number":2,"created":"2025-06-29 07:32:25.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/52/8952/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/52/8952/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/52/8952/2 \u0026\u0026 git checkout -b change-8952 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/52/8952/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/52/8952/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/52/8952/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/52/8952/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/52/8952/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cd749419caae4f083daa2e0717fb2c6747ba033a","subject":"target: sort the targets by alphabetic order"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-06-14 13:02:04.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-06-29 07:32:25.000000000","tz":0},"subject":"target: use array size to constraint the loop","message":"target: use array size to constraint the loop\n\nInstead of using NULL terminated arrays to determine the last\nelement of the array, use the size of the array.\n\nChange-Id: I3cdc0f6aef8a5110073aeef333c439e61fc54032\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8952\nTested-by: jenkins\nReviewed-by: Brandon Martin\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}