)]}'
{"id":"openocd~master~I63c283a9a1095167b78e69e9ee879c378a6b9f2a","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001667":{"account":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"last_update":"2025-06-29 07:33:50.000000000","reason":"Change was submitted"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2025-06-19 08:08:38.000000000","reason":"\u003cGERRIT_ACCOUNT_1000687\u003e replied on the change","reason_account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}},"hashtags":[],"change_id":"I63c283a9a1095167b78e69e9ee879c378a6b9f2a","subject":"openocd.c: \u0027init\u0027 should fail if GDB service cannot be created","status":"MERGED","created":"2025-06-17 11:26:58.000000000","updated":"2025-06-29 07:33:50.000000000","submitted":"2025-06-29 07:33:50.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":6,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"8957","meta_rev_id":"576975bd0f79f7ee67f19185f87d2caea5addd72","_number":8957,"owner":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-06-29 07:33:50.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-06-29 07:33:50.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-06-29 07:33:50.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"}],"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-06-17 11:27:09.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-06-17 11:41:50.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-06-17 12:00:33.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"CC"},{"updated":"2025-06-17 14:17:51.000000000","updated_by":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"reviewer":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"state":"CC"},{"updated":"2025-06-17 20:43:44.000000000","updated_by":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"reviewer":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"state":"CC"},{"updated":"2025-06-19 08:22:14.000000000","updated_by":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"reviewer":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"state":"REVIEWER"},{"updated":"2025-06-19 16:23:26.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"c7ce810eab7121e6aca61dad8cd810e047b445cb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2025-06-17 11:26:58.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ce9a8e1d71809e4018cb359e244f0ba980245121","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-06-17 11:41:50.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20477/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/21340/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"f7554fcac7e4b7f72dfec6fabcb262d86e6f69c8","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-06-17 12:00:33.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"ef2e2d85b82b27ab9925df026b79e1454923460a","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2025-06-17 12:59:44.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"3f8ca95aaf993c1bfd3dd9e6d5c28a446474ab91","author":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2025-06-17 14:17:51.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"57e1d9f4800a39671f899a67740f269e155d54f4","author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"real_author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"date":"2025-06-17 20:43:44.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"5db03e975279989ec6c8fb370998640a2e908901","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-06-19 08:08:38.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"896c9669d66a32014331e7226539d3040ac1f2ed","author":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2025-06-19 08:22:14.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"86eb5f40bc5c913412933ef0865df79938438ead","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-06-19 16:23:26.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"06558309ff1e4d28148c738ee7a05aaccf237f7d","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-06-29 07:33:44.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"576975bd0f79f7ee67f19185f87d2caea5addd72","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-06-29 07:33:50.000000000","message":"Change has been successfully cherry-picked as 46aa9c0e526f39c61b2c08ac1d21c998ad34259e","accounts_in_message":[],"_revision_number":2}],"current_revision":"46aa9c0e526f39c61b2c08ac1d21c998ad34259e","revisions":{"46aa9c0e526f39c61b2c08ac1d21c998ad34259e":{"kind":"REWORK","_number":2,"created":"2025-06-29 07:33:50.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/57/8957/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/57/8957/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/57/8957/2 \u0026\u0026 git checkout -b change-8957 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/57/8957/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/57/8957/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/57/8957/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/57/8957/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/57/8957/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9b660bbd1957ffc1fd86485ceef5200f8968aeb6","subject":"rtos: sort the rtos by alphabetic order"}],"author":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2025-06-17 11:17:23.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-06-29 07:33:50.000000000","tz":0},"subject":"openocd.c: \u0027init\u0027 should fail if GDB service cannot be created","message":"openocd.c: \u0027init\u0027 should fail if GDB service cannot be created\n\nIf it is not possible to create a GDB service for a certain target\n(for example the given TCP port is already occupied), the \"init\"\ncommand should fail, but it currently does not.\n\nFix this by checking the return code of gdb_target_add_all().\n\nSteps to reproduce:\n\n1) Make the port 3333/tcp occupied. For example by:\n\n   nc -l 3333\n\n2) In another terminal, launch OpenOCD. Use the gdb_port\n   3333 (which is the default). For example:\n\n   path/to/your/openocd \\\n      -c \"adapter driver ...\" \\\n      -c \"jtag newtap ...\"\n      -c \"target create ...\"\n\n3) Observe the outcome:\n\n   Before this patch:\n\n   Error \"couldn\u0027t bind gdb to socket on port 3333: Address already in use\"\n   is displayed but OpenOCD keeps running.\n\n   After this patch:\n\n   The error message is displayed and OpenOCD exits - as expected.\n\nChange-Id: I63c283a9a1095167b78e69e9ee879c378a6b9f2a\nSigned-off-by: Jan Matyas \u003cjan.matyas@codasip.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8957\nTested-by: jenkins\nReviewed-by: zapb \u003cdev@zapb.de\u003e\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"0afaa0b7b5b63ee3b51ee73d0a72a16e5f1927e5":{"kind":"REWORK","_number":1,"created":"2025-06-17 11:26:58.000000000","uploader":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"ref":"refs/changes/57/8957/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/57/8957/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/57/8957/1 \u0026\u0026 git checkout -b change-8957 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/57/8957/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/57/8957/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/57/8957/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/57/8957/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/57/8957/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1ebff3ab33c77e3f8fb4e1ddda262b606b572af1","subject":"jep106: update to revision JEP106BM Jun 2025"}],"author":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2025-06-17 11:17:23.000000000","tz":120},"committer":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2025-06-17 11:24:46.000000000","tz":120},"subject":"openocd.c: \u0027init\u0027 should fail if GDB service cannot be created","message":"openocd.c: \u0027init\u0027 should fail if GDB service cannot be created\n\nIf it is not possible to create a GDB service for a certain target\n(for example the given TCP port is already occupied), the \"init\"\ncommand should fail, but it currently does not.\n\nFix this by checking the return code of gdb_target_add_all().\n\nSteps to reproduce:\n\n1) Make the port 3333/tcp occupied. For example by:\n\n   nc -l 3333\n\n2) In another terminal, launch OpenOCD. Use the gdb_port\n   3333 (which is the default). For example:\n\n   path/to/your/openocd \\\n      -c \"adapter driver ...\" \\\n      -c \"jtag newtap ...\"\n      -c \"target create ...\"\n\n3) Observe the outcome:\n\n   Before this patch:\n\n   Error \"couldn\u0027t bind gdb to socket on port 3333: Address already in use\"\n   is displayed but OpenOCD keeps running.\n\n   After this patch:\n\n   The error message is displayed and OpenOCD exits - as expected.\n\nChange-Id: I63c283a9a1095167b78e69e9ee879c378a6b9f2a\nSigned-off-by: Jan Matyas \u003cjan.matyas@codasip.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}