)]}'
{"id":"openocd~master~I72096bfecbb45a8aa4d3a7a37ad140532b3b00b2","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2025-06-29 07:41:16.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I72096bfecbb45a8aa4d3a7a37ad140532b3b00b2","subject":"flash/nor/rp2xxx: save security state over target algo","status":"MERGED","created":"2025-06-19 07:08:53.000000000","updated":"2025-06-29 07:41:16.000000000","submitted":"2025-06-29 07:41:16.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8960","meta_rev_id":"a30e352034001f6916bcb50131719222b60a4f49","_number":8960,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-06-29 07:41:16.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-06-29 07:41:16.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-06-19 07:16:11.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-06-19 07:49:29.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-06-22 13:05:58.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"d7ba513f34f9610fd2ea4b3f8427f03740946a98","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-06-19 07:08:53.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"28b8f0d3211bd07569ce13abf9ce23974605e81a","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-06-19 07:49:29.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20487/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/21350/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"a7f241ef07a62d7ce55eeb924d97e3b11264a8fe","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-06-22 11:30:15.000000000","message":"Uploaded patch set 2: New patch set was added with same tree, parent tree, and commit message as Patch Set 1.\n\nCopied Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"f7b33ccd799d2617ab712141ea8319190fd07016","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-06-22 11:30:25.000000000","message":"Patch Set 2: -Verified","accounts_in_message":[],"_revision_number":2},{"id":"f47c17a14474ed2050983cc659191d4f3f066e8b","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-06-22 11:44:44.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20515/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/21378/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"908e0f1f7ce3ffba2149c283dc48153310396594","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-06-22 13:05:58.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"55180974f34c1aef06c00030e50522694383302f","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-06-29 07:41:11.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"a30e352034001f6916bcb50131719222b60a4f49","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-06-29 07:41:16.000000000","message":"Change has been successfully cherry-picked as c4fb64e76c526799fc43f72fe2cdd4606c8b9b52","accounts_in_message":[],"_revision_number":3}],"current_revision":"c4fb64e76c526799fc43f72fe2cdd4606c8b9b52","revisions":{"c4fb64e76c526799fc43f72fe2cdd4606c8b9b52":{"kind":"REWORK","_number":3,"created":"2025-06-29 07:41:16.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/60/8960/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/60/8960/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/60/8960/3 \u0026\u0026 git checkout -b change-8960 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/60/8960/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/60/8960/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/60/8960/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/60/8960/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/60/8960/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f547e55076e847889387904c6a0803e742aeb36d","subject":"target/cortex_m: introduce security manipulation routines"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-06-18 07:44:03.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-06-29 07:41:16.000000000","tz":0},"subject":"flash/nor/rp2xxx: save security state over target algo","message":"flash/nor/rp2xxx: save security state over target algo\n\nRP2040 and RP2350 flash driver runs a ROM API target algorithm\nin probe to setup QSPI command interface. The Cortex-M33 core\nof RP2350 has to be in secure mode with SAU and MPU switched off\nto ensure ROM API call working properly.\n\nEspecially after the flash probe (used in gdb-attach event)\nwe need to completely restore the original security state to allow\n\u0027resume\u0027 or gdb \u0027continue\u0027 without injecting strange errors\nto application code.\n\nUse cortex_m support to set secure mode and to restore it back.\n\nFixes: commit ea775d49fc71 (\"flash/nor/rp2040: add RP2350 support\")\nChange-Id: I72096bfecbb45a8aa4d3a7a37ad140532b3b00b2\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8960\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"0c3fde69ed27c99e23cfdd30b6178cb9ee6b8608":{"kind":"NO_CHANGE","_number":2,"created":"2025-06-22 11:30:15.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/60/8960/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/60/8960/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/60/8960/2 \u0026\u0026 git checkout -b change-8960 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/60/8960/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/60/8960/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/60/8960/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/60/8960/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/60/8960/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6136cd82f0c4b7a220097674be4e4a24e6b7b780","subject":"target/cortex_m: introduce security manipulation routines"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-06-18 07:44:03.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-06-22 10:53:19.000000000","tz":120},"subject":"flash/nor/rp2xxx: save security state over target algo","message":"flash/nor/rp2xxx: save security state over target algo\n\nRP2040 and RP2350 flash driver runs a ROM API target algorithm\nin probe to setup QSPI command interface. The Cortex-M33 core\nof RP2350 has to be in secure mode with SAU and MPU switched off\nto ensure ROM API call working properly.\n\nEspecially after the flash probe (used in gdb-attach event)\nwe need to completely restore the original security state to allow\n\u0027resume\u0027 or gdb \u0027continue\u0027 without injecting strange errors\nto application code.\n\nUse cortex_m support to set secure mode and to restore it back.\n\nFixes: commit ea775d49fc71 (\"flash/nor/rp2040: add RP2350 support\")\nChange-Id: I72096bfecbb45a8aa4d3a7a37ad140532b3b00b2\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"baae57625afd9410204ab2ab338849230e650106":{"kind":"REWORK","_number":1,"created":"2025-06-19 07:08:53.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/60/8960/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/60/8960/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/60/8960/1 \u0026\u0026 git checkout -b change-8960 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/60/8960/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/60/8960/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/60/8960/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/60/8960/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/60/8960/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6136cd82f0c4b7a220097674be4e4a24e6b7b780","subject":"target/cortex_m: introduce security manipulation routines"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-06-18 07:44:03.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-06-19 07:08:22.000000000","tz":120},"subject":"flash/nor/rp2xxx: save security state over target algo","message":"flash/nor/rp2xxx: save security state over target algo\n\nRP2040 and RP2350 flash driver runs a ROM API target algorithm\nin probe to setup QSPI command interface. The Cortex-M33 core\nof RP2350 has to be in secure mode with SAU and MPU switched off\nto ensure ROM API call working properly.\n\nEspecially after the flash probe (used in gdb-attach event)\nwe need to completely restore the original security state to allow\n\u0027resume\u0027 or gdb \u0027continue\u0027 without injecting strange errors\nto application code.\n\nUse cortex_m support to set secure mode and to restore it back.\n\nFixes: commit ea775d49fc71 (\"flash/nor/rp2040: add RP2350 support\")\nChange-Id: I72096bfecbb45a8aa4d3a7a37ad140532b3b00b2\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}